Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     tj@kernel.org, jiangshanlai@gmail.com
Cc:     linux-kernel@vger.kernel.org
Subject: [RFC PATCH] workqueue: Introduce __show_worker_pool_state and __show_workqueue_state.
Date:   Tue, 28 Sep 2021 20:31:06 +1000
Message-Id: <20210928103106.391694-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+7qetGqQx0TBxrJyXB2pf7hr8GuqHgtjCCLSTnNY+Sr7MCNCQ9xPVGAtgUto?=
 =?us-ascii?Q?+R69PgqUTovuYZBuH9xdNKJb5e+vMHWMm74qa4lpiuRnmCPZIC9PvgIG2sN8?=
 =?us-ascii?Q?YYsCSHATZAjJQKR+DX6gQ0IsO6RqBpNDHIiLOojhSCVPscpdiEvOpWWcSF0J?=
 =?us-ascii?Q?8dVHX4OTqej1jeDk28VfbwXgsspcTBlx9i82RjXSSVgW5JvxtSkCnSnYnZk0?=
 =?us-ascii?Q?PqC0ptUaB31LWZI87LAmafW1pvrQ7SiRS0NLJVA0S42syM1/tGEf9JPUAZH/?=
 =?us-ascii?Q?/1OHr/XuhvbysjWa+watTbfQ0X2QOrCGUKDkh1u2tI/AWb3cslVUqtBzARsV?=
 =?us-ascii?Q?rJ++CrEeq5VmSfaT5kwXfQkD6unK6O4+5YNb1OVURHeZdCe9hRXbchP0Qfe5?=
 =?us-ascii?Q?85GfY0brm/uxLxv22EIE8yjD1FP2aNNWDMbosaOTHujLS8NhPgjFOj4DlEqI?=
 =?us-ascii?Q?mwsGeISARAnfURepngqnSrO1bvWSkL50tRC65cZj7tHIX3Fz4OuTRv5StUWE?=
 =?us-ascii?Q?r8AjscWC8jUy3WBNrVq4h6sNspHMuMcpgmk/6pUt1gA03M3h1L1lmFZ6cV4G?=
 =?us-ascii?Q?Vg2ROml0xsPTw1Wt8ZCDFtZcmFnrTxYWfHtb9yV9WiJk1J+0pEQs4pplCS5P?=
 =?us-ascii?Q?ccQNRsbdykb8qgVCYVS3T/Dedol9L9oNP/ty/v5w7nDeB4JpfZ50xua0a1zl?=
 =?us-ascii?Q?fkyubATHGPp1vTISv+x1HRj2r4zShZYhy1b0y0YHpzviNLPR60HivUYB0wHH?=
 =?us-ascii?Q?iCK2tMTuDcFoM+3EbuEUlR2G/um2l77AU9/Wr2py3BpFU9mCjsevgHZ1hdNw?=
 =?us-ascii?Q?RdZefO4lD0/5EP0u5oTxhlkEBuU/rA9X83h4jWfiq8ojI0gXP/ik1Gpp95n7?=
 =?us-ascii?Q?Lj85H87bAvGFrlgDZc89i3Y4DZfgXiK/Rw7+JwmdRSjs9uOyeMBa5WDTDEtk?=
 =?us-ascii?Q?bmNubrwLTLcJMIJVI0RarOnHoMeXNGjr3HfC+CWm2gwBHWKkzZcbIthNnmD5?=
 =?us-ascii?Q?ItHFA4N8/fo6xxif3Pu25yb/GCKiPKViLsA+EZ0Stdp96ZNcfVKis90jxm2W?=
 =?us-ascii?Q?zQn32BkLC/B0Q73039h4ZsSZVxyMZjPlVWjqVZQVPo7yEFK42xUXifer9+oc?=
 =?us-ascii?Q?hXEcHQzoRRKoI76si91SHL08LhVuwvjEWSEQcOVIFs7KTNSJPGTyEWBfT/4d?=
 =?us-ascii?Q?JaKHcDDixqM8sztYdJoZ+XpAr2vPhNVTl859mEBDGWcQKscmkYlB2ImyfEh0?=
 =?us-ascii?Q?fGOswXvGM/Y16EjQpSUmLzzkTzZnfFko1G4MDjozUeOlxWBtge2909ZjErmo?=
 =?us-ascii?Q?fH+UnsSUCkFj9V+LS1U8GO58?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7eb75df6-8a18-458c-6c25-08d9826b0fee
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 10:30:59.0956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DNMPH2ULFyfy7U0X8U7Ejh63uGcfV0ivsQg5y5rQ4S/7f66sLvT+l98Qan4mFU3WM3+z/hbF3I+siQF4vx2Bfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5425
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10120 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 mlxscore=0
 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2109280061
X-Proofpoint-ORIG-GUID: eecbZ93vHmdzgL9sVYtqBanrXlJI8uYX
X-Proofpoint-GUID: eecbZ93vHmdzgL9sVYtqBanrXlJI8uYX
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Currently show_workqueue_state shows the state of all workqueues and of
all worker pools.
Divide it into more granular functions (__show_workqueue_state and
__show_worker_pool_state), that would show states of individual workqueues
and worker pools.

Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
---
 kernel/workqueue.c | 139 ++++++++++++++++++++++++++-------------------
 1 file changed, 79 insertions(+), 60 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 9a042a449002..cfae0c8d5e2e 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4796,6 +4796,81 @@ static void show_pwq(struct pool_workqueue *pwq)
 	}
 }
 
+/**
+ * __show_workqueue_state - dump state of specified workqueue
+ * @wq: workqueue whose state will be printed
+ */
+static void __show_workqueue_state(struct workqueue_struct *wq)
+{
+	struct pool_workqueue *pwq;
+	bool idle = true;
+	unsigned long flags;
+
+	for_each_pwq(pwq, wq) {
+		if (pwq->nr_active || !list_empty(&pwq->inactive_works)) {
+			idle = false;
+			break;
+		}
+	}
+	if (idle) /* Nothing to print for idle workqueue */
+		return;
+
+	pr_info("workqueue %s: flags=0x%x\n", wq->name, wq->flags);
+
+	for_each_pwq(pwq, wq) {
+		raw_spin_lock_irqsave(&pwq->pool->lock, flags);
+		if (pwq->nr_active || !list_empty(&pwq->inactive_works))
+			show_pwq(pwq);
+		raw_spin_unlock_irqrestore(&pwq->pool->lock, flags);
+		/*
+		 * We could be printing a lot from atomic context, e.g.
+		 * sysrq-t -> show_workqueue_state(). Avoid triggering
+		 * hard lockup.
+		 */
+		touch_nmi_watchdog();
+	}
+
+}
+
+/**
+ * __show_worker_pool_state - dump state of specified worker pool
+ * @pool: worker pool whose state will be printed
+ */
+static void __show_worker_pool_state(struct worker_pool *pool)
+{
+	struct worker *worker;
+	bool first = true;
+	unsigned long flags;
+
+	raw_spin_lock_irqsave(&pool->lock, flags);
+	if (pool->nr_workers == pool->nr_idle)
+		goto next_pool;
+
+	pr_info("pool %d:", pool->id);
+	pr_cont_pool_info(pool);
+	pr_cont(" hung=%us workers=%d",
+		jiffies_to_msecs(jiffies - pool->watchdog_ts) / 1000,
+		pool->nr_workers);
+	if (pool->manager)
+		pr_cont(" manager: %d",
+			task_pid_nr(pool->manager->task));
+	list_for_each_entry(worker, &pool->idle_list, entry) {
+		pr_cont(" %s%d", first ? "idle: " : "",
+			task_pid_nr(worker->task));
+		first = false;
+	}
+	pr_cont("\n");
+next_pool:
+	raw_spin_unlock_irqrestore(&pool->lock, flags);
+	/*
+	 * We could be printing a lot from atomic context, e.g.
+	 * sysrq-t -> show_workqueue_state(). Avoid triggering
+	 * hard lockup.
+	 */
+	touch_nmi_watchdog();
+
+}
+
 /**
  * show_workqueue_state - dump workqueue state
  *
@@ -4806,73 +4881,17 @@ void show_workqueue_state(void)
 {
 	struct workqueue_struct *wq;
 	struct worker_pool *pool;
-	unsigned long flags;
 	int pi;
 
 	rcu_read_lock();
 
 	pr_info("Showing busy workqueues and worker pools:\n");
 
-	list_for_each_entry_rcu(wq, &workqueues, list) {
-		struct pool_workqueue *pwq;
-		bool idle = true;
-
-		for_each_pwq(pwq, wq) {
-			if (pwq->nr_active || !list_empty(&pwq->inactive_works)) {
-				idle = false;
-				break;
-			}
-		}
-		if (idle)
-			continue;
-
-		pr_info("workqueue %s: flags=0x%x\n", wq->name, wq->flags);
-
-		for_each_pwq(pwq, wq) {
-			raw_spin_lock_irqsave(&pwq->pool->lock, flags);
-			if (pwq->nr_active || !list_empty(&pwq->inactive_works))
-				show_pwq(pwq);
-			raw_spin_unlock_irqrestore(&pwq->pool->lock, flags);
-			/*
-			 * We could be printing a lot from atomic context, e.g.
-			 * sysrq-t -> show_workqueue_state(). Avoid triggering
-			 * hard lockup.
-			 */
-			touch_nmi_watchdog();
-		}
-	}
-
-	for_each_pool(pool, pi) {
-		struct worker *worker;
-		bool first = true;
+	list_for_each_entry_rcu(wq, &workqueues, list)
+		__show_workqueue_state(wq);
 
-		raw_spin_lock_irqsave(&pool->lock, flags);
-		if (pool->nr_workers == pool->nr_idle)
-			goto next_pool;
-
-		pr_info("pool %d:", pool->id);
-		pr_cont_pool_info(pool);
-		pr_cont(" hung=%us workers=%d",
-			jiffies_to_msecs(jiffies - pool->watchdog_ts) / 1000,
-			pool->nr_workers);
-		if (pool->manager)
-			pr_cont(" manager: %d",
-				task_pid_nr(pool->manager->task));
-		list_for_each_entry(worker, &pool->idle_list, entry) {
-			pr_cont(" %s%d", first ? "idle: " : "",
-				task_pid_nr(worker->task));
-			first = false;
-		}
-		pr_cont("\n");
-	next_pool:
-		raw_spin_unlock_irqrestore(&pool->lock, flags);
-		/*
-		 * We could be printing a lot from atomic context, e.g.
-		 * sysrq-t -> show_workqueue_state(). Avoid triggering
-		 * hard lockup.
-		 */
-		touch_nmi_watchdog();
-	}
+	for_each_pool(pool, pi)
+		__show_worker_pool_state(pool);
 
 	rcu_read_unlock();
 }

base-commit: 64f28502801aad0cb4f97102b4b5a81df315c2aa
-- 
2.30.2