Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?utf-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
To:     Corentin Labbe <clabbe.montjoie@gmail.com>
Cc:     linusw@kernel.org, kaloz@openwrt.org, linux@armlinux.org.uk,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: intel-ixp42x-welltech-epbx100 no longer boot due to
 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel mapping regression")
References: <YVLD/UMRYA55WiGI@Red>
Sender: khalasa@piap.pl
Date:   Tue, 28 Sep 2021 12:32:13 +0200
In-Reply-To: <YVLD/UMRYA55WiGI@Red> (Corentin Labbe's message of "Tue, 28 Sep
        2021 09:27:57 +0200")
Message-ID: <m3r1d9ng7m.fsf@t19.piap.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Corentin,

Corentin Labbe <clabbe.montjoie@gmail.com> writes:

> I am working on puting my ixp4xx board on kernelCI.
> But it no longer boot since 4.14.
> It only prints "Starting kernelUncompressing Linux... done, booting the k=
ernel." then nothing.
>
> I bisected the break to 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel=
 mapping regression")

I guess you build your kernel as big-endian.

These parts seem suspicious to me:

-    str r8, [r5]            @ Save physical start of kernel
+#ifdef CONFIG_CPU_ENDIAN_BE8
+    str r8, [r5, #4]            @ Save physical start of kernel (BE)
+#else
+    str r8, [r5]            @ Save physical start of kernel (LE)
+#endif

and

-    str r3, [r5]            @ Save physical end of kernel
+#ifdef CONFIG_CPU_ENDIAN_BE8
+    str r3, [r5, #4]            @ Save physical end of kernel (BE)
+#else
+    str r3, [r5]            @ Save physical end of kernel (LE)
+#endif

IXP4xx, being ARMv5, uses CONFIG_CPU_ENDIAN_BE32 (when configured as
BE), but it needs the ", #4" as well.

I'd test with: #if defined CONFIG_CPU_ENDIAN_BE8 || defined CONFIG_CPU_ENDI=
AN_BE32
--
Krzysztof "Chris" Ha=C5=82asa

Sie=C4=87 Badawcza =C5=81ukasiewicz
Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP
Al. Jerozolimskie 202, 02-486 Warszawa