Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 13:39:08 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     Yanfei Xu <yanfei.xu@windriver.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, kuba@kernel.org, p.zabel@pengutronix.de,
        syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Dongliang Mu <mudongliangabcd@gmail.com>
Subject: Re: [PATCH] net: mdiobus: Fix memory leak in __mdiobus_register
Message-ID: <20210928103908.GJ2048@kadam>
References: <20210926045313.2267655-1-yanfei.xu@windriver.com>
 <20210928085549.GA6559@kili>
 <20210928092657.GI2048@kadam>
 <6f90fa0f-6d3b-0ca7-e894-eb971b3b69fa@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6f90fa0f-6d3b-0ca7-e894-eb971b3b69fa@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T+EDxo0kn+lvgIGYlhLF05ccAv15q9c4HviTgo4GWemto1A+0igVbFNBu+H8?=
 =?us-ascii?Q?E1iCV7Y2UL9J83gbil/DWsrkeQYnp0fPu/jlcj+UIOs95HrxuDxCAZkzt+/J?=
 =?us-ascii?Q?w1rdrmRUbWuWyVJBPI8CQui8vqyEANjJibFP5aDIxsj/X/FB1ByUkwdu+lnS?=
 =?us-ascii?Q?V1avhzvfex0DGz1UEaRtZevvhcolvGbR1ZHqzv8wV53BTihNxxX2J+OVORBq?=
 =?us-ascii?Q?I9CVqpor01LvUq9Tg86wL608FL59Qz/n9Hrl76eG+cAy82I7QZWM0DU2N6kP?=
 =?us-ascii?Q?aKe1+3frv4QducrY2/D8eMxH+Ro/KxPOSCtoYx1vrGlCrtSTO17tRP1WFGoK?=
 =?us-ascii?Q?hmFBLTEbMkMNJHsVMJow9Cy3FCCKTNySS1PRXcFUbh+kusoo/5oKHH+0W6Jj?=
 =?us-ascii?Q?A+MM73FnYZAT/T6AbeG6nm+do/w13gnjp+SGDLCIJ4olCPMjXHfxAPHt4XKG?=
 =?us-ascii?Q?diYN2jIW2idNe0HyRXW0zj2d0nfzUR7rFaoruU7tbPk8dPRSc28MFT98/z8k?=
 =?us-ascii?Q?0qdfBQCwr+G6EcP+W5EDE0X20p6/i++VRKbptZ+teeLWgc0rrw2YyERlbXkb?=
 =?us-ascii?Q?EGxJUkjh5SG4Omjyvkg+Y+L5LUH4ekV82RaqOiy5FfqSOb6QGSmGjNq575Tq?=
 =?us-ascii?Q?GUQZw11+JMI+OO2J65PPGTbX+7G3vhQII5KqAeKx0v5LnP5c7JT3+FxqYr/B?=
 =?us-ascii?Q?omPlbPSDBvx2sdEulrPUAMeVa76UFhZ8Er3sah+Du+e3jaHFe6+1wtauHbI1?=
 =?us-ascii?Q?SvUTm5iRAsjhap9HbfE3JMx55Ki5qXnn42Kz0rT5tTCuKCnYulTAMKpDnkba?=
 =?us-ascii?Q?254RG/rmYdYW6H6sgFzkgcFybhj5NDZQ5L2i8BsKLqhloAc/BWaBDg08BuBr?=
 =?us-ascii?Q?rQJhXQHi+tluIhVyRqTLGxJ00LZXmpjIvbQfsxAOrcbKi/IsgoExL9hXUKQB?=
 =?us-ascii?Q?cOLX9UdhXgJzUyX/Eg2NmeMdnlMNpHJUhYnLn/eh1T6YzGU4pUO+ETYPXv+v?=
 =?us-ascii?Q?LSHDCR37/h2Oo0mSvQVqGygdeOlbCGBZne6biRYovbtrAsNhqcHYmox9RLCm?=
 =?us-ascii?Q?tDacSdoqn8OlkvK54O9YKvs7y6fTrZsTKougKJ5HLzUPrEzvJxDROjPVgl0R?=
 =?us-ascii?Q?mDhV4tlyKRpMlRLzCZ9ikerIVYeFryt46J7gjmrkH62GpUSHD/rjoEdGffLl?=
 =?us-ascii?Q?RQUtZ7kF3248SoKCocPbufH2aZZ5Yhmf9ST0nsRlItKiYsLEQdEmp75tOyVJ?=
 =?us-ascii?Q?n3evH5w3+cPWnykxAKqgs7FlJVBZKZ7ECbU6uIOoRZ52dTkoud1Sw2o1K39P?=
 =?us-ascii?Q?3EXK4YxX9Tqtkj1ETRu9LnQ+?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13a95f5c-44a7-49a1-d194-08d9826c3f67
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 10:39:28.5680
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xTqn923AnCciKkAcaA5otQoMEwSBnACF50R5+48PQ4B2nUukwh2Qg/K4XLoA3yZUw7jBpQNigaQiFARxGoAfRRJO99FH80wTvK5QbsxZlTA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1423
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10120 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 mlxscore=0
 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2109280061
X-Proofpoint-GUID: -sI-vAOcKarMU_Z_TaDJnwO2nMgvxZXP
X-Proofpoint-ORIG-GUID: -sI-vAOcKarMU_Z_TaDJnwO2nMgvxZXP
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

No, the syzbot link was correct.

You gave me that link again but I think you must be complaining about
a different bug which involves mdiobus_free().  Your bug is something
like this:

drivers/staging/netlogic/xlr_net.c
   838          err = mdiobus_register(priv->mii_bus);
   839          if (err) {
   840                  mdiobus_free(priv->mii_bus);

This error path will leak.

   841                  pr_err("mdio bus registration failed\n");
   842                  return err;
   843          }

Your patch is more complicated than necessary...  Just do:

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index ee8313a4ac71..c380a30a77bc 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -538,6 +538,7 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
 	bus->dev.groups = NULL;
 	dev_set_name(&bus->dev, "%s", bus->id);
 
+	bus->state = MDIOBUS_UNREGISTERED;
 	err = device_register(&bus->dev);
 	if (err) {
 		pr_err("mii_bus %s failed to register\n", bus->id);


regards,
dan carpenter