Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Wong Vee Khee <vee.khee.wong@linux.intel.com>
CC:     Andrew Lunn <andrew@lunn.ch>, Jose Abreu <Jose.Abreu@synopsys.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Wong Vee Khee <veekhee@gmail.com>
Subject: Re: [PATCH net-next 2/2] net: pcs: xpcs: fix incorrect CL37 AN
 sequence
Thread-Topic: [PATCH net-next 2/2] net: pcs: xpcs: fix incorrect CL37 AN
 sequence
Thread-Index: AQHXtB86VIvr3ExuHU+3raGaTBurpKu5Qm0A
Date:   Tue, 28 Sep 2021 10:41:04 +0000
Message-ID: <20210928104104.etfxxaeuwk2has32@skbuf>
References: <20210928041938.3936497-1-vee.khee.wong@linux.intel.com>
 <20210928041938.3936497-3-vee.khee.wong@linux.intel.com>
In-Reply-To: <20210928041938.3936497-3-vee.khee.wong@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/k8SyQFbsGgX2NtMXPOUafcdXSyn+ySqt7jJk8akv+qId2L/vVjNx7Cxxz+J?=
 =?us-ascii?Q?JEBhFIccc0h4DR3RUrVRoHbyYiqhj4OlDLwmrVo5qMZMsbpMbx7nnGZyJ+gv?=
 =?us-ascii?Q?OLgmdMaF8I1YhJlF2q/dJJZVk5AoNscEf2Dpmkv2XezneGzfBKpeiJsa1ykj?=
 =?us-ascii?Q?u73D3BDDcZhrhSn0SPgKGMLcf1h/R+USFWd1nl9Ciw/WRMQSbcee6+9kYhMQ?=
 =?us-ascii?Q?A6aPZWGKOfAITKbMpgQW+mkFDLcFf2CgwMQSgaeeiHM982a2zSSeXApTEn36?=
 =?us-ascii?Q?r0Q1SWww/B1i6vT6hUJy768YZdJI/Y1VLwqQuV5F5PyPR7vcdTUNHfXDO7B1?=
 =?us-ascii?Q?Ar/sGPavM4Dw9czgtGwhkqGapeqADI8QysayfOjulTLagTbNgMAqiMhI2p+h?=
 =?us-ascii?Q?AhgLKD2QZseJG2KnH8BNfr9tD0ZsC6qH3UxYOBqbPTmcY9iVubZYebAClcmE?=
 =?us-ascii?Q?EJQlRZfWhfnfgf4dGJt8FToEDNb9rlRcVRq3gYEiSHpZ6GYnw/HmVVF2Nkpt?=
 =?us-ascii?Q?iCsdZ4I+RdslhuJsxhSUtrilI7M27uElzsN7gQJtn7vqnXwo3w3N15zyVwQF?=
 =?us-ascii?Q?sAIK6ALY5gp4Xo/ARa0N/DLOzqNT1+1OA4ZJQnDPc218OMg302PJFsCDfy8m?=
 =?us-ascii?Q?yXxVg1chf90/IAH+3PL03tw5Lnba+lSacZLwiidHL6UDc+/uYZUPjj5tBD5/?=
 =?us-ascii?Q?hJsYeoqzFjoBV+nWDP9VHNGQO8mrReU66llACg7IwZQy6RU5X5WIjdT8pGJ1?=
 =?us-ascii?Q?fQwBtvChgqxCUZiV0HZUQIiiOzOvbohC72Nx3iLI8Y9gm83u5QVHbbk9GY99?=
 =?us-ascii?Q?KOXsA8nNvTzV9xZbV/3oxpsmsMRyJICdZQ0nxLmOldhPb+UuVNhQVHH6DbD/?=
 =?us-ascii?Q?ShVPwV7xeg1aLUkeneNvMxt6N23f/7DH4Xc2Y8YDDjvwGApCovtpJSO1shxM?=
 =?us-ascii?Q?QHJZpuciyQz0l7iJ4mHZzTaTn8Kr6h9gIhNVS31cD0iLdpZeEFg6qYYVHP1P?=
 =?us-ascii?Q?rv5kkqYsmqfrqHLm90hj5uZUXmjHsX5xK2HXNfSk0ytx9zS1TUqTF9SdARj2?=
 =?us-ascii?Q?C7EPbpXjqX6GyehxzYrr2QFLSCWxQbIPEEGzkuOJrBqxNiDBY/cDhvg7sjTN?=
 =?us-ascii?Q?5wHHBCG+56I/lhlf1mZqry6iawa5wtR4pUDCFzj1PieebXPMQzOZUDy7fEYJ?=
 =?us-ascii?Q?+0OXYw+fSugcoPrES5mMOdvlMZR7ifvlOsyeoz0a87H18ESRDmjQsZa9uEUD?=
 =?us-ascii?Q?cdZZno8LuJf/6ClSjm8NTypWb4MrsKsAKqA/h9hux5wwiM0GVX2WKq1x8lng?=
 =?us-ascii?Q?qkk0qDFZNytgMC+ONIm6QI3U+KB3InItmmc7BB2ohJcwIg=3D=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A17DAE00EE4EF1439964612DB27075FA@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d362f354-6b42-4ed6-6999-08d9826c792b
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2021 10:41:04.9433
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: C5Fn3jz5L71O1B6j4UmN8iIxOftqtB4Fx9yogjGvF+DmG1B/00CnpRNnGlOA5Lk2K0f2kwZmdenJwxFi+MOamA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5136
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 28, 2021 at 12:19:38PM +0800, Wong Vee Khee wrote:
> According to Synopsys DesignWare Cores Ethernet PCS databook, it is
> required to disable Clause 37 auto-negotiation by programming bit-12
> (AN_ENABLE) to 0 if it is already enabled, before programming various
> fields of VR_MII_AN_CTRL registers.
>=20
> After all these programming are done, it is then required to enable
> Clause 37 auto-negotiation by programming bit-12 (AN_ENABLE) to 1.
>=20
> Cc: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
> ---

Other comments:

- please provide a Fixes: tag, like:

Fixes: b97b5331b8ab ("net: pcs: add C37 SGMII AN support for intel mGbE con=
troller")

(just like that, not split on multiple lines)

- please target the patches to the "net" tree. I see the xpcs_modify
  patch has other stuff in its context (nxp_sja1105) that will conflict
  with the tree in which the bad commit was originally introduced, so I
  think the easiest way would be if you could just open-code the initial
  clearing of bit MDIO_AN_CTRL1_ENABLE. You could then wait until "net"
  merges with "net-next" again and do the other cleanups afterwards - it
  looks like other places could use a _modify method as well, just
  looking at DW_VR_MII_AN_CTRL, DW_VR_MII_DIG_CTRL1. Also, the complete
  replacement of DW_VR_MII_MMD_CTRL with MDIO_CTRL1 can also be done in
  net-next. Just try to keep the fix minimally self-contained.=