Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <63b18426-c39e-d898-08fb-8bfd05b7be9e@gmail.com>
Date:   Tue, 28 Sep 2021 13:46:56 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH] net: mdiobus: Fix memory leak in __mdiobus_register
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Yanfei Xu <yanfei.xu@windriver.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, kuba@kernel.org, p.zabel@pengutronix.de,
        syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Dongliang Mu <mudongliangabcd@gmail.com>
References: <20210926045313.2267655-1-yanfei.xu@windriver.com>
 <20210928085549.GA6559@kili> <20210928092657.GI2048@kadam>
 <6f90fa0f-6d3b-0ca7-e894-eb971b3b69fa@gmail.com>
 <20210928103908.GJ2048@kadam>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <20210928103908.GJ2048@kadam>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/28/21 13:39, Dan Carpenter wrote:
> No, the syzbot link was correct.
> 

Link is correct, but Yanfei's patch does not fix this bug. Syzbot 
reported leak, that you described below, not the Yanfei one.

> You gave me that link again but I think you must be complaining about
> a different bug which involves mdiobus_free().  Your bug is something
> like this:
> 
> drivers/staging/netlogic/xlr_net.c
>     838          err = mdiobus_register(priv->mii_bus);
>     839          if (err) {
>     840                  mdiobus_free(priv->mii_bus);
> 
> This error path will leak.
> 
>     841                  pr_err("mdio bus registration failed\n");
>     842                  return err;
>     843          }
> 
> Your patch is more complicated than necessary...  Just do:
> 
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index ee8313a4ac71..c380a30a77bc 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -538,6 +538,7 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
>   	bus->dev.groups = NULL;
>   	dev_set_name(&bus->dev, "%s", bus->id);
>   
> +	bus->state = MDIOBUS_UNREGISTERED;
>   	err = device_register(&bus->dev);
>   	if (err) {
>   		pr_err("mii_bus %s failed to register\n", bus->id);
> 
> 
yep, it's the same as mine, but I thought, that MDIOBUS_UNREGISTERED is 
not correct name for this state :) Anyway, thank you for suggestion


With regards,
Pavel Skripkin