Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 13:55:22 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     Yanfei Xu <yanfei.xu@windriver.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, kuba@kernel.org, p.zabel@pengutronix.de,
        syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Dongliang Mu <mudongliangabcd@gmail.com>
Subject: Re: [PATCH] net: mdiobus: Fix memory leak in __mdiobus_register
Message-ID: <20210928105522.GK2083@kadam>
References: <20210926045313.2267655-1-yanfei.xu@windriver.com>
 <20210928085549.GA6559@kili>
 <20210928092657.GI2048@kadam>
 <6f90fa0f-6d3b-0ca7-e894-eb971b3b69fa@gmail.com>
 <20210928103908.GJ2048@kadam>
 <63b18426-c39e-d898-08fb-8bfd05b7be9e@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <63b18426-c39e-d898-08fb-8bfd05b7be9e@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Cb4PunW/tojL34HbiethJgg6BeS8VrAc6IhOcZezo6KKYwFEczJSdSjwz+YC?=
 =?us-ascii?Q?DwX7glGTi+m/1/E7ziZZHpSe+dZWrkM4ZH/dEYA+bE0LZAaPX+FZauC8qq27?=
 =?us-ascii?Q?ayc6gI3gt6kxC0cHoYUhuim1U+Z4S4QfHo8E/dVOk3Jx/v5fIDfcGWipYNzr?=
 =?us-ascii?Q?3oDhn4RW7SSSddS9+q9wm9tY6w6kT5kwfBYyGraAxnwHciXaX/e4Y7W5lmuq?=
 =?us-ascii?Q?srqdV3ghFcGDZS1zcVJAbUzm9y82waXj6J/OgyVvTmwr0TO/qTK7fZW2x3UH?=
 =?us-ascii?Q?1WaGbDcHTG/O5TY7Wqi4OOjPovH/izYnkh2fCLeAELTu+TEE5Y681FbbYXIn?=
 =?us-ascii?Q?sA8RrRtNuIjwuutDzzq9WrjE0Opost++Y9OAUYpcPnzdKU4Sr/lnscAG7XPR?=
 =?us-ascii?Q?W28dil28KQ1Gsx/u2+FvqLeA/yf4PAIVOSPXXzcGedG3TTlPlG80kfN5pVr/?=
 =?us-ascii?Q?blV08IYtlYLZK0lU7Va1phm0Wj0JRDCcXL3pNk9Te4t5TcUNDRZycs+s+OD0?=
 =?us-ascii?Q?hDFnhfzsI+59bUeSH7mUjjKATPR/6FZbIQHU46B1G3I0UxHUNl/BxLyhqLJZ?=
 =?us-ascii?Q?yjquOmEWt4tyXQ5jgl8/I0Nx7k2AOy4dSPmcUXVbM6iG47PkpozvvUbWgL6F?=
 =?us-ascii?Q?Ob+2+IzW7IY/Ht01O0plQ0sF1U0Ug2ru+X53ZjOlkUJ8g/mO/pD4w91sUfIu?=
 =?us-ascii?Q?5tjtVI3sy1mwyjFtp/1QfKRfZJ/7iT0BQVQx93mi8KFIbOvGzXELV2Dy9e9K?=
 =?us-ascii?Q?TkSR0cK55y5i0qdfFtGWSqGX9qJVe6CHrMzlXzDizufRrRqmLRfIWgaXcLes?=
 =?us-ascii?Q?YzmnK1/pur6I9msy7Y2l21kunuoDkORjEohrk7AwZeJUQCWgFS/JqgF2GfaD?=
 =?us-ascii?Q?yss80X203jN6y6gVarPmVU+cMsSP6vnAUa08hfWekczGwoKFSAshpPitPAwh?=
 =?us-ascii?Q?taGlnVdbH1Y/iK1qsE/iNnMc1ifqlr5xRyOCD72pZG+WFNcHopdWZysgPi0E?=
 =?us-ascii?Q?n/8pnLaMurwh10z1H1/SKKCgtIE0Qam1orYtxrXE2p7uxE6S8KLoID3bD2wI?=
 =?us-ascii?Q?GjAig5mBxk0oYHMhBwI1g1b/z2BXrWcsXK57OfPTS+WHb6XkeDD+dySUeG+D?=
 =?us-ascii?Q?5e3Y32oQLBUSI2CW4uGcLk0tegY2JgBJwZazyB9lCJGjtu6SeubgWeCYkwzG?=
 =?us-ascii?Q?OJnILfHkV8h5pvCrDVfzhZyyVVlO+Hnr3nNrXwMSbck/rEuIQK4bRhCZYhMX?=
 =?us-ascii?Q?lpjkjq8tGZlhzDCyYcYPMp8NxSnpGggfWctlzMyQCnWLpMIWVy2fsLhw5J+D?=
 =?us-ascii?Q?gKFuSdRWclKa5Zp+nEm+xiZI?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed6582af-7761-4889-106a-08d9826e8285
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 10:55:39.9386
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OwIcY9059Wd5V8UkxuZvanELBgJ++8F/LoujFdRiCN888XkYzcUfPB0YMTe1kXU7yJkR5+ginXMVb385T2xJtGROpZr62VS7XmS+winKdDk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5459
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10120 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0
 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 mlxscore=0
 mlxlogscore=854 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2109280061
X-Proofpoint-ORIG-GUID: 8ibkMS8gXB7EKvf1eN7RvAOwPNXFz2FG
X-Proofpoint-GUID: 8ibkMS8gXB7EKvf1eN7RvAOwPNXFz2FG
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 28, 2021 at 01:46:56PM +0300, Pavel Skripkin wrote:
> On 9/28/21 13:39, Dan Carpenter wrote:
> > No, the syzbot link was correct.
> > 
> 
> Link is correct, but Yanfei's patch does not fix this bug. Syzbot reported
> leak, that you described below, not the Yanfei one.
> 

I promise you that Yanfei's link was correct.  That bug was in
__devm_mdiobus_register().  It's a totally separate issue.

regards,
dan carpenter