Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 13:59:43 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     Yanfei Xu <yanfei.xu@windriver.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, kuba@kernel.org, p.zabel@pengutronix.de,
        syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Dongliang Mu <mudongliangabcd@gmail.com>
Subject: Re: [PATCH] net: mdiobus: Fix memory leak in __mdiobus_register
Message-ID: <20210928105943.GL2083@kadam>
References: <20210926045313.2267655-1-yanfei.xu@windriver.com>
 <20210928085549.GA6559@kili>
 <20210928092657.GI2048@kadam>
 <6f90fa0f-6d3b-0ca7-e894-eb971b3b69fa@gmail.com>
 <20210928103908.GJ2048@kadam>
 <63b18426-c39e-d898-08fb-8bfd05b7be9e@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <63b18426-c39e-d898-08fb-8bfd05b7be9e@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OQHKVkWfjZSAzE38qLB58etAEoXHHztpsri6xGVChB714y9WJF5pvQaV6Ond?=
 =?us-ascii?Q?ekwx/7QAGk9Wi4Lj3Y0uhzdOpTjDI3bSUGSUgmm7pyYToCPR/KiXEObxsph7?=
 =?us-ascii?Q?WwVN74sRiTwFw3vS3OCEwmiR1euAb3Npoiy67R5DzeoZQnq9l002toIPdwkd?=
 =?us-ascii?Q?Fi91QczbKCNJLweTnPXQLHv5mpmNT3EOIIC3nt91rI145mSnb4baxor1M35v?=
 =?us-ascii?Q?ZaJmbee321bYR4Md9kvTPnk052PdcmfPVCDGR+qCYAeIai5uHzT9L6F1b3K+?=
 =?us-ascii?Q?nhfTvJU68a1+kRC/IjnUK7Q2gIFy1HLtnCZ6kPcLWHBkIdnkFaUNibO/HfnQ?=
 =?us-ascii?Q?ATmD22DFRDZSKWGGC9jtvWCydENW1iDMjq6N/xQJI9n/2+eSP+PEMPWnfFlr?=
 =?us-ascii?Q?aRDx5U8/HNK6e2xzb8IPqzMtQ7LRIOD4sGk5SfDwmwitGd+YgM7GDcc4Hg/b?=
 =?us-ascii?Q?uo0+78LE8S7VkzwfmkyBNL24PhSwIPo/y4ofTDqO2XCCxMSD5vDFtvoGSUTf?=
 =?us-ascii?Q?dqGp8+Y81qtxh6EixVSUStPsaxcF2GT29Pt29W5+oS1xE6JwxtT/hujuLuii?=
 =?us-ascii?Q?EsawqT3PX25KJcUNskaR1SzPzjl6HlHCUcjtltjXvL7QG6br4ivwL6UdeEyA?=
 =?us-ascii?Q?kd1UuZhhd5sucajCrrWyzDbISZ9wxgeUzdgzqeWxUBtED8XreLmy8Qhr084+?=
 =?us-ascii?Q?/zx10A05z3uuQtifUGokDYsy2GZt38S9MJQd5TXGeMih3bcI30xUUCxXBKKS?=
 =?us-ascii?Q?P48Eoaf/Oz3gZK/+D9Q8PDRrIMOOP2S1sEtPX4JCy/139kuzBD8YiFTbHk3c?=
 =?us-ascii?Q?5AGMmi19cuqA9X46d2gj4dJqkeDOmhmRKAsJqz4o42jBWHJCY4i7tl+/f8xJ?=
 =?us-ascii?Q?gWfqMfqZpUW2d4vBU0uCeHXoxofbymLH9qt4YNXOSm41R8Nid/fBHYUZnphP?=
 =?us-ascii?Q?JzYTkmEYgY2Cb39oB5AuqJ8Hx7kbioDIHT2WMul3Rtds5kAwuTNd/bS0o0YD?=
 =?us-ascii?Q?Smqr1fZv6t1UDpk35/7ZcDqK0DtGSI4Cuxf7RQdICfTTdRpAqNZWtp/rlXlK?=
 =?us-ascii?Q?v9XmQuSoDs5sFU+QaydzdCu+qJYu5HGn84C6c0w1tgLq8JjrVkEU2KnKeiMa?=
 =?us-ascii?Q?9wC7rdBDarzOlNT1Oe7BJURom4D0yJdTGaWeS33eY6JRiWa/zbgsiDdAvQ6T?=
 =?us-ascii?Q?+VDfLwH0uUfPatNLLUWa2vnYtlmf0CLqo/bewGg2/ISZPZ1JKYLdDV0vkSgk?=
 =?us-ascii?Q?30q7ukt9RpK6G50BHVyRixsHz5Alh5LqzLLZ3IXCCG1G6OuCIHVFcItD60IP?=
 =?us-ascii?Q?r4sNqWuwQYAkLyVghzfBTeIQ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efeacbaf-e016-4045-753d-08d9826f1f5c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 11:00:03.0808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: obMXVtY36rA/+zJwBoM2VPd/GSf1slU4wYJU+6+Z9MSLlzofKhfluVUtGlX6o0w78DD6T1pyKwWkjkQQojdxdLW1nfKMu8PRCdHTDojpfR8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1614
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10120 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 mlxscore=0
 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2109280062
X-Proofpoint-ORIG-GUID: cbojNGj9a7ysSJaX17VGpctVAUZuIMtY
X-Proofpoint-GUID: cbojNGj9a7ysSJaX17VGpctVAUZuIMtY
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 28, 2021 at 01:46:56PM +0300, Pavel Skripkin wrote:
> > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> > index ee8313a4ac71..c380a30a77bc 100644
> > --- a/drivers/net/phy/mdio_bus.c
> > +++ b/drivers/net/phy/mdio_bus.c
> > @@ -538,6 +538,7 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
> >   	bus->dev.groups = NULL;
> >   	dev_set_name(&bus->dev, "%s", bus->id);
> > +	bus->state = MDIOBUS_UNREGISTERED;
> >   	err = device_register(&bus->dev);
> >   	if (err) {
> >   		pr_err("mii_bus %s failed to register\n", bus->id);
> > 
> > 
> yep, it's the same as mine, but I thought, that MDIOBUS_UNREGISTERED is not
> correct name for this state :) Anyway, thank you for suggestion
> 

It's not actually the same.  The state has to be set before the
device_register() or there is still a leak.

regards,
dan carpenter