Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4780974pxb; Tue, 28 Sep 2021 04:05:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHgY5yMW3i33Qh7eT4c7BHhlv0UN+w379LgyjZ6U7mC3mQVrC5th6E2gbQ2KQ0Ll2Cj89X X-Received: by 2002:a17:907:82a3:: with SMTP id mr35mr5968002ejc.52.1632827121303; Tue, 28 Sep 2021 04:05:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632827121; cv=none; d=google.com; s=arc-20160816; b=oKi15UdTY/xlPYNle9KEB2DB1Dj+Nv1oH/O/okc4ghHYy7+CJ3k1l0mmkXC7Bpleyj u3bqWL5TzzxbHxl+rNkGQ7O0uuB24pFHMJ6eB0ZRy13EDrbCAVuJ1GfeRHT2GfmiXS5R e9zSK2kYMijNPKf463AxGO2tb+MywmgtbUdv+wkR4xPgStQ9UBYYyEaedItZkX8n9gNQ 1YKBwp72oolIvMH6sTHhPqEONzitbOi3FxBbjpo/Lyz11v48xnTaHzqAqur+N8I3vrSL HFIT5HgxZimP16ecqpSTIwZOGYDyr1xh/fa4JcFsE/x/IBuuvTrHmUhlZrWYkdtaSJk6 siWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bDMDauvv55wu/+IoWaGnB8OOo2W44A6CNUto0VNzDvE=; b=WM9YkLS3U2wwcG5FKuk8A3+4BcVkUq98APU0v+983Dn+Xa3mcSTbQFfAWfjUv8W6Py qj4TryLKAJMJVxnBRKYrWqfWW4PeJsHo1MtbZXGvo9G84gTUXUBd3VKgYsCMEknFpi1k hug975A7tcH3wNfEJH0CVqPy/t/+0BlDV5yGu6fF58aPEwDgMYaAdtyJLW783cXf2Krg iud7O77o1F7zIP9tWol0hbcDT2McettqBR6bmat51IE57uXB+uKGlxvG2ZR0gzobKDeg n6tEJ4uh/dxAUX+NwDkisJIeO3RcSu4TRVun8m/ag/63dwrSH3m2iMnif5YXpD61X9un Qvfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s5UfLHld; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ky10si22567858ejc.214.2021.09.28.04.04.55; Tue, 28 Sep 2021 04:05:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=s5UfLHld; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240298AbhI1LDX (ORCPT + 99 others); Tue, 28 Sep 2021 07:03:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:57090 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240238AbhI1LDW (ORCPT ); Tue, 28 Sep 2021 07:03:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9EE476108F; Tue, 28 Sep 2021 11:01:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632826903; bh=4elokg0o9FH5+5sHoV+DUogyPycs4wXHfkpt86cNSUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s5UfLHldW5pMxfvjMDqb2cc03GF+hikMXPc9WstlfWt2CclOBSFd9Clp61OC/kE8M IfrCo8rmlIfWZBc37ND0v4pKb3+1H6+9quC6YUU8p1EmIBv1R4lqw3IbUBORvs3f5T WZm746V0PdiAyaB3GO49VNjXOELsRsvulnchZwvP6K7H7IY52woWEhiIJKsOBIW5mF x2Gx7CWToHGAuNZGIGhjFxgcoAtoyyKiL7FD6HUPqbHQZFrcDY+kgZEnMAXzyAf1Pc wAWtt7yldFIBXqLdCDYSA66KV3chOYX4jzWutV7aiXF+yW+6qEnjvhVgKrNjvEIomy Wq2PL66XVz6lg== Date: Tue, 28 Sep 2021 13:01:37 +0200 From: Jessica Yu To: Arnd Bergmann Cc: Luis Chamberlain , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Miroslav Benes , Greg Kroah-Hartman , Kees Cook , Sergey Shtylyov , Sami Tolvanen , Stephen Boyd , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] module: fix clang CFI with MODULE_UNLOAD=n Message-ID: References: <20210927121541.939745-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210927121541.939745-1-arnd@kernel.org> X-OS: Linux p200300cbcf144d003adeadfffec0265a.dip0.t-ipconnect.de 5.13.8-1-default x86_64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Arnd Bergmann [27/09/21 14:15 +0200]: >From: Arnd Bergmann > >When CONFIG_MODULE_UNLOAD is disabled, the module->exit member >is not defined, causing a build failure: > >kernel/module.c:4493:8: error: no member named 'exit' in 'struct module' > mod->exit = *exit; > >add an #ifdef block around this. > >Fixes: cf68fffb66d6 ("add support for Clang CFI") >Signed-off-by: Arnd Bergmann Applied, thanks everyone! Jessica