Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4789691pxb; Tue, 28 Sep 2021 04:16:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6LAu9uFgh8uoTRoop2QCPgULSpYWU1q23+pVqYQDMRtHXZYwu8GG16to1XR1DPNCJ5Fin X-Received: by 2002:a50:e08c:: with SMTP id f12mr6869943edl.178.1632827803217; Tue, 28 Sep 2021 04:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632827803; cv=none; d=google.com; s=arc-20160816; b=hksQxsMVRRgjS/BZLHGhGvOmLeekv3zpvYjtEA7eVZVqT85Bz5OtB/9M0gX3AQUj5Z CV2HRiKXvpsIB5Id3/weEWhisj4MrnHRpAJBM2qG/NB74TdZ3sDvY9bBt7OxVWzl4qLh +TeMQ5X1guu76g2Zm8MwKLVDBbhSqoBUzFCZlbig6XZL6QXdmqccC/ZqfnvJvo+OqURn nr7CU1krUEedeSfBcUrs7X1NNHVCeUhCan30GZUITeey/zZlHWNGzRKVJhpL9Q6Uzux5 rfbj8pOXwdXbzWRyb0w8qg3Rr3cQIPgrE07czMhiz+duqRbansRXYJ65aBEvFvu9Uxry UGjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ZU+KVR0y2VTh3ZrdA51D/L+4k30fXIYJ6SUmvuXTBtU=; b=xeKsA5T7dHjLS94yKArKr2UlaGIWYrZK9MucR7O0LByN7wX1S5zmGIlQlRWfMJS+1I YQHqkDqEDlPn9iV5o2JxyD+nhXA68HFqfZHbcFmKHiKNMbsabWotJOxwJfRcdGcPDgrQ 36jJElimA65+OAhKv2jfWwRZaY2nacNO380Z4oyBejGjQhIulPDw1x+ucQGH5j+vc0MO G5GqmmTObqC7EUTxqQQpHfqbfihbg3qo0OUQJsq8tUtX8HMvtNNBbdfyign0DtMYFZKq D0QUHYOimPIzb+WoBP8kkIgKANUgatNC9iaDdXfAn5mlvfwjtBmUA00/cKp6ceBsKaC0 8UbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FcaykwPZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t23si14307808ejs.606.2021.09.28.04.16.18; Tue, 28 Sep 2021 04:16:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FcaykwPZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240170AbhI1LQ1 (ORCPT + 99 others); Tue, 28 Sep 2021 07:16:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46587 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239068AbhI1LQX (ORCPT ); Tue, 28 Sep 2021 07:16:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632827683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZU+KVR0y2VTh3ZrdA51D/L+4k30fXIYJ6SUmvuXTBtU=; b=FcaykwPZNo92lJaeTP35evk3+6CY2OWeLx9VgdynD2AtD02wBD0bUUoBS04RUL5NF/yVj7 3tkwCFGF4m1kHFCQ5r0QI2wxMySb7N6ZN+bOlZUDVKBS3RZhFiCHaKR57sq+iEYmyXyY73 W5qcMIG4wtzQbjVGEzPs49ZOmZ/C7KU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-aBfOszqWPgKOPSVN4waDGw-1; Tue, 28 Sep 2021 07:14:42 -0400 X-MC-Unique: aBfOszqWPgKOPSVN4waDGw-1 Received: by mail-wm1-f72.google.com with SMTP id j82-20020a1c2355000000b0030cec9c9a66so1848835wmj.0 for ; Tue, 28 Sep 2021 04:14:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZU+KVR0y2VTh3ZrdA51D/L+4k30fXIYJ6SUmvuXTBtU=; b=4axxNTdElP1uTq7kQNPBcTJWbS0U6DfH25WKXObSExsttPVmrgSW0JYIimhugpJi2Z OO4E6/+Swa9W485FMuzOcGEnqeQdCqDsSsRGhYHwsdZrox+0HmnmyowcQzTEyRHmeVaj ceNQFvxrkRajiOF0FkXOzZgQgQYzzEPH5cDKougTDJRlmMlfKBXGIcvgAOgPU24KhnQ0 1P6q3AMmp1D9PKyLlDqeik6T1eWf2nyzFKTbSlyuYHoMdXqNGhxSf7ehGP7h0lLTJ514 sUPXs0kq1YoIjo31wterHUMyTRGZgcntWmEl7UguBklnX0ytAMZPszBjwK2+ArQGCR7d ZDTg== X-Gm-Message-State: AOAM531bgc8W5axwGm92rdxAUuVs6mwZdU6Xvq+2bW4nKnsSuWBPop4+ aVuO7jcyzYaqfrOJc7PaubAPCHeLfPlyQBrznZXU/doN20bDT+YaO1RgX7r4J9juHY3CX1YfUsp EyHts5o43ccIzx7zgH+tplZMnmxY8oErQoKvKrm01 X-Received: by 2002:a7b:c1d6:: with SMTP id a22mr4054953wmj.146.1632827681479; Tue, 28 Sep 2021 04:14:41 -0700 (PDT) X-Received: by 2002:a7b:c1d6:: with SMTP id a22mr4054944wmj.146.1632827681334; Tue, 28 Sep 2021 04:14:41 -0700 (PDT) MIME-Version: 1.0 References: <20210821021106.27010-1-luo.penghao@zte.com.cn> In-Reply-To: <20210821021106.27010-1-luo.penghao@zte.com.cn> From: Karol Herbst Date: Tue, 28 Sep 2021 13:14:30 +0200 Message-ID: Subject: Re: [PATCH linux-next] drm/nouveau/mmu: drop unneeded assignment in the nvkm_uvmm_mthd_page() To: CGEL Cc: Ben Skeggs , David Airlie , Daniel Vetter , dri-devel , nouveau , LKML , Luo penghao , Zeal Robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Karol Herbst On Sat, Aug 21, 2021 at 10:46 AM CGEL wrote: > > From: Luo penghao > > In order to keep the code style consistency of the whole file, > the 'ret' assignments should be deleted. > > The clang_analyzer complains as follows: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c:317:8:warning: > Although the value storedto 'ret' is used in the enclosing expression, > the value is never actually read from 'ret'. > > Reported-by: Zeal Robot > Signed-off-by: Luo penghao > --- > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c > index c43b824..d9f8e11 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c > @@ -314,7 +314,7 @@ nvkm_uvmm_mthd_page(struct nvkm_uvmm *uvmm, void *argv, u32 argc) > page = uvmm->vmm->func->page; > for (nr = 0; page[nr].shift; nr++); > > - if (!(ret = nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false))) { > + if (!(nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false))) { > if ((index = args->v0.index) >= nr) > return -EINVAL; > type = page[index].type; > -- > 2.15.2 > >