Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 11:12:31 +0000
From:   Hyeonggon Yoo <42.hyeyoo@gmail.com>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [QUESTION] is SLAB considered legacy and deprecated?
Message-ID: <20210928111231.GA2596@linux.asia-northeast3-a.c.our-ratio-313919.internal>
References: <20210927090347.GA2533@linux.asia-northeast3-a.c.our-ratio-313919.internal>
 <8aa15f4b-71de-5283-5ebc-d8d1a323473d@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8aa15f4b-71de-5283-5ebc-d8d1a323473d@suse.cz>
Precedence: bulk

On Mon, Sep 27, 2021 at 07:03:19PM +0200, Vlastimil Babka wrote:
> On 9/27/21 11:03, Hyeonggon Yoo wrote:
> > Hello there,
> > 
> > I've been working on adding 'lockless cache' on sl[au]b for a while.
> > But what it actually does is actually adding 'queuing' on slub.
> 
> Yeah, I pointed out those threads from 2011 that called it exactly that...
> was there any conclusion why that was not ultimately merged?
>

It's best to ask Christoph, as he suggested to add queuing on slub.
Well, after reading old threads, I concluded that it was not merged
because Christoph stopped developing this.

To make sure that he stopped developing this, I searched
his name and sorted by date. [1]

Then I see Christoph's last response on SLUB + Queueing was:
Christopher Lameter Wrote:
	David Rientjes Wrote:
	> Overall, the results are _much_ better than the vanilla slub allocator
	> that I frequently saw ~20% regressions with the TCP_RR netperf benchmark
	> on a couple of my machines with larger cpu counts. However, there still
	> is a significant performance degradation compared to slab.

	It seems that the memory leak is still present. This likely skews the
	results. Thought I had it fixed. Thanks.

It was not merged on 2.6.37-rc1 at that time [2]
And after some time he worked on improving SLUB itself [3], [4], [5],
not SLUB with queuing. (anyway his work resulted in lots of improvement on
slub without queuing)

And in [4], Christoph Lameter wrote:
	Well here is another result of my obsession with SLAB allocators. There must be
	some way to get an allocator done that is faster without queueing and I hope
	that we are now there (maybe only almost...). Any help with cleaning up the
	rough edges would be appreciated.

So I guess he concluded that adding queuing on SLUB was not good idea
(again, it's best to ask him)

> > So there is a fundamental question coming into my mind:
> > 	'is SLAB considered legacy and deprecated?'
> 
> To some extend, but not yet in a sense where we would have a deadline to get
> rid of it. 

What makes you to say 'To some extent'?
That's what I'm curious about :)

> In some contexts it's still being preferred, AFAIK.

In what context is SLAB or SLUB is preferred?
And what is the core reason that SLUB is used by default?

> > It seems there are little development on SLAB and people think that
> > SLAB is legacy and deprecated, so CONFIG_SLUB is used by default.
> > 
> > But I think both has pros and cons for their own:
> > 	SLAB: more temporal locality (cache friendly)
> > 	but high usage of memory, and less spatial locality (TLB misses) than SLUB.
> > 
> > 	SLUB: less temporal locality (less cache friendly) than SLAB
> > 	but more spatial locality (TLB hit), and low usage of memory
> > 	and good debugging feature.
> 
> I'm not so sure about the usage of memory, SLUB can easily use more I
> believe. Instead of caching some arrays of objects it will have one or more
> private slabs per cpu, and the slabs are larger-order pages.
>

SLAB uses much memory than slab, when there are *lots* of NUMA nodes.
	because kmem_cache_node exist per node and it keeps alien cache
	(used for caching freeing object from remote node),
	so it keeps MAX_NUMANODES ^ 2 of array_cache per slab.
	that is why I said SLAB uses much memory than SLUB.

to quote Christoph Lameter's (who made SLUB and current maintainer) presentation in 2014:
	See link [6] for this
	p21: "SLAB queuing can get intensive memory usage going grows
	exponentially by NUMA node"

But I'm not sure if SLAB or SLUB is good on UMA architecture.

> > Why do people say SLAB is deprecated/legacy?
> 
> Do they?
>

Yes I think they do.

One example is presentation of David Rientjes (one of maintainers) in 2011:
	See link [7]
	p5: "SLAB is deprecated, very little development"
	p5: "Many distributions still ship with CONFIG_SLAB even
		though it is not the kernel default"

Anyway, I wanted to discuss the current status of SLAB.

To me, it seems that people do not work on SLAB lately
and it seems some maintainers (David, Christoph) think
it's better to move from SLAB to SLUB. one of them is Christoph himself.
As he made SLUB because he don't agree on design of SLAB. [8]

Thanks,
Hyeonggon.

Searching his name and sort by date
[1] https://lore.kernel.org/lkml/?q=Christoph+Lameter&o=10800

[GIT PULL] SLAB updates for 2.6.37-rc1 by Pekka Enberg
[2] https://lore.kernel.org/lkml/alpine.DEB.2.00.1010242005280.4447@tiger/#r

His work on lockless fastpath of slub (2011-02),
[3] https://lore.kernel.org/lkml/20110225173850.486326452@linux.com/

His work on lockless fastpath of slub (2011-06)
[4] https://lore.kernel.org/lkml/20110601172543.437240675@linux.com/

His work on per cpu partial lists
[5] https://lore.kernel.org/lkml/20110809211221.831975979@linux.com/

Christoph's presentation on slab
[6] - https://events.static.linuxfound.org/sites/events/files/slides/slaballocators.pdf

David's presentation on slab
[7] - https://www.socallinuxexpo.org/scale9x-media/scalemedia/scale/scale9x-media/simple_cfp/presentations/16_30-DavidRientjes-Status_of_the_Linux_Slab_Allocators.pdf

[8] SLUB: The unqueued slab allocator V6
https://lwn.net/Articles/229096/