Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4803619pxb; Tue, 28 Sep 2021 04:36:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhiBEvvLgRbiUF+5jGXD8hPRBMQQZzEStodOo2H8XOTOhxGdwIMnPsvFdqRDIJ7BB676yC X-Received: by 2002:a17:90a:8911:: with SMTP id u17mr5027143pjn.162.1632828987666; Tue, 28 Sep 2021 04:36:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632828987; cv=none; d=google.com; s=arc-20160816; b=S8n6ww+Xbi+nRZG4BCpGswl03W4IFghYOz5sLEjCV/mQgVdZNuPvZ8G6p1wt1Jn6pq EWFHq+5tJz4GTuMFFA+7cFJUw7HARAzYtStQlPFA8p3ho6LhkDRsVi7w9Cz9i4GRFR7x fjttfdx4Xn2uQZJ3QBGZvH+XpSN8fG7zVc2rpXqsDWG8SjKU5tidM+j68jJj1eCwnbl5 xRxJc0D/Y6vH39jjkY/U4K++PxPYqep4SZYK6/+4FgAcjNLw17EcYXwBXAZvAJHiJzZF 0y9JReRJas7/M/bRj1BnuXHz4k4Jxe77/AlK5KerthonLXQuhTeH88Ut6fRfw0S93Cxc 8lxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=u328q7WNSMymaUrmKQOk37LWvJYmT3DIFH6zimZGPjY=; b=IQPhSAFMg62ezzXVtF9T/7aLe5KASEDaY5mynOJ/bzUG8kJ54xTOJ6RkVZYc+iC1j1 9iTjxMMf45b54oeG99tWP1bSkIpFZ4LD0urvCShOfxA6X4Q2P8KzBw8cJNJGYwweeCle dg5K+oPw4EMuFG1MAPyL67wZyHy1IlUvBhlilobHkwnaH50SeSTGpIW5VX+bgSfn4sBX mzd6GY1O3Uf1fouyFkQJIL1OmJb2swMphvvGk/vTwTrLhjpUwUkOE+QD6IqZ6G4zhYnO bX0WHWvDRImAX/ppEWJd4ZdJFNM+xJog1JC5GmmShg49qNVb/mbrPZiGQM2oZeIg2Y6f 1rgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="S6tfrwu/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i63si25148644pge.76.2021.09.28.04.36.13; Tue, 28 Sep 2021 04:36:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="S6tfrwu/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240172AbhI1LfY (ORCPT + 99 others); Tue, 28 Sep 2021 07:35:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44279 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240270AbhI1LfX (ORCPT ); Tue, 28 Sep 2021 07:35:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632828824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u328q7WNSMymaUrmKQOk37LWvJYmT3DIFH6zimZGPjY=; b=S6tfrwu/f1o8hyDh5eS01l8cbgIGCE6xtXMuxVdp7MhqbuuYr8v9FnMQ27Z+jUSbRB0p3H 325KxrLzrc1z94lasMQ3fAQYGQNnquFTZJAz6FK7jdTKzOVvsbqvODh1ldfVfeMAXY3bie WAQ3A2pXZCBWbE4yCnzyHmiaJpr5p14= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-LjAXvL12PLiOwIpHZKLOAg-1; Tue, 28 Sep 2021 07:33:42 -0400 X-MC-Unique: LjAXvL12PLiOwIpHZKLOAg-1 Received: by mail-wm1-f72.google.com with SMTP id z137-20020a1c7e8f000000b0030cd1800d86so1868019wmc.2 for ; Tue, 28 Sep 2021 04:33:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u328q7WNSMymaUrmKQOk37LWvJYmT3DIFH6zimZGPjY=; b=aA5n3+o67UEGccuQAQlHlkqQ2kp+3u1Ni+KvpNVh4myf2onfBbZ7xg3BE805D7QMdY WhApXqhIKyNby0O4aRs48YFqlRyY0q9X0NzbSu3asoO3nf5I0MH2DVA7kp+v8BqSQ9Ig j42icKWypm6yZEvBJL/y9UqBnMIHHjgEM8k/V9KdSt2CvqFi5HUJBIjU4gdQEtg4ETNJ TuZyGGlMz8qjyMxz7l6GWWuxFINErUijJqFqOcGx40n+dmGOTFl4oFR5qvnj6+iXG72b itHNPqE1FO6n9aDoLj8ed+U9KiotFx1WYlyhunKlQa2KDK5gM8cNi6d4nYq0lWcswu/B d+Yw== X-Gm-Message-State: AOAM530Kacec0n+C6FJzlvyOSGcxozgeePbFKki7aHck1CKe+YrumMG8 Mgv+M8pDWmLGrrqidUZ59n31hw+VgEymI8T66HjzZcvpk4TqMGxKnTVbmFdqZhyofeCIDJPxGNj CUkoYsE5Re3BAqsJ8nO38ay80f7KwPTOYOdo1WqyR X-Received: by 2002:adf:e44c:: with SMTP id t12mr5899187wrm.49.1632828821479; Tue, 28 Sep 2021 04:33:41 -0700 (PDT) X-Received: by 2002:adf:e44c:: with SMTP id t12mr5899164wrm.49.1632828821289; Tue, 28 Sep 2021 04:33:41 -0700 (PDT) MIME-Version: 1.0 References: <20210911075023.3969054-1-yangyingliang@huawei.com> In-Reply-To: <20210911075023.3969054-1-yangyingliang@huawei.com> From: Karol Herbst Date: Tue, 28 Sep 2021 13:33:30 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/nouveau/kms/nv50-: fix file release memory leak To: Yang Yingliang Cc: LKML , nouveau , dri-devel , Ben Skeggs Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Karol Herbst On Sat, Sep 11, 2021 at 9:45 AM Yang Yingliang wrote: > > When using single_open() for opening, single_release() should be > called, otherwise the 'op' allocated in single_open() will be leaked. > > Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c > index b8c31b697797..66f32d965c72 100644 > --- a/drivers/gpu/drm/nouveau/dispnv50/crc.c > +++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c > @@ -704,6 +704,7 @@ static const struct file_operations nv50_crc_flip_threshold_fops = { > .open = nv50_crc_debugfs_flip_threshold_open, > .read = seq_read, > .write = nv50_crc_debugfs_flip_threshold_set, > + .release = single_release, > }; > > int nv50_head_crc_late_register(struct nv50_head *head) > -- > 2.25.1 >