Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 08:51:42 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Mark Zhang <markzhang@nvidia.com>
Cc:     Leon Romanovsky <leon@kernel.org>,
        Doug Ledford <dledford@redhat.com>,
        Aharon Landau <aharonl@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Gal Pressman <galpress@amazon.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, Maor Gottlieb <maorg@nvidia.com>,
        Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
        Mustafa Ismail <mustafa.ismail@intel.com>,
        Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
        netdev@vger.kernel.org, Potnuri Bharat Teja <bharat@chelsio.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Selvin Xavier <selvin.xavier@broadcom.com>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH rdma-next v1 04/11] RDMA/counter: Add an is_disabled
 field in struct rdma_hw_stats
Message-ID: <20210928115142.GH964074@nvidia.com>
References: <cover.1631660727.git.leonro@nvidia.com>
 <97ef07eab2b56b39f3c93e12364237d5aec2acb6.1631660727.git.leonro@nvidia.com>
 <20210927165352.GA1529966@nvidia.com>
 <6c473b40-cd38-d5d7-78e7-b3f03142eee1@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6c473b40-cd38-d5d7-78e7-b3f03142eee1@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0ox5mHyqpgWfSQ5pK8xoccVtyth0salaPEXZtBevns7AWKisOIvm/aBJ3SXs?=
 =?us-ascii?Q?bspPoSsfoJ6UG4BlX+78xD46pOARhU+ZfjJfPRQoMXiJqnuHOcZn7VvlNUY5?=
 =?us-ascii?Q?YwiowzzLV5YfiwMW1jY666YAwVFmyxEQwyYVL2De9k82jzkb0vzdh9ICRQvI?=
 =?us-ascii?Q?Npo2i87D0JwDiLGfYsmD+Sa9ctme1egx9GkWjPyAwkAOVcXKhVn17JYSVDsl?=
 =?us-ascii?Q?hm5Hx4Dmm8S/3XnpjpziJXicMsaSHJi+yrc9N2Grz+FquuX9ABuyWPQIObcg?=
 =?us-ascii?Q?mYaYo4PF9QWKlZ3MrVYKNty1fN+U1Didm8+lG+lQXJR6gnGY6hApQp9KX3sP?=
 =?us-ascii?Q?XgP0DCe2KRWRGOJ0Taf16vXm05rZCbJPfoF9B4EktHxXRfYUy8Od72JjMRF4?=
 =?us-ascii?Q?BTQSzxLzm1ECDZoh/ZCDIvBLq1Inh9A1UcKQkZS74+lI6eSXtNpPL/FLiPXQ?=
 =?us-ascii?Q?KNbK7fMEpDhXEgRGqj9OT5F2HyghPuFaPRlgVZH5/ruBUYpzmQ5RMO0FxOo+?=
 =?us-ascii?Q?tNlqDZ5QAq0n9WzBCUSRigl5iNfxdkUN7+GS0F7sJuy3Oiln/v0BIhUtaOuE?=
 =?us-ascii?Q?efX8/f7xJerbEEwa6z9JokHQFoEfn8oN++IKl2mNLUCdNfW59SpLNpP+SHRZ?=
 =?us-ascii?Q?13tBqhLnRfflI6SZsgmQtKDwcl3FtTXRzS5hpsVcbsDOosFd/w1RBruIQjO/?=
 =?us-ascii?Q?OPagsaAFibGwKI2Kax32z3+lxcPzd44+8lBnCiaYS6+rZn7TF3kquvLufuem?=
 =?us-ascii?Q?yWyRRxcMD+TnO+xgxWECl42JYCVYXHMkMJ/F/vpvxtcHRJKMK3Fn50EOE/X9?=
 =?us-ascii?Q?S0f9PfcVhJgRHDMLwmhRRiU5j9MvTUnyNnFT14W+lOnqthP/KZyX1VRqLCR0?=
 =?us-ascii?Q?j+OhP/1/sZgDABanQXDLst06GVeaF9UIFHKX8VP/n3+oLQaHrKxB77v+bRVu?=
 =?us-ascii?Q?hMsKq6w8OCnTfWPEvU+Acf+uOUzJwHsYmt1C0qkh9HtJz8LitWHEuaWf8ou0?=
 =?us-ascii?Q?Gmgud2mxmg6/vuKBfqQWzrGqfRWfpdXcbf8yKrCY0/E6uXnX5ohAyleF8cZ1?=
 =?us-ascii?Q?JmB7RSLp2MelquQiXpQpvt2FVyw6MvUNNwzuPhkkvdexNT7Ytt8jb04AnUtg?=
 =?us-ascii?Q?6Jsu5hnwY20jltDz+D7udN0Tq47dmqCI/7KFtfo4weVGWxUFZ6BtUe12YKoJ?=
 =?us-ascii?Q?kS+dbjoG2Qw0Gn2rwkTv/YQ7KP89C7UObq6c30dd196BCBO/oxPPTPmmaT1W?=
 =?us-ascii?Q?IxZUzKnqwYZ0GC0xN4DAM6T8fF2t7ZWRHt+Jo5dRLVVIYnmNjeNxhiRLq0fc?=
 =?us-ascii?Q?y3ksDJRHgSu1RHLrVczffNgA?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 407b6b58-7cfc-4c17-c2ef-08d98276572d
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 11:51:43.2294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5JxeVNOw8O2+vIugQCxDAscRXEwtvmgjtsXGCQsdVqbmLs74iF6aRIHCG5F7zc1X
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5507
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 28, 2021 at 11:28:39AM +0800, Mark Zhang wrote:
> On 9/28/2021 12:53 AM, Jason Gunthorpe wrote:
> > On Wed, Sep 15, 2021 at 02:07:23AM +0300, Leon Romanovsky wrote:
> > 
> > > diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
> > > index 3f6b98a87566..67519730b1ac 100644
> > > +++ b/drivers/infiniband/core/nldev.c
> > > @@ -968,15 +968,21 @@ static int fill_stat_counter_hwcounters(struct sk_buff *msg,
> > >   	if (!table_attr)
> > >   		return -EMSGSIZE;
> > > @@ -601,11 +604,20 @@ static inline struct rdma_hw_stats *rdma_alloc_hw_stats_struct(
> > >   	if (!stats)
> > >   		return NULL;
> > > +	stats->is_disabled = kcalloc(BITS_TO_LONGS(num_counters),
> > > +				      sizeof(long), GFP_KERNEL);
> > > +	if (!stats->is_disabled)
> > > +		goto err;
> > > +
> > 
> > Please de-inline this function and make a rdma_free_hw_stats_struct()
> > call to pair with it. The hw_stats_data kfree should be in there. If
> > you do this as a precursor patch this patch will be much smaller.
> > 
> > Also, the
> > 
> >          stats = kzalloc(sizeof(*stats) + num_counters * sizeof(u64),
> >                          GFP_KERNEL);
> > 
> > Should be using array_size
> Maybe use struct_size:
>   stats = kzalloc(struct_size(stats, value, num_counters), GFP_KERNEL);

Right

Jason