Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 14:00:12 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Horatiu Vultur <horatiu.vultur@microchip.com>,
        hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: mdio: mscc-miim: Fix the mdio controller
Message-ID: <YVMDzAcQSjuiqoud@lunn.ch>
References: <20210928071720.2084666-1-horatiu.vultur@microchip.com>
 <20210928085414.GA1723@LAPTOP-UKSR4ENP.internal.baidu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210928085414.GA1723@LAPTOP-UKSR4ENP.internal.baidu.com>
Precedence: bulk

On Tue, Sep 28, 2021 at 04:54:14PM +0800, Cai Huoqing wrote:
> On 28 9月 21 09:17:20, Horatiu Vultur wrote:
> Hi Horatiu,
> 
> Thank for your feedback.
> 
> I'm sorry for this commit, my mistake.
> 
> After I have checked my recent submission history
> 
> the commit-
> commit fa14d03e014a130839f9dc1b97ea61fe598d873d
> drivers/net/mdio/mdio-ipq4019.c 225 line
> 
> has the same issue, an optional phy-regs
> Are you willing to fix it at the same time:)

Hi

Since it was a separate patch which broken it, it should be a separate
patch which fixes it.  Please send a fix.

You can also give a Reviewed-by: to Horatiu patch, if you think it is
correct.

Andrew