Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp4912583pxb; Tue, 28 Sep 2021 06:49:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0dC6ILsulK0ZomrojT5dpqMQvXqSwLlrDCiNLFf/niITGoYWQ8gUpldMQVUOLhWovSU4o X-Received: by 2002:a17:906:7fc4:: with SMTP id r4mr6985805ejs.75.1632836989538; Tue, 28 Sep 2021 06:49:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632836989; cv=none; d=google.com; s=arc-20160816; b=Dq8CuMgIOWK7ou49PxK3Hi07hXRSGewchqc00H3DbrvNmUX51qPN9p50VkNvzTjlKN sNJOptVYjQeJ0RI+yeLL3SyJcddnZROi5Ya8ndS/DNdaRDH9ZS5WVI6nTgY2cbyoloQQ bo8QrHDz6ImZxoofeXfrseFtairzonQWwXIsrgTZ/62l75qmpxhCcRlSCmxJhq9Sk6mg HKrqavn5XMuXs27AQYey8TxFz8lzKYod/vn9jCRUmT75gFGVKQ6WEPUmkSlKWwb3neT+ jOjX+L8xGH+awJBj6hFu9VJtN0Eh7tYKJHXSriQmVkhJDD9X2CcH0t3PW3Xy53e4QN8I C7bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=fPG/zZImuoTj2S84RbZB+XeAXE82Fru+A6dDz5O92v0GJdJQKgL+31600yEMbBAPUh Uk88iQGpsWGfPJZolbjkUALy9l7bFjR3KuuqqMh/xXQPxjgi3nB+ZoQMpnPkWLQPnWPC Io2kI68AjQWByKR3m/MIruGPYtSZh6OHeE8jz13R7zTuuZviKkYKHHiv8ODRD+EkWef0 /jLUoCjNJff0/UanM7kC6mvjyxwyhjjuPz/tsjn0Qdj2idRh5kqarLHm68D/psdHfsFB 9YazPMUILNLon7isHZEZUarN14RTrksiA0D1KVN2rdAKbVVIw2mHxYWgLTf2pPS8cjJb UEuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XQFP1mUh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i4si20766843ejj.165.2021.09.28.06.49.22; Tue, 28 Sep 2021 06:49:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XQFP1mUh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240989AbhI1NtJ (ORCPT + 99 others); Tue, 28 Sep 2021 09:49:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233878AbhI1NtH (ORCPT ); Tue, 28 Sep 2021 09:49:07 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEDF7C061575 for ; Tue, 28 Sep 2021 06:47:27 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id b20so93349750lfv.3 for ; Tue, 28 Sep 2021 06:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=XQFP1mUhXKlHXI+xEmvDrSXbeLGnD4CLmXjgYseEqEruv9KrCC6FSc8Y5Ho4LjbDOX zC6snsJNUUz1wZImn8MwvqtBxmMBxpHhjrx+sD7movv4TlZPXtvtAREC+/yRiKmX0pue ++eKN5f+0dJcVxMLuJppLKf8ZQF/8jTKUtiroQPAE26FNLy3qV5NuZ4Mfmn9YaCTMPq7 nzwGakmqi86S8+l5vHWVzyPlqaDPjAMTD04P50HoQaOwSxjmCvIFwGP8TkCDq/Iqin0z nosD+DseVrciB0VXscUsdG8/7r83wCXEdGV3qDxxotWcJfScS76Tqa9v285icJA3aBNN Ec1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=aIvI8BLRX0njmpWfQ9V90K655g56tK6jvBdD6tdUYqqSgwPyg0uN0OH9AWHTS8nnag y4EJRlBJgq+8ehKXe46MKIPWxsfru0hpXo8kk8jgU3lCQyTnaq+IgumMlx0sIIpKdQij joDTCRRHCGARfRl80yKUibTJZYOhpRzqhql2oXEtD8qNVWikrHXcOjbr5Yi/hkmIsCNz BC09k7mN5DkVgnkGl0nCc/PlLEnrqY/pnCeIx0ctMu7PjH5tfJtPTVtgJF8gDpUzu93h eLo2F14b7Hkz0eBbphSBOg2Q9xMjPmWDdH05aIWqFs/O5Mar0VzRJLKWkxfKWsxcXes1 peTA== X-Gm-Message-State: AOAM532f9sVmxy971rBVrbDq7I0kcOs5rOrqtV9c79+GagW22xm2ylQn OAaSY5rHPHh7sLqLz2PI+7rN3QhBu6iJgM5CARyADg== X-Received: by 2002:a19:f249:: with SMTP id d9mr5834936lfk.229.1632836846030; Tue, 28 Sep 2021 06:47:26 -0700 (PDT) MIME-Version: 1.0 References: <20210928013621.1245-1-caihuoqing@baidu.com> In-Reply-To: <20210928013621.1245-1-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 15:47:14 +0200 Message-ID: Subject: Re: [PATCH v2 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2021 at 3:36 AM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing > --- > v1->v2: Remove the separate line of PTR_ERR(). Reviewed-by: Linus Walleij Yours, Linus Walleij