Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: sched: Remove pointless preemption disable in sched_submit_work()
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, Peter Oskolkov <posk@posk.io>,
        Tejun Heo <tj@kernel.org>
References: <87sfxoai2l.ffs@tglx>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <87d7b153-11a6-2f47-a5ed-abe10a294df3@kernel.dk>
Date:   Tue, 28 Sep 2021 08:41:08 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <87sfxoai2l.ffs@tglx>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/28/21 8:30 AM, Thomas Gleixner wrote:
> Neither wq_worker_sleeping() nor io_wq_worker_sleeping() require to be invoked
> with preemption disabled:
> 
>   - The worker flag checks operations only need to be serialized against
>     the worker thread itself.
> 
>   - The accounting and worker pool operations are serialized with locks.
> 
> which means that disabling preemption has neither a reason nor a
> value. Remove it.

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe