Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 17:13:48 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Robert Marko <robert.marko@sartura.hr>
Cc:     andrew@lunn.ch, gregory.clement@bootlin.com,
        sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: marvell: espressobin-ultra: enable UART
 output by default
Message-ID: <20210928151348.cqgy6uuxs3owxaug@pali>
References: <20210927154159.2168500-1-robert.marko@sartura.hr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210927154159.2168500-1-robert.marko@sartura.hr>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Monday 27 September 2021 17:41:56 Robert Marko wrote:
> Since Espressobin Ultra board has a microUSB port
> with the onboard USB to UART connected to it to be
> used as a debug UART it makes no sense to require
> the bootloader to pass console args to the kernel in
> order to get console working.
> 
> So, use the "stdout-path" property to enable the UART
> output on the microUSB port by default.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index c5eb3604dd5b..c1770ceff3c1 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -15,6 +15,10 @@ / {
>  	compatible = "globalscale,espressobin-ultra", "marvell,armada3720",
>  		     "marvell,armada3710";
>  
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +

This code is duplication of common espressobin code from
armada-3720-espressobin.dtsi file:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi

>  	aliases {
>  		/* ethernet1 is WAN port */
>  		ethernet1 = &switch0port5;
> -- 
> 2.31.1
>