Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 10:35:55 -0500
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Shawn Guo <shawn.guo@linaro.org>
Cc:     Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Steev Klimaszewski <steev@kali.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: c630: Move panel to aux-bus
Message-ID: <YVM2WwFZxv5Rm+Dw@builder.lan>
References: <20210924025255.853906-1-bjorn.andersson@linaro.org>
 <20210926060749.GB9901@dragon>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210926060749.GB9901@dragon>
Precedence: bulk

On Sun 26 Sep 01:07 CDT 2021, Shawn Guo wrote:

> On Thu, Sep 23, 2021 at 09:52:55PM -0500, Bjorn Andersson wrote:
> > With the newly introduced aux-bus under the TI SN65DSI86 the panel
> > node should be described as a child instead of a standalone node, move
> > it there.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >  .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 27 +++++++++----------
> >  1 file changed, 13 insertions(+), 14 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > index bd22352b6c7a..4818ca6d820d 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > @@ -56,20 +56,6 @@ mode {
> >  		};
> >  	};
> >  
> > -	panel {
> > -		compatible = "boe,nv133fhm-n61";
> > -		no-hpd;
> > -		backlight = <&backlight>;
> 
> There is some prerequisite change for this patch?  I do not find this
> backlight node on v5.15-rc, neither linux-next.
> 

Seems I had this and the backlight addition patch in the wrong order in
my local tree. Let's see if we can land the backlight support and then
I'll repost this.

Thanks,
Bjorn

> Shawn
> 
> > -
> > -		ports {
> > -			port {
> > -				panel_in_edp: endpoint {
> > -					remote-endpoint = <&sn65dsi86_out>;
> > -				};
> > -			};
> > -		};
> > -	};
> > -
> >  	/* Reserved memory changes for IPA */
> >  	reserved-memory {
> >  		wlan_msa_mem: memory@8c400000 {
> > @@ -441,6 +427,19 @@ sn65dsi86_out: endpoint {
> >  				};
> >  			};
> >  		};
> > +
> > +		aux-bus {
> > +			panel: panel {
> > +				compatible = "boe,nv133fhm-n61";
> > +				backlight = <&backlight>;
> > +
> > +				port {
> > +					panel_in_edp: endpoint {
> > +						remote-endpoint = <&sn65dsi86_out>;
> > +					};
> > +				};
> > +			};
> > +		};
> >  	};
> >  };
> >  
> > -- 
> > 2.32.0
> >