Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 17:37:31 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Robert Marko <robert.marko@sartura.hr>
Cc:     andrew@lunn.ch, gregory.clement@bootlin.com,
        sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: marvell: espressobin-ultra: enable front
 USB3 port
Message-ID: <20210928153731.7we6p7mclil2e5j2@pali>
References: <20210927154159.2168500-1-robert.marko@sartura.hr>
 <20210927154159.2168500-4-robert.marko@sartura.hr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210927154159.2168500-4-robert.marko@sartura.hr>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Monday 27 September 2021 17:41:59 Robert Marko wrote:
> Espressobin Ultra has a front panel USB3.0 Type-A port which works
> just fine so enable it.
> I dont see a reason why it was disabled in the first place anyway.

If USB 3.0 port is was tested and is working fine, then what about
adding Fixes: tag into commit message?

> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index 96855a10b4a0..aada43fa236c 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -112,7 +112,6 @@ rtc@51 {
>  
>  &usb3 {
>  	usb-phy = <&usb3_phy>;
> -	status = "disabled";
>  };
>  
>  &mdio {
> -- 
> 2.31.1
>