Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210927154159.2168500-1-robert.marko@sartura.hr> <20210928151348.cqgy6uuxs3owxaug@pali>
In-Reply-To: <20210928151348.cqgy6uuxs3owxaug@pali>
From:   Robert Marko <robert.marko@sartura.hr>
Date:   Tue, 28 Sep 2021 17:49:55 +0200
Message-ID: <CA+HBbNGVMCEGnh9u9nkceRrsYkM6BNL4k0PA=i7eT7xs9GAM2g@mail.gmail.com>
Subject: Re: [PATCH 1/4] arm64: dts: marvell: espressobin-ultra: enable UART
 output by default
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>
Cc:     Andrew Lunn <andrew@lunn.ch>, gregory.clement@bootlin.com,
        sebastian.hesselbarth@gmail.com, Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Sep 28, 2021 at 5:13 PM Pali Roh=C3=A1r <pali@kernel.org> wrote:
>
> On Monday 27 September 2021 17:41:56 Robert Marko wrote:
> > Since Espressobin Ultra board has a microUSB port
> > with the onboard USB to UART connected to it to be
> > used as a debug UART it makes no sense to require
> > the bootloader to pass console args to the kernel in
> > order to get console working.
> >
> > So, use the "stdout-path" property to enable the UART
> > output on the microUSB port by default.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> >  arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.=
dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> > index c5eb3604dd5b..c1770ceff3c1 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> > @@ -15,6 +15,10 @@ / {
> >       compatible =3D "globalscale,espressobin-ultra", "marvell,armada37=
20",
> >                    "marvell,armada3710";
> >
> > +     chosen {
> > +             stdout-path =3D "serial0:115200n8";
> > +     };
> > +
>
> This code is duplication of common espressobin code from
> armada-3720-espressobin.dtsi file:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/a=
rch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi

Ahh yes, I don't know why was it not working by default then.
Sorry for the noise, I will drop this patch.

Regards,
Robert
>
> >       aliases {
> >               /* ethernet1 is WAN port */
> >               ethernet1 =3D &switch0port5;
> > --
> > 2.31.1
> >


--=20
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr