Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <fbdcbb8f-380c-4da9-2860-a3729c75e04b@paragon-software.com>
Date:   Tue, 28 Sep 2021 20:21:54 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH 2/3] fs/ntfs3: Reject mount if boot's cluster size < media
 sector size
Content-Language: en-US
To:     Kari Argillander <kari.argillander@gmail.com>
CC:     <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
References: <16cbff75-f705-37cb-ad3f-43d433352f6b@paragon-software.com>
 <6036b141-56e2-0d08-b9ff-641c3451f45a@paragon-software.com>
 <20210927185621.2wkznecc4jndja6b@kari-VirtualBox>
From:   Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
In-Reply-To: <20210927185621.2wkznecc4jndja6b@kari-VirtualBox>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 27.09.2021 21:56, Kari Argillander wrote:
> On Mon, Sep 27, 2021 at 06:48:00PM +0300, Konstantin Komarov wrote:
>> If we continue to work in this case, then we can corrupt fs.
>>
> 
> Should have fixes tag.
> 

The bug is in initial commit.
Do I need to write
Fixes: 82cae269cfa95 "fs/ntfs3: Add initialization of super block"
?

>> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
>> ---
>>  fs/ntfs3/super.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
>> index 7099d9b1f3aa..193f9a98f6ab 100644
>> --- a/fs/ntfs3/super.c
>> +++ b/fs/ntfs3/super.c
>> @@ -763,9 +763,14 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
>>  	sbi->mft.lbo = mlcn << sbi->cluster_bits;
>>  	sbi->mft.lbo2 = mlcn2 << sbi->cluster_bits;
>>  
>> +	/* Compare boot's cluster and sector. */
> 
> Pretty random obvious comment and I do not know what this does in this
> patch.
> 
>>  	if (sbi->cluster_size < sbi->sector_size)
>>  		goto out;
>>  
>> +	/* Compare boot's cluster and media sector. */
>> +	if (sbi->cluster_size < sector_size)
>> +		goto out; /* No way to use ntfs_get_block in this case. */
> 
> Usually comment should not go after line. If you take chunk from patch
> 3/3 then this is not issue.
> 
>> +
>>  	sbi->cluster_mask = sbi->cluster_size - 1;
>>  	sbi->cluster_mask_inv = ~(u64)sbi->cluster_mask;
>>  	sbi->record_size = record_size = boot->record_size < 0
>> -- 
>> 2.33.0
>>
>>
>>