Date: Mon, 18 Dec 2006 05:28:07 -0500 (EST)
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove logically superfluous comparisons from Kconfig
 files.
In-Reply-To: <20061218102653.GA23947@flint.arm.linux.org.uk>
Message-ID: <Pine.LNX.4.64.0612180527440.22930@localhost.localdomain>
References: <Pine.LNX.4.64.0612180509010.22527@localhost.localdomain>
 <20061218102653.GA23947@flint.arm.linux.org.uk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 854
Lines: 34

On Mon, 18 Dec 2006, Russell King wrote:

> On Mon, Dec 18, 2006 at 05:14:01AM -0500, Robert P. J. Day wrote:
> >   Remove Kconfig comparisons of the form FUBAR || FUBAR=n, since they
> > appear to be superfluous.
>
> config FOO
> 	tristate 'foo'
> 	depends on BAR || BAR=n
>
> is not superfluous.  The allowed states for FOO with the above construct
> are (assuming modules are enabled):
>
> 	BAR	FOO
> 	Y	Y,M,N
> 	M	M,N
> 	N	Y,M,N

ah, ok, i get it now.

> Also, you create some constructs such as:
>
>         depends on && PCI
>
> which is obviously wrong.

whoops, sorry, i didn't even notice that.

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/