Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 15:55:08 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     John Garry <john.garry@huawei.com>
Cc:     Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Jin Yao <yao.jin@linux.intel.com>,
        "Paul A . Clarke" <pc@us.ibm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        eranian@google.com
Subject: Re: [PATCH v3 1/2] perf test: Workload test of metric and
 metricgroups
Message-ID: <YVNlDGP8NCWocNtY@kernel.org>
References: <20210917184240.2181186-1-irogers@google.com>
 <YU4iVcVc6uYAWft4@kernel.org>
 <ea23f319-49df-5905-758e-478baf44bdc9@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ea23f319-49df-5905-758e-478baf44bdc9@huawei.com>
Precedence: bulk

Em Fri, Sep 24, 2021 at 08:39:18PM +0100, John Garry escreveu:
> On 24/09/2021 20:09, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Sep 17, 2021 at 11:42:39AM -0700, Ian Rogers escreveu:
> > > Test every metric and metricgroup with 'true' as a workload. For
> > > metrics, check that we see the metric printed or get unsupported. If the
> > > 'true' workload executes too quickly retry with 'perf bench internals
> > > synthesize'.

> > > v3. Fix test condition (thanks to Paul A. Clarke<pc@us.ibm.com>). Add a
> > >      fallback case of a larger workload so that we don't ignore "<not
> > >      counted>".
> > > v2. Switched the workload to something faster.
> > Hi John, does your Reviewed-by stands for v3 too?
 
> Yeah,
 
> Reviewed-by: John Garry <john.garry@huawei.com>

Thanks, applied.

- Arnaldo