Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753783AbWLRKty (ORCPT ); Mon, 18 Dec 2006 05:49:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753780AbWLRKty (ORCPT ); Mon, 18 Dec 2006 05:49:54 -0500 Received: from [85.204.20.254] ([85.204.20.254]:47721 "EHLO megainternet.ro" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753781AbWLRKtx (ORCPT ); Mon, 18 Dec 2006 05:49:53 -0500 Subject: Re: 2.6.19 file content corruption on ext3 From: Andrei Popa Reply-To: andrei.popa@i-neo.ro To: Peter Zijlstra Cc: Andrew Morton , Linus Torvalds , Nick Piggin , Linux Kernel Mailing List , Hugh Dickins , Florian Weimer , Marc Haber , Martin Michlmayr In-Reply-To: <1166436717.10372.58.camel@twins> References: <1166314399.7018.6.camel@localhost> <20061217040620.91dac272.akpm@osdl.org> <1166362772.8593.2.camel@localhost> <20061217154026.219b294f.akpm@osdl.org> <45861E68.3060403@yahoo.com.au> <1166433544.6911.5.camel@localhost> <20061218013806.2cf67614.akpm@osdl.org> <1166436005.7072.15.camel@localhost> <1166436717.10372.58.camel@twins> Content-Type: text/plain Organization: I-NEO Date: Mon, 18 Dec 2006 12:49:46 +0200 Message-Id: <1166438986.7003.1.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 38 > OK, I'll try this on a ext3 box. BTW, what data mode are you using ext3 > in? > ordered > > Also, for testings sake, could you give this a go: > It's a total hack but I guess worth testing. > > --- > mm/rmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6-git/mm/rmap.c > =================================================================== > --- linux-2.6-git.orig/mm/rmap.c 2006-12-18 11:06:29.000000000 +0100 > +++ linux-2.6-git/mm/rmap.c 2006-12-18 11:07:16.000000000 +0100 > @@ -448,7 +448,7 @@ static int page_mkclean_one(struct page > goto unlock; > > entry = ptep_get_and_clear(mm, address, pte); > - entry = pte_mkclean(entry); > + /* entry = pte_mkclean(entry); */ > entry = pte_wrprotect(entry); > ptep_establish(vma, address, pte, entry); > lazy_mmu_prot_update(entry); > with latest git and this patch there is no corruption ! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/