Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210920182038.1510501-1-cpp.code.lv@gmail.com>
 <0d70b112-dc7a-7083-db8d-183782b8ef8f@6wind.com> <CAASuNyUWoZ1wToEUYbdehux=yVnWQ=suKDyRkQfRD-72DOLziw@mail.gmail.com>
 <e4bb09d1-8c8f-bfdf-1582-9dd8c560411b@6wind.com>
In-Reply-To: <e4bb09d1-8c8f-bfdf-1582-9dd8c560411b@6wind.com>
From:   Cpp Code <cpp.code.lv@gmail.com>
Date:   Tue, 28 Sep 2021 12:20:49 -0700
Message-ID: <CAASuNyUv-dZmws77dDurgaE-VQ=pmXm7YZAnQwig8rGE8d5w5Q@mail.gmail.com>
Subject: Re: [PATCH net-next v5] net: openvswitch: IPv6: Add IPv6 extension
 header support
To:     Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc:     netdev@vger.kernel.org, pshelar@ovn.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        ovs dev <dev@openvswitch.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Sep 28, 2021 at 7:51 AM Nicolas Dichtel
<nicolas.dichtel@6wind.com> wrote:
>
> Le 27/09/2021 =C3=A0 21:12, Cpp Code a =C3=A9crit :
> > To use this code there is a part of code in the userspace. We want to
> > keep compatibility when we only update userspace part code or only
> > kernel part code. This means we should have same values for constants
> > and we can only add new ones at the end of list.
> All attributes after OVS_KEY_ATTR_CT_STATE (ie 7 attributes) were added b=
efore
> OVS_KEY_ATTR_TUNNEL_INFO.
> Why is it not possible anymore?
>
>
> Regards,
> Nicolas
>
> >
> > Best,
> > Tom
> >
> > On Wed, Sep 22, 2021 at 11:02 PM Nicolas Dichtel
> > <nicolas.dichtel@6wind.com> wrote:
> >>
> >> Le 20/09/2021 =C3=A0 20:20, Toms Atteka a =C3=A9crit :
> >>> This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
> >>> packets can be filtered using ipv6_ext flag.
> >>>
> >>> Signed-off-by: Toms Atteka <cpp.code.lv@gmail.com>
> >>> ---
> >>>  include/uapi/linux/openvswitch.h |  12 +++
> >>>  net/openvswitch/flow.c           | 140 +++++++++++++++++++++++++++++=
++
> >>>  net/openvswitch/flow.h           |  14 ++++
> >>>  net/openvswitch/flow_netlink.c   |  24 +++++-
> >>>  4 files changed, 189 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op=
envswitch.h
> >>> index a87b44cd5590..dc6eb5f6399f 100644
> >>> --- a/include/uapi/linux/openvswitch.h
> >>> +++ b/include/uapi/linux/openvswitch.h
> >>> @@ -346,6 +346,13 @@ enum ovs_key_attr {
> >>>  #ifdef __KERNEL__
> >>>       OVS_KEY_ATTR_TUNNEL_INFO,  /* struct ip_tunnel_info */
> >>>  #endif
> >>> +
> >>> +#ifndef __KERNEL__
> >>> +     PADDING,  /* Padding so kernel and non kernel field count would=
 match */
> >>> +#endif
> >>> +
> >>> +     OVS_KEY_ATTR_IPV6_EXTHDRS,  /* struct ovs_key_ipv6_exthdr */
> >> Naive question, why not moving OVS_KEY_ATTR_IPV6_EXTHDRS above
> >> OVS_KEY_ATTR_TUNNEL_INFO?
> >>
> >>
> >>
> >> Regards,
> >> Nicolas

These 3 commits does not support compatibility for scenarios when only
kernel gets updated. I assume at that point this requirement wasn't
required.

Best,
Tom