Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 09/13] x86/uintr: Introduce vector registration and
 uintr_fd syscall
To:     Thomas Gleixner <tglx@linutronix.de>, <x86@kernel.org>
CC:     Tony Luck <tony.luck@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        "Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Jens Axboe <axboe@kernel.dk>,
        Christian Brauner <christian@brauner.io>,
        Peter Zijlstra <peterz@infradead.org>,
        Shuah Khan <shuah@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Ashok Raj <ashok.raj@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "Gayatri Kammela" <gayatri.kammela@intel.com>,
        Zeng Guang <guang.zeng@intel.com>,
        "Dan Williams" <dan.j.williams@intel.com>,
        Randy E Witt <randy.e.witt@intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Ramesh Thomas <ramesh.thomas@intel.com>,
        <linux-api@vger.kernel.org>, <linux-arch@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <87wnn6dzzn.ffs@tglx>
From:   Sohil Mehta <sohil.mehta@intel.com>
Message-ID: <c2b50159-836f-2fd4-e469-938c9dd50166@intel.com>
Date:   Tue, 28 Sep 2021 13:40:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
In-Reply-To: <87wnn6dzzn.ffs@tglx>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cStseFlTZUxrTm8rSlI2WE1wUDZjT3EybmNSYTdYN2EzeVByNjdsVWxyV0JE?=
 =?utf-8?B?OFd2M0hIcG1QOGVoYnNUYTRPWlFheGNkbVJWcVV0SWtiZXdVV1ZaTkFuaGxk?=
 =?utf-8?B?OHVjVWUwQ1ZVN004Z0hDVytnaDFXNUQ0TmlGRFZtaG5HMnpkV2pOTTRTTnZu?=
 =?utf-8?B?YTg3RTB5VWV1Y3JaV3ZTMmpOZzRRUFp3RnU0eDhlZENYVG1pZFBqaTAyOHFL?=
 =?utf-8?B?TWROOVk0UTliaFdYVzVhZ00wSm5HSUFxdHhXMjJ5NUVPZGQvSTlFc0dRZjU5?=
 =?utf-8?B?YkEvMkxoRzMwWmxtU2p6MWJYSnpiV3BxaWk2NWsvaTRzT0s5ZVJCakNIK0Q4?=
 =?utf-8?B?ZkZrcGppTllmZ09NYStoWU5Ob0R4Tm9LbTF4QTZaRjdJaGJCMHlEdW5nTVV1?=
 =?utf-8?B?Q2pSVXB4YVlNZmk4VWdNUGpzTUlmQVRtUlhzUWpWOFo1U0JtY0xCRXNKeDNT?=
 =?utf-8?B?ekJEd1VlTzRHNDFnLzRINXkxa3VoOGpZQ09FVVNkeG1IYXVwWjh3blZpWmxh?=
 =?utf-8?B?MTZ6OElNOHJTWXdCYlJzeVN6RUJpQmQvd2xXYmY2Z05WWFFvUmtXQ3pyWmt3?=
 =?utf-8?B?eHdtejZ2djVhdGF6R0xqTDdrOVNSMHJidnRFZHQwbngxdi9GR1R0UFhwQVpB?=
 =?utf-8?B?RjZ2RjMxK3Awa1RmU2NwZ0l5NVRrNHZZeHF5ZmlqL1Q2UXNrOUVDOWZRWXph?=
 =?utf-8?B?d0VUQ2NZdytqNlhuRk5oTi9RREJENFZHTXNJZlNJSndpTk9DTGhYMXdadVRv?=
 =?utf-8?B?T3IySWRWcnRQRkJLcEEybVdEUzVHc1lxeUJQOGptM2FtUkdYZS9PTVdtSGZs?=
 =?utf-8?B?ckp3bW54Q0FNLzQ5Wms0M0ZzSlFoeUlBZVVFSmFPZU1haXdhbk9ueHJFZ1RI?=
 =?utf-8?B?d3RkaC93bkNWZGZtdHZXOXF3NDN0bU1iQ29qbmFHSVBZdVVCcnFTUmNrZjlt?=
 =?utf-8?B?TzFkYUExeGo5YTA1dVFEaEZKNTkxdzJQZTVuRVFHZXREQUVXVUdiQStLUUND?=
 =?utf-8?B?QTZkdUdCcmd2d3lBS1pBVVlJOEw2dWpLSVFwakNWRVFjbUwyM0ZZR0VMR2lF?=
 =?utf-8?B?bzVEVG9SdnV4UEY4cnJ4TlhUeGIxV3ZYNU5kMWVvVTUrUVpneE9qajMvVUsw?=
 =?utf-8?B?eCtyOEFWZ0JYMnRVS29kTUQ2TTBsUzBaNXlTQVUyUkpRTG1oaWdUUjFXbzJV?=
 =?utf-8?B?ZXNuTEFzMTJZbUNzMUFXWXlYcFFJdmlwSitXZzBEbnltNTFuWTYybTg4dDNz?=
 =?utf-8?B?QzNZZ2JjZE1JeE9RYWxoWGNtS2w1ZW5EL2htUy9ZeUJHTzNwVnlTOGJ4bVFk?=
 =?utf-8?B?Vk1BNzFTYjdPSnNhZ05ma09HL3hSMVZNMFZpMGx3QUV0dkJuSjVwMzZNaW5K?=
 =?utf-8?B?OUFvN0E2RkhYdWc5ZnJuU3B2eHo2Kzk4VEZicXp1bFFYaEFYQVNWK04wTmh1?=
 =?utf-8?B?aWEwMytJZXkzZGZ2b0Q0ZEpKWkdZK1VMNE4xUnVOYXlDeVFvWEFyOVNDVUxY?=
 =?utf-8?B?NkV4KzFDMTg2VUwxZ0Z2MzVzTDVqMGl3UDYwT3FpOStnZmNNRHIwQXdiNVpD?=
 =?utf-8?B?UjRkenJzWVUyMi9lbVZ2RHg5bkd6Ty9tYVFPalVDMTVENGxBKzE1bG9LY2VG?=
 =?utf-8?B?ME1jMXlyclg2ckRmT3NFb2VsaWZ0ZXg2WXVORVkrQis1THRVNFcySGdacmFU?=
 =?utf-8?B?MStLbnY5RlFwREFneGZHYnNaeG83MDNzdXZBYlBzaUlneXAyeG9XVmh1SUJR?=
 =?utf-8?Q?rQ9jLa+8gz5ZRKAXhpX1NTiHxkiQuFcOU7XL1Ze?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 947f314c-d618-4e7f-4b40-08d982c0378a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 20:40:33.1265
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EviMVkDE959sS3cwLcOB+uTRiUU/WgApVodLeL8hJheQqxIcLjN3pG7kyRKc6sprgInYGjO4yMJPhqIEo+wLpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4040
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/24/2021 3:33 AM, Thomas Gleixner wrote:
> If this ever comes back in some form, then I pretty please want the life
> time rules of this documented properly.

I'll document the life time rules for the UPID, vector and UITT next 
time. I realize now that they are quite convoluted in the current 
implementation.

I'll also fix the concurrency and serialization issues that you 
mentioned in this patch and the next one.


>
>> +	ret = task_work_add(r_info->upid_ctx->task, &r_info->twork, true);
> Care to look at the type of the third argument of task_work_add()?

Ah! I didn't realize the third argument changed a long time back.


>
>> +/*
>> + * sys_uintr_create_fd - Create a uintr_fd for the registered interrupt vector.
> So this creates a file descriptor for a vector which is already
> allocated and then it calls do_uintr_register_vector() which allocates
> the vector?

The syscall comment is misleading. Will fix it.

Vector allocation happens in userspace. The application is only expected 
to register the vector.

This syscall only creates an FD abstraction for the vector that is 
*being* registered.

>> + */
>> +SYSCALL_DEFINE2(uintr_create_fd, u64, vector, unsigned int, flags)
>> +{

Thanks,

Sohil