Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Chrisanthus, Anitha" <anitha.chrisanthus@intel.com>
To:     Nathan Chancellor <nathan@kernel.org>,
        "Dea, Edmund J" <edmund.j.dea@intel.com>
CC:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>, lkp <lkp@intel.com>
Subject: RE: [PATCH] drm/kmb: Remove
 set_test_mode_src_osc_freq_target_{hi,low}_bits()
Thread-Topic: [PATCH] drm/kmb: Remove
 set_test_mode_src_osc_freq_target_{hi,low}_bits()
Thread-Index: AQHXtJ5sxognB5Xrs0e6qUBrFVe0/6u56Rzg
Date:   Tue, 28 Sep 2021 20:42:37 +0000
Message-ID: <BY5PR11MB4182633C57DF92E3793BF2978CA89@BY5PR11MB4182.namprd11.prod.outlook.com>
References: <20210928192338.1987872-1-nathan@kernel.org>
In-Reply-To: <20210928192338.1987872-1-nathan@kernel.org>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WJCvf+VgXV8coestw5MWSGH0mIe5B53zcQr/TT6YKprVvPBdlGVOaLX5f8dA?=
 =?us-ascii?Q?DfVYzTCP/Uvdp/Y/7xfPehK/YMJeIZSGQukmPGAX2A0phMISLK4G29PMWYcI?=
 =?us-ascii?Q?rFJIHZIdeiRPSOzoIXSNBY51qfpzR4Gm7FAJs+V+fhIyML5PjqDEpuQtzKj/?=
 =?us-ascii?Q?VQYipBAcwhXJCc+QGHuuRuMH49FHMhP0qT0PZCLJeYV6/Scpuy/jnhuzMgV6?=
 =?us-ascii?Q?OHs0wMIxa4yDjrsWQH4in5F3zAYr3uNQ+ANkkmL0IkoMIXfVtliFsZ/CO1w1?=
 =?us-ascii?Q?HUXwBd44DK/OOXQ825RLFfsIcCwekczjjbTCIK+l78ochFWPXwrFCamEJymk?=
 =?us-ascii?Q?l8Ht/sG218Gcuh76M5ApxK9FboY4OpLg0KR3Tkf/L22Wl69hQLGHwcdKNsbr?=
 =?us-ascii?Q?R/QdVbQ41nzOyXX38imgzhdo+e/TctgskYMJ4o7f+ucgJ4RIuGcOgTNyTxJM?=
 =?us-ascii?Q?T9XhQ5rcIZimRuSD8kYFjZuv8ghirFIVnnRy51qXJPmoyhlnmumY7oFyAktW?=
 =?us-ascii?Q?pmlwUzOg1M0wG3vPIzSzdzAyOQSmkdkRYijWlqe1hO7ZC9d0+aOeqRZmPNDB?=
 =?us-ascii?Q?wporFHzDV+0D9YhFGaJ0kVfan0AuuxloPL8n9ocsnoqFzVZkCHCbpJHshn+n?=
 =?us-ascii?Q?pxmu9ZLHmxgzz9PhkjFOQasnETRxsr0U0/uet33aI32+QnuwpmBl8mtJn/7V?=
 =?us-ascii?Q?EaKdFsStMCFcCKIxsadgC0f9305NX4c9rgGDY5xWKBcAwFgvF7plgc+wYDhT?=
 =?us-ascii?Q?WZtyP7jsK1eyrr29saAyw8X3KSiAqzQTJITwEjD2rWPxPTzTzsmaIjmSZuni?=
 =?us-ascii?Q?5L2AjI0YPTknw4hcKIs8arZQvNntBANPOqtPN4m3rA2SygmnEBfmeZH7lwWR?=
 =?us-ascii?Q?/GESldMpY1mUkG5v8FjTMNHy3QvUbh4aYOc5SwW4QkhEqm5qrAZlHUB9uFMp?=
 =?us-ascii?Q?2rh6Sbu6RzRvXuguw/nGWNP8IHa3SgYLt76ENmgfklMtziBdAMzbT9ewX6tv?=
 =?us-ascii?Q?GQnN1kkDZYDCA8CzafgY5qqMbVLtlsk2bNTj0oMQCitOVY6i0yLbm16lclio?=
 =?us-ascii?Q?nJvPZd4KiAYKuJkDDhxibV/qRL4zwD4n58yILO95xNOomhsejvzo7S4sa/+t?=
 =?us-ascii?Q?tc3Y/jHzt/cbvRBTQMVTqWnGCZaaXbqqCRdhu/vgQ6njWUPEMNE7s2aTpptQ?=
 =?us-ascii?Q?4cvhqcAuRaYfl5ox6Z1gKhof7t3LCZ1seG4/SjsjbnhfuO7c/wxpJmdY1W1L?=
 =?us-ascii?Q?vRA0XJrxkL6ffo46h0GXkIjfMnwzoqskPk6Ip+mYENZ3Kw2KvCcfYyut/vcb?=
 =?us-ascii?Q?WQg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4182.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ee72240-973b-43d6-ea5b-08d982c08228
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2021 20:42:37.7777
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gTpUdD0fePBK+OGWiJivzmiSw21aPDpbBIn4k8KDco/9CTc/NIeveZMpcfai4Ayl0uCZ16RLnC9xmTyKdP10MwCXPqxz8892SYlJd1SK2hE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3254
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for the patch. Looks good.
Acked-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>

> -----Original Message-----
> From: Nathan Chancellor <nathan@kernel.org>
> Sent: Tuesday, September 28, 2021 12:24 PM
> To: Chrisanthus, Anitha <anitha.chrisanthus@intel.com>; Dea, Edmund J
> <edmund.j.dea@intel.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>; Nick Desaulniers
> <ndesaulniers@google.com>; dri-devel@lists.freedesktop.org; linux-
> kernel@vger.kernel.org; llvm@lists.linux.dev; Nathan Chancellor
> <nathan@kernel.org>; lkp <lkp@intel.com>
> Subject: [PATCH] drm/kmb: Remove
> set_test_mode_src_osc_freq_target_{hi,low}_bits()
>=20
> clang with W=3D1 warns:
>=20
> drivers/gpu/drm/kmb/kmb_dsi.c:812:2: error: unused function
> 'set_test_mode_src_osc_freq_target_low_bits' [-Werror,-Wunused-function]
>         set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi *kmb_ds=
i,
>         ^
> drivers/gpu/drm/kmb/kmb_dsi.c:824:2: error: unused function
> 'set_test_mode_src_osc_freq_target_hi_bits' [-Werror,-Wunused-function]
>         set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi=
,
>         ^
> 2 errors generated.
>=20
> Remove them, as they have been unused since the driver's introduction in
> commit 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver").
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  drivers/gpu/drm/kmb/kmb_dsi.c | 28 ----------------------------
>  1 file changed, 28 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c
> b/drivers/gpu/drm/kmb/kmb_dsi.c
> index 1793cd31b117..ae24c5fc35a5 100644
> --- a/drivers/gpu/drm/kmb/kmb_dsi.c
> +++ b/drivers/gpu/drm/kmb/kmb_dsi.c
> @@ -808,34 +808,6 @@ static void test_mode_send(struct kmb_dsi
> *kmb_dsi, u32 dphy_no,
>  	}
>  }
>=20
> -static inline void
> -	set_test_mode_src_osc_freq_target_low_bits(struct kmb_dsi
> *kmb_dsi,
> -						   u32 dphy_no,
> -						   u32 freq)
> -{
> -	/* Typical rise/fall time=3D166, refer Table 1207 databook,
> -	 * sr_osc_freq_target[7:0]
> -	 */
> -	test_mode_send(kmb_dsi, dphy_no,
> TEST_CODE_SLEW_RATE_DDL_CYCLES,
> -		       (freq & 0x7f));
> -}
> -
> -static inline void
> -	set_test_mode_src_osc_freq_target_hi_bits(struct kmb_dsi *kmb_dsi,
> -						  u32 dphy_no,
> -						  u32 freq)
> -{
> -	u32 data;
> -
> -	/* Flag this as high nibble */
> -	data =3D ((freq >> 6) & 0x1f) | (1 << 7);
> -
> -	/* Typical rise/fall time=3D166, refer Table 1207 databook,
> -	 * sr_osc_freq_target[11:7]
> -	 */
> -	test_mode_send(kmb_dsi, dphy_no,
> TEST_CODE_SLEW_RATE_DDL_CYCLES, data);
> -}
> -
>  static void mipi_tx_get_vco_params(struct vco_params *vco)
>  {
>  	int i;
>=20
> base-commit: 93ee1a2c0f08345ab17c51198f725d4c95984f4c
> --
> 2.33.0.591.gddb1055343