Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] of: remove duplicate declaration of of_iomap()
To:     Randy Dunlap <rdunlap@infradead.org>, robh+dt@kernel.org,
        frowand.list@gmail.com
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210928201214.294737-1-trix@redhat.com>
 <e706d330-87ab-75e6-7118-e9b280039409@infradead.org>
From:   Tom Rix <trix@redhat.com>
Message-ID: <da68bba8-bb38-cb11-df5e-e69fc4848e98@redhat.com>
Date:   Tue, 28 Sep 2021 13:42:41 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <e706d330-87ab-75e6-7118-e9b280039409@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 9/28/21 1:33 PM, Randy Dunlap wrote:
> On 9/28/21 1:12 PM, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> A ranconfig produces this linker error
>
> randconfig .. on what arch, please?
s390
>
>> irq-al-fic.c:252: undefined reference to `of_iomap'
>>
>> The declaration of of_iomap() is dependent on OF
>> The definition of of_iomap() is dependent on OF_ADDRESS
>> These should match.  There are duplicate declarations
>> of of_iomap(), remove of_iomap() and the
>> of_address_to_resource() duplicate.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>   include/linux/of_address.h | 8 +-------
>>   1 file changed, 1 insertion(+), 7 deletions(-)
>>
>
>
> thanks.