Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 10/21] cpufreq: amd: add amd-pstate checking support
 check attribute
To:     Huang Rui <ray.huang@amd.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, linux-pm@vger.kernel.org
Cc:     Deepak Sharma <deepak.sharma@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Jinzhou Su <Jinzhou.Su@amd.com>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org
References: <20210926090605.3556134-1-ray.huang@amd.com>
 <20210926090605.3556134-11-ray.huang@amd.com>
From:   "Fontenot, Nathan" <Nathan.Fontenot@amd.com>
Message-ID: <93e1079f-7450-5c5d-f1f8-7d607899343c@amd.com>
Date:   Tue, 28 Sep 2021 16:24:11 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210926090605.3556134-11-ray.huang@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VE1DOUczbUtEOTJCelltamg3cW1oRDd5cmYrYlRSVXpQU09xNEw5VkdrNnNt?=
 =?utf-8?B?aXVMcUtPQWpqQWR0L2ZCOWxrUlY3bTRwNzFSVXVXTjFDRWZlbzhjMnI0RVhw?=
 =?utf-8?B?a2FsNnJDQjhSekp5Ui81Q3hZcVRmRG1rTmdQUm9jWlBpSjhnSGtMQ01kRnp1?=
 =?utf-8?B?WkhIUFp5ZWNjOFhlcEFqSFFRMEZia2Y5cUg2T21rNlA1NUF0OHBBb0Y5aHd2?=
 =?utf-8?B?c0hjWnRMakFFTnRFWldDbFJ1MXQzalQ2eXlaclJCR0pYdTJyNUF4azNEWXE1?=
 =?utf-8?B?clR0MGJpQ0E4L1ZPWW9nQjg3dUZmZDNLMjFjMXhwMW51OEJhVkl4Rm8wMDJX?=
 =?utf-8?B?V0FjZ2c4ZFlvbzd5ajFTclJwVmFWa1JlUmg0UGdYSGdDZnVLQTh2NzhKN2c4?=
 =?utf-8?B?SHB3QzVKKzdNWGk4QiszRVR4N2d2WTlIaEpNNVEyZ2pwRDdrZE4zTGF3bzA4?=
 =?utf-8?B?NmVyNTIwTjJXNVU3YTJsdzhTNVBCcWFSaGU0WUpscURLZXM0S0VWVmtpM1dY?=
 =?utf-8?B?UDhDdmE3cFNPOHBNWUZnNHdYYm92eTdBOS9idjhveG5vd000TXNsb0F1VGtk?=
 =?utf-8?B?emJVWnhIazBSSDBZam8vWGdsWEU5NitSWll1K1B3QmVpZlhvb291ZEZEdnNV?=
 =?utf-8?B?bHhiZFNIVGwva002VDBhcC9Ma0RLTHRCMDRNUG50TWVzaXRyNHlrVW5wN3dl?=
 =?utf-8?B?T3J2VncyR29NUVVLUDNwZVYzdFczdFRJR1FyOWt2TjUzaVd3MmdOM2diY3Z6?=
 =?utf-8?B?dWJlMWEvbmVGS0k5aU1ZazllWk5XaDJCZVUyVUloVjJkR2hOMFJZUnRha2xP?=
 =?utf-8?B?Yk9WeWVvRXJvVjNncnUwWVJCOVZrLzRsYm9SR1RYM1c4aHhSSHE1TDFER3Bo?=
 =?utf-8?B?WWh0NkFoRTllSUNqeFo4OWVNNFZIUSs1NnFyVUJCSFU1dnJWMGZKQ09Ba2x3?=
 =?utf-8?B?bm1aN3d4eDVsZkpxM0FDQjUvSmVSY3JubHlGMU0rQWpQNG9yWXVjeFZIUFov?=
 =?utf-8?B?YWVNL25iNzRKY211bS9OWU9UVUl5aE45cE52eWRPQklBNzlidXdWYjdWdjhh?=
 =?utf-8?B?aGNoUjlIY2VGN3VJUlBKRmdaRU5XUjlGMEZKazZmSUs4dGpVNWdEV3ZtZXh6?=
 =?utf-8?B?WFhLWjdNYW1DWjZlR2U5bEJiNk1lZmlKRlJPRlVxa2E1eUJQWnByV0NzVU42?=
 =?utf-8?B?VEZ5R09yNjVLYWhEbHZIUWE1S1JUcUVTK3E1RDUwekZBUHlvaHpLeU9hUlc1?=
 =?utf-8?B?OG0wZ0t0Q0RsQktJYUhtc0tRQmRSV3ZCOVhabjh5YVlYVS9PWmVHMU5JaHJS?=
 =?utf-8?B?UFJSU0QxYVRJeHNvbkNEa1R1NmdrNHZ1dy9kdjBIQ1Y2WmpBbjkvRlVmT25G?=
 =?utf-8?B?bkw5aW83UWVWSTdWOUw1UTdXWTM4dHY0YVJyejJwdjVod3BNZEdMM2w0YVlI?=
 =?utf-8?B?eVRnR3NZWHo3ZHVGRThXWTVwQis4NmNvejhVSWJ5K0lKb05wM0lLT0tpdnZC?=
 =?utf-8?B?N3ZFMm1oTmVaR05keGtLVTZRTDdQZTNmUC9sSmlmaUVLUE8ycUpkaVBYRjlB?=
 =?utf-8?B?SEFZaEh0ZlFkZDh2cXFnOFNodFlTS3M3bW5SUElvbWlQYXNuU2VUbGFsb0VZ?=
 =?utf-8?B?bmdEWDZsTSszRzU1L0pnUVMyTkdZN1NCU01JVnpMc0krbGo1aXJqYTZKdWZy?=
 =?utf-8?B?VWlGbEVyQ21BTE51U1U3NHk1UzJUYzNsMWRFemNCcytoNXdZMXFpb0dtSDRo?=
 =?utf-8?Q?vhyclXg9FXftJGET4LZJSuL+JHWG44hqEPPSIki?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9c70040-4b86-4d0b-0e43-08d982c653da
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB4720.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 21:24:17.2959
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hTolr7xLWpPnIlF4V1dtnz9flP2rMYukKx+GgQkoCcNhF4X8LWrlQmPsOM9MORxydCgMmJ8eSamuRemIF9V8aQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4719
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/26/2021 4:05 AM, Huang Rui wrote:
> The amd-pstate hardware support check will be needed by cpupower to know
> whether amd-pstate is enabled and supported.
>

Is this needed?

If acpi_cpc_valid() is false, then the amd_pstate driver would not have been
loaded (see patch 5/21, module init routine will return -ENODEV). If this
driver isn't loaded then this sysfs file won't get created.

Shouldn't the cpupower command just check the scaling_driver in sysfs to see
if it's amd_pstate?

-Nathan
 
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 847ba00e3351..74f896232d5a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -517,6 +517,19 @@ static int amd_pstate_cpu_exit(struct cpufreq_policy *policy)
>  	return 0;
>  }
>  
> +static ssize_t show_is_amd_pstate_enabled(struct cpufreq_policy *policy,
> +					char *buf)
> +{
> +	return sprintf(&buf[0], "%d\n", acpi_cpc_valid() ?  1 : 0);
> +}
> +
> +cpufreq_freq_attr_ro(is_amd_pstate_enabled);
> +
> +static struct freq_attr *amd_pstate_attr[] = {
> +	&is_amd_pstate_enabled,
> +	NULL,
> +};
> +
>  static struct cpufreq_driver amd_pstate_driver = {
>  	.flags		= CPUFREQ_CONST_LOOPS | CPUFREQ_NEED_UPDATE_LIMITS,
>  	.verify		= amd_pstate_verify,
> @@ -525,6 +538,7 @@ static struct cpufreq_driver amd_pstate_driver = {
>  	.exit		= amd_pstate_cpu_exit,
>  	.set_boost	= amd_pstate_set_boost,
>  	.name		= "amd-pstate",
> +	.attr		= amd_pstate_attr,
>  };
>  
>  static int __init amd_pstate_init(void)
> -- 
> 2.25.1
>