Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp100586pxb; Tue, 28 Sep 2021 16:31:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRomXl8aAcDw+lgz58BhNgqUrNO7DNq3N4EqICTb2t17ctNQqMzW/58tM9tNFexnhdxcWJ X-Received: by 2002:a63:dc42:: with SMTP id f2mr6887895pgj.152.1632871863290; Tue, 28 Sep 2021 16:31:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632871863; cv=none; d=google.com; s=arc-20160816; b=hXUXyN/L0c8BC1skG8xdi0rycppW0YVfJ83g5C4LfmOhxUlGJKySGBFgbASTwQy7az fgGZFpau485vIEMi/RhJzw5YU9oZTa1qD7C9+J1e4odI7IFzlCVqB8Sx2OW8ljS61vpc 0aAx6RLEH1IBg7P9C8O2Mqkjp7GbsvdBRZBCvH7T52xtYySHReQyVQcf6wLnlfhuNdgg Tzr+zPaKHTQr+Ra+uAnLD+TTVtcrJObO+g0Jvb0Ntkwluga9435o3wwuRxCRZPgbzT2s IGk7bKVz8ZBEY9+yW0U3g1zC/Yus0MFY95xt/bMi3bRguBOLXATR+n3ta/XRHZvc/OQ3 g2iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=f3SkLMXovVJSfyUKmjSwWwy49/gB4SUHOeCUFHsbqBk=; b=yztW/a+GWNpKy8CyDKoLuI4dgPcLBSZPzMLir/1DlrYAa9ib7DRQD8lxZOdjEvOkU2 qnsMdoIMLDmtv1+KgFwlJcLUrYmWcz2SL2eRZsVEMQkRK7XFILag1kgcjGSj0lzonp11 ZBpgiQOZSy52UznRqo3+Cggq/8Y37ghi6S9fb9IF3MEMsG9/TUqrWqoxLlKBr1McSelH H1xOsR2a7v9xjX1YkDa8+n/XDraWap/d6uwectp6+dlyCzuZdlKdW4Vvr3r6Nt6pcEyA EheRk3jcXuvLgVJJU3hhZZNPHcWDHoNiJGsfip753xDj5hjoKw91vC4i5gNEoaXKXJns Z5Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EUNbeeGp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 2si665869pfu.58.2021.09.28.16.30.49; Tue, 28 Sep 2021 16:31:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EUNbeeGp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243276AbhI1XaG (ORCPT + 99 others); Tue, 28 Sep 2021 19:30:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:54266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243273AbhI1XaF (ORCPT ); Tue, 28 Sep 2021 19:30:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DB70761368; Tue, 28 Sep 2021 23:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632871705; bh=Aj0F5LPnVcUuzJUSV8yvbiS/m7CuZnciB2S9wM6oAZc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EUNbeeGpLdIaiqtvxWR9rGTEdh3mG9fPw/efsCNs7w80S50R4767T57C+aLN3Mo+1 4wT96+eP+DIUZWGRX8so7Y+H7WxBL7eWBEopao1HLx+RsWJKS60k3z0em5vFg/keLP gbGjeQVZYyWmAeGo/PN+multiD+4dOdccby883Z9dKWOSjLg2JDagKIT+N7/Hb7UZO 36Gr0e7gHa5dH4AMIPYRngDBEmYTJQUsao6QzTVLwz8jOi2TBYwqtOCQKmmefGjeWx 8Zp9KvPUxpj8oootVAkj9KmlXqMeLAHlCO2BxdgPqpEJYH5Z4Jpy9LECU18T72q1tx zEz2mM68ooVKw== Date: Tue, 28 Sep 2021 18:28:23 -0500 From: Bjorn Helgaas To: "Rafael J. Wysocki" Cc: Linux ACPI , Linux PCI , LKML , Andy Shevchenko , Mika Westerberg , Ferry Toth Subject: Re: [PATCH v2 0/7] PCI: ACPI: Get rid of struct pci_platform_pm_ops and clean up code Message-ID: <20210928232823.GA748352@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1800633.tdWV9SEqCh@kreacher> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Ferry] On Mon, Sep 20, 2021 at 08:52:19PM +0200, Rafael J. Wysocki wrote: > Hi All, > > As explained in the changelog of patch [2/7], using struct pci_platform_pm_ops > for ACPI is not particularly beneficial, so it is better to get rid of it and > call the functions pointed to by it directly from the PCI core. > > However, struct pci_platform_pm_ops is also used by the Intel MID support code, > but it is actually better to call the MID PM function directly from the PCI > core either, which is done in patch [1/7]. > > After these changes, patch [3/7] removes struct pci_platform_pm_ops and the > rest is just cleanups and some code consolidation on top of that. I like these a lot. Not sure exactly where everything is after the conversation with Ferry. Let me know if I should be doing anything.