Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 28 Sep 2021 17:41:04 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Mianhan Liu <liumh1@shanghaitech.edu.cn>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] net/ipv4/datagram.c: remove superfluous header
 files from datagram.c
Message-ID: <20210928174104.4c05448e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210928174943.8148-1-liumh1@shanghaitech.edu.cn>
References: <20210928174943.8148-1-liumh1@shanghaitech.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 29 Sep 2021 01:49:43 +0800 Mianhan Liu wrote:
> datagram.c hasn't use any macro or function declared in linux/ip.h,
> and linux/module.h.
> Thus, these files can be removed from datagram.c safely without
> affecting the compilation of the net/ipv4 module
> 
> Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn>
> 
> ---
>  net/ipv4/datagram.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/ipv4/datagram.c b/net/ipv4/datagram.c
> index 4a8550c49..2dc5f1890 100644
> --- a/net/ipv4/datagram.c
> +++ b/net/ipv4/datagram.c
> @@ -8,8 +8,6 @@
>   */
>  
>  #include <linux/types.h>
> -#include <linux/module.h>

If we remove this one we need to add an include for linux/export.h

> -#include <linux/ip.h>

This indeed looks unnecessary.

>  #include <linux/in.h>
>  #include <net/ip.h>
>  #include <net/sock.h>