Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp163709pxb; Tue, 28 Sep 2021 18:19:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAiEvpmK1FN6iOdb8cELyS0VfX3cahOpuo/eoKU15kVhMib+PrGODxre1HBo8mruieoCiX X-Received: by 2002:a50:81e4:: with SMTP id 91mr7675621ede.241.1632878342301; Tue, 28 Sep 2021 18:19:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632878342; cv=none; d=google.com; s=arc-20160816; b=KlymtRUtfs4zJkjtdWnDiMOMx+5xKsZ0LJ7uZvR1dqXvtLrSSQzf9xAI9u39iTkr3d EZ85l1kPbgyFSu16tGRp3uwt/E8cuoLxFkowVVAGNCOf/DdNhjIHlsDmhDH56T5E8Etq nuEJH179BwKYv+4uzNQytXGGqaHLx35W+JmX1p5V3KCE+2r+ODUF6Ei++nC0FbGN13Pm dnRrNKPQbU/mOK48G1+nZ48OdzHatSjTUPJylVzWCvwJYEo6d+xRr7ZflRBP/2rsceBY g+8auK3P4jpYkKai9Wwmve1ER6VdmjdxxKzBEEIlRVxSw24b2kFH6qlvBWiEhOCJQIFX 8QrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/QHdq/xpL6MadWegD1fgxPY4AA7olF7PsZryGBD23lw=; b=QR9vNrCCWLyuaWaFBkaeZPU5hDGtXj53yvueCJmDNT66mD9G0/H9Ev7y8RUhu9a2Dq PF7TcBB4TgSrU4fV5xKjNl48jJjwK9IjKguZulpfqc/WO8zS3ji0JZY31jQ7WCbJ/LqW OrHjf5W7rUw6c8nrDIXMr3xw2b9kx+xMo6f0/8xuraGWHQYlC3KjrM8p+70fy6vl45Ew WtqVKkd43OgTkzUVtG8OKwxYaPBVTXNVeO4bnN4G5NnWVLkF36atZ7aAHGcJGsXTAa/n ISghoXaHhEFa25VFsb+H5RYWMQqVIe1p6DeSLHFeYSnCdHQgrEH1iC1VXOIdemu+ec6V ZXeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z39si1021863ede.176.2021.09.28.18.18.27; Tue, 28 Sep 2021 18:19:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243626AbhI2BSk (ORCPT + 99 others); Tue, 28 Sep 2021 21:18:40 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:31063 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243615AbhI2BSj (ORCPT ); Tue, 28 Sep 2021 21:18:39 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 18T0uCkR095684; Wed, 29 Sep 2021 08:56:12 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from JammyHuang-PC.aspeed.com (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 29 Sep 2021 09:16:56 +0800 From: Jammy Huang To: , , , , , , , , CC: Subject: [RESEND PATCH] media: aspeed: add debugfs Date: Wed, 29 Sep 2021 09:16:53 +0800 Message-ID: <20210929011652.1709-1-jammy_huang@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 18T0uCkR095684 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To show video real-time information as below: Signal| Resolution| FRC | Width Height| Lock| 1920 1080| 0 Frame#| Frame Duration| FPS | Now Min Max| 496| 26 25 30| 40 Signed-off-by: Jammy Huang --- drivers/media/platform/aspeed-video.c | 100 ++++++++++++++++++++++++++ 1 file changed, 100 insertions(+) diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c index 8b3939b8052d..5b98dc7b7b15 100644 --- a/drivers/media/platform/aspeed-video.c +++ b/drivers/media/platform/aspeed-video.c @@ -21,6 +21,8 @@ #include #include #include +#include +#include #include #include #include @@ -203,6 +205,14 @@ struct aspeed_video_buffer { struct list_head link; }; +struct aspeed_video_perf { + ktime_t last_sample; + u32 totaltime; + u32 duration; + u32 duration_min; + u32 duration_max; +}; + #define to_aspeed_video_buffer(x) \ container_of((x), struct aspeed_video_buffer, vb) @@ -241,6 +251,8 @@ struct aspeed_video { unsigned int frame_left; unsigned int frame_right; unsigned int frame_top; + + struct aspeed_video_perf perf; }; #define to_aspeed_video(x) container_of((x), struct aspeed_video, v4l2_dev) @@ -444,6 +456,18 @@ static void aspeed_video_write(struct aspeed_video *video, u32 reg, u32 val) readl(video->base + reg)); } +static void update_perf(struct aspeed_video *v) +{ + v->perf.duration = + ktime_to_ms(ktime_sub(ktime_get(), v->perf.last_sample)); + v->perf.totaltime += v->perf.duration; + + if (!v->perf.duration_max || v->perf.duration > v->perf.duration_max) + v->perf.duration_max = v->perf.duration; + if (!v->perf.duration_min || v->perf.duration < v->perf.duration_min) + v->perf.duration_min = v->perf.duration; +} + static int aspeed_video_start_frame(struct aspeed_video *video) { dma_addr_t addr; @@ -482,6 +506,8 @@ static int aspeed_video_start_frame(struct aspeed_video *video) aspeed_video_update(video, VE_INTERRUPT_CTRL, 0, VE_INTERRUPT_COMP_COMPLETE); + video->perf.last_sample = ktime_get(); + aspeed_video_update(video, VE_SEQ_CTRL, 0, VE_SEQ_CTRL_TRIG_CAPTURE | VE_SEQ_CTRL_TRIG_COMP); @@ -600,6 +626,8 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) u32 frame_size = aspeed_video_read(video, VE_JPEG_COMP_SIZE_READ_BACK); + update_perf(video); + spin_lock(&video->lock); clear_bit(VIDEO_FRAME_INPRG, &video->flags); buf = list_first_entry_or_null(&video->buffers, @@ -760,6 +788,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) det->width = MIN_WIDTH; det->height = MIN_HEIGHT; video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; + memset(&video->perf, 0, sizeof(video->perf)); do { if (tries) { @@ -1517,6 +1546,71 @@ static const struct vb2_ops aspeed_video_vb2_ops = { .buf_queue = aspeed_video_buf_queue, }; +#ifdef CONFIG_DEBUG_FS +static int aspeed_video_debugfs_show(struct seq_file *s, void *data) +{ + struct aspeed_video *v = s->private; + + seq_printf(s, "%10s|%21s|%10s\n", + "Signal", "Resolution", "FRC"); + seq_printf(s, "%10s|%10s%11s|%10s\n", + "", "Width", "Height", ""); + seq_printf(s, "%10s|%10d%11d|%10d\n", + v->v4l2_input_status ? "Unlock" : "Lock", + v->pix_fmt.width, v->pix_fmt.height, v->frame_rate); + + seq_puts(s, "\n"); + + seq_printf(s, "%10s|%21s|%10s\n", + "Frame#", "Frame Duration", "FPS"); + seq_printf(s, "%10s|%7s%7s%7s|%10s\n", + "", "Now", "Min", "Max", ""); + seq_printf(s, "%10d|%7d%7d%7d|%10d\n", + v->sequence, v->perf.duration, v->perf.duration_min, + v->perf.duration_max, 1000/(v->perf.totaltime/v->sequence)); + + return 0; +} + +int aspeed_video_proc_open(struct inode *inode, struct file *file) +{ + return single_open(file, aspeed_video_debugfs_show, inode->i_private); +} + +static const struct file_operations aspeed_video_debugfs_ops = { + .owner = THIS_MODULE, + .open = aspeed_video_proc_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + +static struct dentry *debugfs_entry; + +static void aspeed_video_debugfs_remove(struct aspeed_video *video) +{ + debugfs_remove_recursive(debugfs_entry); + debugfs_entry = NULL; +} + +static int aspeed_video_debugfs_create(struct aspeed_video *video) +{ + debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL, + video, + &aspeed_video_debugfs_ops); + if (!debugfs_entry) + aspeed_video_debugfs_remove(video); + + return debugfs_entry == NULL ? -EIO : 0; +} +#else +static void aspeed_video_debugfs_remove(struct aspeed_video *video) { } +static int aspeed_video_debugfs_create(struct aspeed_video *video) +{ + return 0; +} +#endif /* CONFIG_DEBUG_FS */ + static int aspeed_video_setup_video(struct aspeed_video *video) { const u64 mask = ~(BIT(V4L2_JPEG_CHROMA_SUBSAMPLING_444) | @@ -1708,6 +1802,10 @@ static int aspeed_video_probe(struct platform_device *pdev) return rc; } + rc = aspeed_video_debugfs_create(video); + if (rc) + dev_err(video->dev, "debugfs create failed\n"); + return 0; } @@ -1719,6 +1817,8 @@ static int aspeed_video_remove(struct platform_device *pdev) aspeed_video_off(video); + aspeed_video_debugfs_remove(video); + clk_unprepare(video->vclk); clk_unprepare(video->eclk); -- 2.25.1