Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <87sfxoai2l.ffs@tglx>
In-Reply-To: <87sfxoai2l.ffs@tglx>
From:   Lai Jiangshan <jiangshanlai+lkml@gmail.com>
Date:   Wed, 29 Sep 2021 09:26:10 +0800
Message-ID: <CAJhGHyBwVLpcWoizJaMvQUFhAO_rz4CBQ1=D8hZ2iAadruh7WQ@mail.gmail.com>
Subject: Re: sched: Remove pointless preemption disable in sched_submit_work()
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, Peter Oskolkov <posk@posk.io>,
        Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 28, 2021 at 10:31 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Neither wq_worker_sleeping() nor io_wq_worker_sleeping() require to be invoked
> with preemption disabled:
>
>   - The worker flag checks operations only need to be serialized against
>     the worker thread itself.
>
>   - The accounting and worker pool operations are serialized with locks.
>
> which means that disabling preemption has neither a reason nor a
> value. Remove it.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  kernel/sched/core.c |    2 --
>  1 file changed, 2 deletions(-)
>
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6327,12 +6327,10 @@ static inline void sched_submit_work(str
>          * requires it.
>          */
>         if (task_flags & (PF_WQ_WORKER | PF_IO_WORKER)) {

Hello

The comment about preemption above this if branch and wq_worker_sleeping()
needs to be removed.

Thanks
Lai

Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>

> -               preempt_disable();
>                 if (task_flags & PF_WQ_WORKER)
>                         wq_worker_sleeping(tsk);
>                 else
>                         io_wq_worker_sleeping(tsk);
> -               preempt_enable_no_resched();
>         }
>
>         if (tsk_is_pi_blocked(tsk))