Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Len Baker <len.baker@gmx.com>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Hannes Reinecke <hare@suse.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        linux-hardening@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: advansys: Prefer struct_size over open coded
 arithmetic
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq17df0gkfw.fsf@ca-mkp.ca.oracle.com>
References: <20210925114205.11377-1-len.baker@gmx.com>
Date:   Tue, 28 Sep 2021 22:55:12 -0400
In-Reply-To: <20210925114205.11377-1-len.baker@gmx.com> (Len Baker's message
        of "Sat, 25 Sep 2021 13:42:05 +0200")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FLFE871mN/trFFgPgXOeWOY86+4QUQWBgKUKUTdWj99U6vgG0muEJQtsXDIF?=
 =?us-ascii?Q?9IoxbNdTWA/7OHj27a5SlnwhDMObTgWZqOIp7wAw/ASN2X/Rr2xvD1O6jXCG?=
 =?us-ascii?Q?zL2lHGk4pWG4gITjqVpJfCklgNPU6P/5MeMhGDSFgv2t2HejV+yAAcaFilpg?=
 =?us-ascii?Q?L3Ov6x1KYHF8aW2fiheJ3rX/ddZ0/rUwNYlJRO2FKbtc5cm7xk/hOnnzyCBO?=
 =?us-ascii?Q?0VxGFNzWKZdvezdtZyKNy9NF1CivJ9aQ0qA7EQefg/RAZFnExcoqtO/xQKdQ?=
 =?us-ascii?Q?bjXGx40DTHmy/UIqbykrJoGOiazo3f1I8jRjF2po0w/bcV2imn2SIjpwfQsQ?=
 =?us-ascii?Q?yKY3Z8vIkrUIDjC8aPJ7dG6BQFY4A9c86fqm4Sq75gJNZ23mHTfS5/FxzgFG?=
 =?us-ascii?Q?XLbG9qJP6LzM8LJ4spM+NYMKCPx8RkZodmQV5Kx/fdD/Sxu8l4TzSRs31kQS?=
 =?us-ascii?Q?5KUZ3SCfUXY0a7Z7A+AmaEqR+TP2oKYRzKCPz41BclDPs25/EKQ0kHbTgtA/?=
 =?us-ascii?Q?BwdB8C211GSAwbtaEjLWHcgP1YAItKb+eWyvGxllFAgRPXbjuJW9GZzKPdD8?=
 =?us-ascii?Q?77ZAyHT5JUqS1Jy46OFJi6bJC5Fviayz8/uVsVemL0NvnyWe0mkuHd6EXYuF?=
 =?us-ascii?Q?4F3+6NU63d+n9UC19sypEyhLcFrY6iDy64n4TpKi14jiF34JxVk1SP8UEaoH?=
 =?us-ascii?Q?cX9LDqvHzqlTR3dNVzfpEdLWIXw1DbZfnm6bvFfnPt/r+fQZTogjACVunep2?=
 =?us-ascii?Q?Kmd8lmwSChGF/T3Ebc+m4nPIg3pgp8+Rc7aVlP2BtmOMNbhac0PWkBwns2LA?=
 =?us-ascii?Q?tKll9/mcA7he39stU3sL1viJHyrA2nrg04wMKjxFpL9YQCKSgiWWHuOwztma?=
 =?us-ascii?Q?5MPaOwTlveXEG42eoAZCrzhjBfMdZ0kK3ZX/2PtnJ+YI1Y+cw9FBnXVleJhf?=
 =?us-ascii?Q?WREPp+scBoBV17x89uw2WTquhKJUE6R+xEe1+/kdFA+/WwMBVgzjuG+M/Cdr?=
 =?us-ascii?Q?1JL6XS/QY2YPSu+c99Uw+dEtP8LV3YVgmGy9Wj+I3imW9aOX7Pe2S3gx+SWp?=
 =?us-ascii?Q?zhsQANdG5GT6ZvTuBRQvixwrLBsPK0dwhDhzjNH51hIia6Mq4R7HnqFOqsYY?=
 =?us-ascii?Q?iPYk6Odw/hQh+8kFYl+ZSuLs11qpxu2ZgF20cLn6kKYWnsTguX+aROXwHW2k?=
 =?us-ascii?Q?pk0UC/DDt1pmYNh+LCNraEPcAHg4xKyvGzmlB4sIdy37FJkgZlyreyoV7TbD?=
 =?us-ascii?Q?dTM22lx1J6pFHvJKrjN6AS45fax0HpQPG/k+rFeM28LaoyVpP4rpulRgFq+I?=
 =?us-ascii?Q?h8w+R0b/5v0rj6Jg4gdesANq?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5401e35a-617b-4abf-a3ef-08d982f4902b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 02:55:15.3081
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jOVGto/PovN1/MKutMyJUvgWAmwBA0uwpKFkNt5JvcFI8qbUr4ScUNtZZCtbFiD0sL40h3WpcDqoYiIi5x23yMOh1DR3gtOcvsgvrcwaOQM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4520
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10121 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 mlxlogscore=775
 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2109290014
X-Proofpoint-GUID: ygi3cYwggKQ9HK7N3fJveg58Ai1HgSQz
X-Proofpoint-ORIG-GUID: ygi3cYwggKQ9HK7N3fJveg58Ai1HgSQz
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Len,

> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or
> similar) function arguments due to the risk of them overflowing. This
> could lead to values wrapping around and a smaller allocation being
> made than the caller was expecting. Using those allocations could lead
> to linear overflows of heap memory and other misbehaviors.

Applied to 5.16/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering