Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Adam Radford <aradford@gmail.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        James Smart <james.smart@broadcom.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        Michael Reed <mdr@sgi.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] scsi: qla1280: Fix a function name in comments
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1v92kf5pj.fsf@ca-mkp.ca.oracle.com>
References: <20210925125324.1760-1-caihuoqing@baidu.com>
Date:   Tue, 28 Sep 2021 23:12:43 -0400
In-Reply-To: <20210925125324.1760-1-caihuoqing@baidu.com> (Cai Huoqing's
        message of "Sat, 25 Sep 2021 20:53:21 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O5pr3pWqzvV2C9FK3lWQrJb7YMwT1my+QdNNGC6cu14jKh2m1V0C1UnMVdQt?=
 =?us-ascii?Q?dpjVfUC5nURPJth6J74miT6PcYf8N5Xhb0CHu9Y+Vso71O2FeZFy9IEJ4CmN?=
 =?us-ascii?Q?sM9hvtTkRGugrS+dUC0Qov8m/e/Eovx63soOhGKM/j9/rZCcWKDzcAApYVpB?=
 =?us-ascii?Q?18B+6PSxRE1TC9tVktmumC1GWG8FPdwKFhWYwcMOgwABUAtLq7Llsxibf+Pm?=
 =?us-ascii?Q?9XMXJEXiJwY22tIN25IfhJoOp3zJ1nWuVExeIcVDz4ZkofVFAnuzRuTGU6wf?=
 =?us-ascii?Q?wdqe99rrfOhMeFsGCxm/nknAMU1eBcLzqq9tJwt+spm9nWv4AT7+tmxtIybC?=
 =?us-ascii?Q?twDrFR1LGORovxQToQxdYyWc5bWrp6OD5jjMF2/SaKCfHpe1yNaPuRtoiwk/?=
 =?us-ascii?Q?YsniMWfaNPqkaBsiDEhOSfZfCELULgUWAWLbDFvag8x4S5ChasH+K2S7lCR2?=
 =?us-ascii?Q?WpcGpMygGR/zMnCjbT9ukrdla/EKqxkg2xdTxQq7PDXS9h+xHep2iuxBNr0w?=
 =?us-ascii?Q?L0WGnd1taLGyd6bjijiOUNmxy20OPWE1UsUnqtopndDKI6GFXHfa3is9HvYC?=
 =?us-ascii?Q?Cjsf3tyHyiYgKX55Mw8r/bha93EugYKsEhUQckb7z2BCQGEGe9ieztM8yHjK?=
 =?us-ascii?Q?76tGc/MG+UcwSbSXpI1Y1UlMvS56Y94WZy7EOP4rCqc8wr35ew6uRI2qscc3?=
 =?us-ascii?Q?DoARwr9fraYltD5KwTTUgupH7nUfINIY5mVXhlSZjNTVmg1biN8JJK21dsX0?=
 =?us-ascii?Q?SuH0V4M3a+TLR373OSOBlGYhf0oanFVkU05Y/020rbPDLRu1EpwaOetZL4mt?=
 =?us-ascii?Q?WJ8rjK+DLFUxecWCDLpTMVBpPgN0PRW9PcE8XA9cXY0yCuaMqCYSHscdpZp9?=
 =?us-ascii?Q?4A+qrqWuJDQyDM6NpsArMFORBJityfLqS3TK4eHLOmEGhrHf0IYHF30pU8e5?=
 =?us-ascii?Q?TCHkTvj5clvputau2iJROVf7lkASsLrvQv8q0oTrkKTcCVW6y+Lg6RHSIUQp?=
 =?us-ascii?Q?u9URFUL0YCmXjArcr4nk5SEtaWHyj5Yck3tjrmydGxBnq/INMrr6z/0HGr6r?=
 =?us-ascii?Q?0U6G2veL2INlE7xPFJc7rzYABkQk36oAcwFyQalke8oAX9hnmoJ1sn9fzY1T?=
 =?us-ascii?Q?e6Zni1BZoKbJNabln2yvgxQCNftKR47ffyrG930Nmm21Z7KLl8JKvD4gSimh?=
 =?us-ascii?Q?OMHrks8VgNWbz9bsG2YBssEydga+wg/rUJ/79gsbbWDjIDMOhYOUCcwByg2S?=
 =?us-ascii?Q?OskS8yg0+3NYUZ7JLmDVO9ektlIe81ulrHW4pETtDfutmk0MJUsxFDIeGegv?=
 =?us-ascii?Q?BqoJPE+AFdp2PUvpwal+J6Ln?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d44e86aa-c5a2-42f0-caef-08d982f70224
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 03:12:45.5428
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0STqOaBWM5/QTeFr/DsRp8lfrQN3dJdG16nSye/KCBwkoeeIT2etQExUqOycTHWMm5CmOmbbDVgFmkfEdQDT88et5B1ezyz4IKOV/FKrfrg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4439
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10121 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2109290017
X-Proofpoint-GUID: k2Au49o9MneC4zE-7vbTujXjp3qkOE0X
X-Proofpoint-ORIG-GUID: k2Au49o9MneC4zE-7vbTujXjp3qkOE0X
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Cai,

> Use dma_map_single() instead of pci_map_single(),
> because only dma_map_single() is called here.

pci_map_single() was the appropriate interface when the change log entry
was written. And the original entry accurately describes the change that
was made to the code back then. Whereas your proposed fix does not.

There is little benefit to having change logs in drivers in a modern
context. However, these entries predate git history and should therefore
be preserved.

-- 
Martin K. Petersen	Oracle Linux Engineering