Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     dc395x@twibble.org, Ali Akcaagac <aliakc@web.de>,
        Tong Zhang <ztong0001@gmail.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Jamie Lenehan <lenehan@twibble.org>,
        Oliver Neukum <oliver@neukum.org>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v1] scsi: dc395: fix error case unwinding
Date:   Wed, 29 Sep 2021 00:20:16 -0400
Message-Id: <163288294652.9370.4294891378413263010.b4-ty@oracle.com>
In-Reply-To: <20210907040702.1846409-1-ztong0001@gmail.com>
References: <20210907040702.1846409-1-ztong0001@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEJweDVoTGxJcmRJN014RUNiTUdGbUdRS0JLcmFtMnlSSEJhekVZK1FxSi9i?=
 =?utf-8?B?eGQ5VVdpUFdWNzgzdjc3bnlZUFdkMjhyNDgvd081bDNIMEFReGZmNFIyWkZs?=
 =?utf-8?B?bDJEN3pJcGc5MDlwbzc4Vis5OFpQTzQ5STB1eW5pSU5zUm5Wdzl5ck91L2dm?=
 =?utf-8?B?cUdsY053eUNyUzl4YlZPSlZxdUZ4UVRHV3liYjltWnNBcHNZLzY5aDNBVXZK?=
 =?utf-8?B?Y3F6VndPa1QvSnRiTTQyZmpRY0JCZEpTOERzcTlCTmhvREhMYS9xclJFOUdz?=
 =?utf-8?B?ekU0MGo4bnVjOUJabHkzcHRLd2ZaNklmWlV5eiszVlFtTWw1MzBXSjEzL3JV?=
 =?utf-8?B?OHdzZlhjL09QYUxvbVpPVUxHSnZ5S0FJTzNjR09CNjRoOVROWm1ISjFPcUV2?=
 =?utf-8?B?d3hBVis5NGpZQ3EyOFJsaHVmcEFrKzQvUy9sZlNuWXg1L2ZSejdQK1NVWUFP?=
 =?utf-8?B?U0ZDVGpsUEM2aFJNdlFpdVBGU1o4SXEzczVkRGM1UjJCM1JxSEhTYklONXZ2?=
 =?utf-8?B?ck8vTVhZYjR4WlhVMzhmTWN5NWIvY2ZvN3NHVkFyM0dNbENWU01aMERuUXpy?=
 =?utf-8?B?VTJRMmMycnd1TGcyd3FOeFdPSktGcHJZVWowZW1ybGxId3BwZVNYeGdxQlFz?=
 =?utf-8?B?UXpPZHFLc0xWaUw1Y3h6Q1BidyszcW9pZVE4dE9UUk9LalBYb3JnVUNQN0F6?=
 =?utf-8?B?aGFoRGpBWTVucnV6emlaNkdOeHBLZjJlYnMvWERBcm1URDQrNUJtUFJoWDNv?=
 =?utf-8?B?empCMFlhL0JZb3RWZC90eU4vMFcwU1FoblRpaTAwSUJaVWxDMEhuUVUwZ2NF?=
 =?utf-8?B?Vk5OV01FS1QyTWpSQjA2WUFOL3ZnQ2lnWGdlZncvQWNGL1MrYUI0NzJCTjVE?=
 =?utf-8?B?ZlZ5ODBVOFo0RnBrL2QxMEVRZGNiQjFCeVFuQVBkTkpLa2ZqbVU0WWFKbTIy?=
 =?utf-8?B?Z21RMEppV1N5RitGM3JXZTMraG95TWJsUDhmSnlZOUt3S2c3clJlRUNuRVdr?=
 =?utf-8?B?YStVZmVKRG5ndHUyd24zUHIvYkhHcHFIcVhwbG54ZnRRZ3g3djdoRERDQ0lM?=
 =?utf-8?B?VUx5VmlDQVlQcFlKc3h1eU1XU05BdE1VQWZ6VzA2ZVVRMFU0SXZreGpkK0tI?=
 =?utf-8?B?a2d2dUVaT1VwZ3FtU1Npd1UrbVlXNGRUeHFkYUxPNzdVcnFyWHBaeFQza1Ay?=
 =?utf-8?B?ZXJjcnlzTTBpV3IzN0ZnRGVnTGVuakc3UE1sVXVXZVJXZHRQdTF6MGt3NzBU?=
 =?utf-8?B?YjhRSVNMS0ZpZzVqZGllT1NwdjM1aHpPbDhLRm85d2FzRFErYUxzNHF5Vllq?=
 =?utf-8?B?VEtUTTVaM1hNK0drTXNqYWV1MU93dlFhbFdtbUE2czJ0MGIrUlBNRVl0WWlx?=
 =?utf-8?B?enZDTWQ2MHdIVy9MT1F6STlKRXRTcDdoVGlFQWpUOTZUYmlXN21XR3hwR2Fi?=
 =?utf-8?B?TzYvSUljYUFnV0x0MjIyVjlEMVdtV0V5aE1rZXB2d3FZQmVIeDh2eHJIME9Q?=
 =?utf-8?B?ZHBqL1dWemVUS2toTlp4TzY3c1BVdTJwejVCRjJiMmNFaFhxc1JkNEFtTCtU?=
 =?utf-8?B?Q2U1cDBYVEtCeTNNWlU1K2RLM3labllLU2toRGxkSG1FTnNGWi8vQWFnLzdV?=
 =?utf-8?B?ZXBiQXIya0lKRzJWdU9DTkxnblRhYXQzODR0Q1ZEUStzV3ZNektyQWduUjBh?=
 =?utf-8?B?RUlyQ1VtNDJaTEtwbmZ0WkFSSkNZVXBlUUowdmNxR2pqQ0pHUmZRaUVVaG5X?=
 =?utf-8?Q?2I2C2cdU2tcl6de28dS0Le3Ti+3KR7CrnvqFJqA?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30ca2527-7af9-4233-056f-08d98300743e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 04:20:22.4748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YOy3H+1Y3N6DETDNbNnF7ZxAVvLHvERhr607wnwoTYZBtRFqPY74nWTdW0wyRnqiDq8nNJZeGV2zYl3K3GZXBc2Bh0snQ9hZUE6RlQVwGhY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4551
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10121 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2109290025
X-Proofpoint-GUID: PuVtTKJqTTF9NSRo4aWoa4nE-xt9N6O0
X-Proofpoint-ORIG-GUID: PuVtTKJqTTF9NSRo4aWoa4nE-xt9N6O0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 6 Sep 2021 21:07:02 -0700, Tong Zhang wrote:

> dc395x_init_one()->adapter_init() might fail. In this case, the acb
> is already clean up by adapter_init(), no need to do that in
> adapter_uninit(acb) again.
> 
> [    1.252251] dc395x: adapter init failed
> [    1.254900] RIP: 0010:adapter_uninit+0x94/0x170 [dc395x]
> [    1.260307] Call Trace:
> [    1.260442]  dc395x_init_one.cold+0x72a/0x9bb [dc395x]
> 
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: dc395: fix error case unwinding
      https://git.kernel.org/mkp/scsi/c/cbd9a3347c75

-- 
Martin K. Petersen	Oracle Linux Engineering