Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Sep 2021 09:22:26 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, kuba@kernel.org, buytenh@marvell.com,
        afleming@freescale.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com
Subject: Re: [PATCH v2 2/2] phy: mdio: fix memory leak
Message-ID: <20210929062226.GR2083@kadam>
References: <2324212c8d0a713eba0aae3c25635b3ca5c5243f.1632861239.git.paskripkin@gmail.com>
 <55e9785e2ae2eae03c4af850a07e3297c5a0b784.1632861239.git.paskripkin@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55e9785e2ae2eae03c4af850a07e3297c5a0b784.1632861239.git.paskripkin@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ESkR/2FaC8dshSDHpShN/MqW/55/4ldrn+REMGRzStJth1C1V6bFYT6H//fh?=
 =?us-ascii?Q?QQOKRBuFBT2X1skOE5WUWtVPkv6BBg9kBRV1ImekVtHoZmRQmcIPr49o5HhB?=
 =?us-ascii?Q?QkW4/o97mrt94tPAMm7KiUoWuTQXU/nYwUzrCjUvsyOMeOYfiPzsMibIGQsQ?=
 =?us-ascii?Q?tvWsIZmu8eR0MbwFUX3Xd21/ma7LczfolGBTkcUGtO9d/TRBeZPHtkTqvuw/?=
 =?us-ascii?Q?1p9gSmsssrs5gI8sosmIIS5Azt9rSK2g9kwoT5GXpwL8OEcbyWx549JoxUNM?=
 =?us-ascii?Q?Vio3aOPysv+spC583KdZz0RmsGN8wTX7fFUpPXTKoiZfrn0zpnwTnEPyB1OK?=
 =?us-ascii?Q?08rBA6gfpqGM3ORH6LcbckJmAB1vyARZOm7B/1nM93iXwghHeRDHbcKCVaE7?=
 =?us-ascii?Q?+2cqm6FQ9hl8/cHhtX+WhdMsjmfKAC9eZmpj4ZuBSyUCAYexTBsbF3Gffyx6?=
 =?us-ascii?Q?EnJFrtJXm5ia8FDjUYptO9cm0/DKXW66iyexs8PtFQCdoVzMRD8yDHsA4NYi?=
 =?us-ascii?Q?LL8N783+h9u5yM2psWkKzeZsPgVjxkgifmKT+E8s3+lpAcbsDAfAmHeRn7yk?=
 =?us-ascii?Q?7/Rq4WqOaoAfKDM9bWVZzEHgYfCVMoFpM5vgYO1e+CWhJj+8KOD2L8DbriUI?=
 =?us-ascii?Q?qnxwFi8LtzrEfW2M4Rp0HMClta72ofnSAqYF9iKCucZJlpnGXT9tMp0kHx0j?=
 =?us-ascii?Q?aGJ8YcuUMqW4aKW9TkQExeYclaFXKT3H3f8GOTUVy1MhS13lW3UiKNUEYSG5?=
 =?us-ascii?Q?QAZhYBODVxy40KclbzaAnmZ1tZ2Tmt0s43aZu/q27p27gcbPdg5qOesUOH9i?=
 =?us-ascii?Q?dnPu0+qbriHeF2YWCuRsz6NOqT29EGx1gvL8CVAQd/YTPSDs6OTHLCvNTUs0?=
 =?us-ascii?Q?OpeENA/XzwYtsLdKAqNx494TO56Ff4aqNzDnSiUBnLXC6r3fd3SWARdIU7oV?=
 =?us-ascii?Q?mgqxXOOA0S11LiyqSBFzlnJakhKlgu2I+/8WWYen3hPKoK1YL7T8dxdtZiWi?=
 =?us-ascii?Q?OwKoW+I0E2ZHiw41AUGwYfbu61xnzngjsQMKgw/YWvHoE/6jRxSTe01Cu7/2?=
 =?us-ascii?Q?xZFd1M+aRBp9hH/qr0BNMksPjNU43Vy2DOPwSiuykiFd/kXS2PVHOpubIGtA?=
 =?us-ascii?Q?cT6eaN4kEadThnA5WVrqqePPHB3r04pEMaZ+EJHV2UEJz2Qnii7ru0LPqgD6?=
 =?us-ascii?Q?sbmKMdSE5pugHv9NyB2e+HxkffefCoAYN8T7sqCb8B2yNrLc0jCOhh0PzwO9?=
 =?us-ascii?Q?gg3fN+YTyCPUhASTC5OFE11xoMwo3XOGlIryQ3GGW0L122FDAm2PsVZXudkF?=
 =?us-ascii?Q?txjuF32W399r1UPHz1Kc0jxI?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 247ac3ed-1719-4bfb-0d1c-08d983118ca9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 06:22:45.2014
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X0egyFbPT4tQNBC6Mre+4XwqvrJPrG9V4Jpm1tqCsSlvliUAHYSTU35YpD91k4jOLGn3QkboRV/+iVt3TYS3X0f+9R7VIRjuwmYxyoWsOO8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5571
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10121 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2109290037
X-Proofpoint-ORIG-GUID: TD63KVpMhPvADrFqekozpQtnKqzgUspl
X-Proofpoint-GUID: TD63KVpMhPvADrFqekozpQtnKqzgUspl
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 28, 2021 at 11:40:15PM +0300, Pavel Skripkin wrote:
> Syzbot reported memory leak in MDIO bus interface, the problem was in
> wrong state logic.
> 
> MDIOBUS_ALLOCATED indicates 2 states:
> 	1. Bus is only allocated
> 	2. Bus allocated and __mdiobus_register() fails, but
> 	   device_register() was called
> 
> In case of device_register() has been called we should call put_device()
> to correctly free the memory allocated for this device, but mdiobus_free()
> calls just kfree(dev) in case of MDIOBUS_ALLOCATED state
> 
> To avoid this behaviour we need to set bus->state to MDIOBUS_UNREGISTERED
> _before_ calling device_register(), because put_device() should be
> called even in case of device_register() failure.
> 
> Link: https://lore.kernel.org/netdev/YVMRWNDZDUOvQjHL@shell.armlinux.org.uk/ 
> Fixes: 46abc02175b3 ("phylib: give mdio buses a device tree presence")
> Reported-and-tested-by: syzbot+398e7dc692ddbbb4cfec@syzkaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter