Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp351020pxb; Wed, 29 Sep 2021 00:14:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlW8Is7Qmx+8AMIPmbC1fX+YFFMWpxNvxJi60JTMh9GfDCAeIzZyFrc7l9cnAVqJOOfT+k X-Received: by 2002:a17:907:920e:: with SMTP id ka14mr11419964ejb.367.1632899649427; Wed, 29 Sep 2021 00:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632899649; cv=none; d=google.com; s=arc-20160816; b=vHUuaEMTpW2b26NvtEN2a9l4+4arpDJw1Yw2E2HJI61oGX2JhocNSYkIJ6uh22P3JQ K2sExiiiqvMTn6+9eH/WHwnEvC+iXhivd3+QzCVK5Xm2lJF6N3hnDpMtvIV2nl/iX89E QkaQ4SVbOhNeqJiXKQXEOz7TBLRshQ3/OKuWsEfDuwDT6xycoEuKaZcHY/zclSFx2hwV 9cfATENVRLHoFvkezb7CqdCRLmZYHuza0avHzxYWU27Agk2cGy5CW3bqj38GQbZv2aGi 9hLWtHeVWhoL5H1U7I4rG8ZtGSWHzbKGPZiDFCidieK0Veg8IO+50gdwlyirGJ7l8Box ccfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Rfn/RSuMmk5y6ZJA1VwqaUbdI4VVIDYyQj92saxwa1U=; b=Go/D9WM8ZbHVyVcer3DDG7xAQ5GmIVHeJwK30agH2wCgm81rjFR3ORe8D7APi6Zz4Y dGKMwMqcwLSHfdRHqpJR9KROJ8+gEhDpaEg2kLa4viTI6WiQYhU6M/dMjjDpXtUvOPjl Cv9eTsMIuaGPBNjbwpHHD/9/sGIyPmD5IsowlkeNMLXSu037oiZ19F230U5KMzI/gqO5 8TKnHYiwNd+enxrxadn80VQpW3bA+OMKCoXvmfa/tt5K0P5knzRghtW2tSDbWjL38Fek BQMQiopQCdy/0+zNEaxUuHh0bihQTMhFV4YrOAROebDEVDV1qd0og0y4TKLc5a0I1GCe 3AJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vB+VKm4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b16si1773198ejd.350.2021.09.29.00.13.45; Wed, 29 Sep 2021 00:14:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=vB+VKm4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244538AbhI2HLK (ORCPT + 99 others); Wed, 29 Sep 2021 03:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244495AbhI2HLF (ORCPT ); Wed, 29 Sep 2021 03:11:05 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4D2DC06161C; Wed, 29 Sep 2021 00:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Rfn/RSuMmk5y6ZJA1VwqaUbdI4VVIDYyQj92saxwa1U=; b=vB+VKm4IMGdjKTike8OfMVSW8q +Ux2VKLJBweoaELDrkaxJ2zefCvAWPOyEkZfLHCRYKgz4Zqn5+uaxBwzEVmmgOkD5bG3R34gh64Kh 2FU14wa/9Jgi1fn+Pa6sU1bWJyNYWbsXzd32IOLUpJjreI1wD9p9VB1p2JpULaidKxwIzueaWlxjS 2U0vfAaeFVYzhWbHi2ktszjPdnCWAx5xzCxBu4rlqcjCMuJuGeTLZ6w9jJo8Tnj1E+GWiPGBq4uQV 5cv17DnMqbWzc5A35ZQ4+qjRPNhioxu1DFbT7jIa/4QaXev+K96MAf1l7lqfUUHzHBCefuGYqLk95 G1PvkLdA==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVTha-00Bahg-2B; Wed, 29 Sep 2021 07:08:43 +0000 Date: Wed, 29 Sep 2021 08:08:26 +0100 From: Christoph Hellwig To: Po-Wen Kao Cc: linux-block@vger.kernel.org, axboe@kernel.dk, linux-kernel@vger.kernel.org, stanley.chu@mediatek.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, alice.chao@mediatek.com, jonathan.hsu@mediatek.com, cc.chou@mediatek.com, chaotian.jing@mediatek.com, jiajie.hao@mediatek.com, wsd_upstream@mediatek.com, ed.tsai@mediatek.com Subject: Re: [PATCH 1/2] blk-mq: new busy request iterator for driver Message-ID: References: <20210929070047.4223-1-powen.kao@mediatek.com> <20210929070047.4223-2-powen.kao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929070047.4223-2-powen.kao@mediatek.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 29, 2021 at 03:00:46PM +0800, Po-Wen Kao wrote: > Driver occasionally execute allocated request directly without > dispatching to block layer, thus request never appears in tags->rqs. > To allow driver to iterate through requests in static_rqs, a new > interface blk_mq_drv_tagset_busy_iter() is introduced. Don't do that. All requests must be dispatched to blk-mq. Let's not even get started on these hacks that will make our life painful forever.