Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 7/9] xen/x86: hook up xen_banner() also for PVH
To:     Juergen Gross <jgross@suse.com>
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>
References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com>
 <5af11027-cf9d-cf78-9f48-b2ce2edd6e62@suse.com>
 <2ded8c58-b9c3-89dc-6883-1794d1c4126a@suse.com>
 <d9b6e98c-4e75-73f3-1e6d-42df300cfd49@suse.com>
 <89cb2d39-2bfc-dccf-8e92-39e4e952750d@suse.com>
 <f613a83c-2b29-23eb-ca78-a8a75a67f651@suse.com>
 <e095eec1-f35b-ca35-9ad1-54c817e61408@suse.com>
 <1bcb3b62-8327-7da8-abdb-65ee965714a7@suse.com>
 <86a4d837-5603-39d0-4643-c31597d524df@suse.com>
From:   Jan Beulich <jbeulich@suse.com>
Message-ID: <ae73b283-fca4-de3f-d654-bde94405e05f@suse.com>
Date:   Wed, 29 Sep 2021 09:28:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <86a4d837-5603-39d0-4643-c31597d524df@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHBiVlFIaE5RM3UxSEpPS2hLTjYwQ0g5N1lNSEhBMkdPR3djU0Zoa3ZFYkdp?=
 =?utf-8?B?R3BBMWRmczJxbTZvc2t0ZUdOdEJHakRwNmtpdmZMcnN4bkFzNnA0UFMwa1hS?=
 =?utf-8?B?WERuRnZzYVQ5UklEOEJNdERhZUFBKzBRYjIwNWExcTZuamNZZlVjbU5GTXY4?=
 =?utf-8?B?bGQ2bVh0Rm5taUZLYW1oTU5oek5QczFvUVQ4QU8xMmZySTZsZXNpbEUxNmdz?=
 =?utf-8?B?Z054TGVPc2t3OEtaS01vUXZqYkFDQnQ4VVBScDhPOG00dTkwRXJlS1VSTjNP?=
 =?utf-8?B?MFpaZWxQaWJFcjkzUUlZZE5FV29PWTRoT2czTWQ4a3g1YnNhdGNaWUVmYUtu?=
 =?utf-8?B?WDkzbWtjRlgzWGg5YXpsbjJJcmhKYnVGUnhpcDJVbTFIVjVGMWJycm5xNklD?=
 =?utf-8?B?SEdlK3kvVDIzTWU4dlVybmJVRys2Z1BqWTBUWmVPYk9tc3Y2QkY3QmxmeTZX?=
 =?utf-8?B?TTRRRTJMWkx1blFRVnc0bUJMaHF3ZGFNYWNjeXdvbFRuMVQ2SVdEWEhveXpL?=
 =?utf-8?B?US9rTThQV0FjQ0pOSG9wQkJCZndYN01pL0hsYTlaa28rOG1EYjJaWVZ0YXJq?=
 =?utf-8?B?ajNvSjM2Q2tabkgvZHhFRW1pQTBQODB0ampuVWVZeWdwK2ZTRWpsTUw5dEZu?=
 =?utf-8?B?MC9YcU9QWTFDLzMvcFpyTXc0Q1gzNG9YdjAxUElVRkM0WndWSWhNaFlzVVF4?=
 =?utf-8?B?RXRSYWdaMEh1MmcrUDZKL0tCTHBEamJqSzdPZFl3MFE0cmRLZ25JVGZ6M0Vr?=
 =?utf-8?B?OGJDcHBZZGhlNXIrZzkvQUxxUVRzNmFvVGd5QWMvMUxmYTRCZktKU1VRbER5?=
 =?utf-8?B?SEhCbGp6aGozRU1Jd2k0ZXlkcjh5WU1XaHg4VjBoTkJ0c2N0cHRiU00wM0FZ?=
 =?utf-8?B?cWpka0poR1A1VkxYR3FlMnZNb1AxNnUvOXh0cldjYkJqdUlBWkVMK3Zhdy9o?=
 =?utf-8?B?M2owb2FObHhiejVDbjhGSU5LaGx4SysxQzJiYnNqd2F2ZUFnUzBMQllVTWZV?=
 =?utf-8?B?amQ2d2YxY2hEbW9nWi9ZaWxsQ1pLYmZnVjVxNWhMeUI0cVFGK2svdlRlTStX?=
 =?utf-8?B?bmtWSEhlbUVOY2N4TjRDcVh4UEttRXFsdTAxc3A5cjF0NnVGclE4OUY4RzRs?=
 =?utf-8?B?MTl0WGVlekxUSGxaa1lRemYvd2JIamhwRGcxeUVucEkwSWFkNzJSR2Z6SEh3?=
 =?utf-8?B?WEl0MTROV2tWK3pFT2xnSW1tYjVibWloYzFTQSs1Q2NsZGdmbTZJSnEzK1ky?=
 =?utf-8?B?SElLSnNCcFdTQkI4WG5vLzF2VXZFTlJYajRlSGEvaTFhRy8vRVk3bDZpalQ2?=
 =?utf-8?B?VjVYeUxaOENIS0lxTXFKRkRxN05YbTBNblc1QlNZZUpTZ2h0dzZZV25JZjZo?=
 =?utf-8?B?QXBYNFVJc3NhaEppditGcTRjV1YydFlxRTBQYlJHemR0S0Z4UnV0QjJMSUtG?=
 =?utf-8?B?aFRDMHRFK2tQdTRkVUFTcGRuRjRsQ1VsRDl3dkRlMmtRSmwrWVhGOU1reDZO?=
 =?utf-8?B?U3FhZ1ZYYkN6RmV2OU0yeCtGdTI0RVplNXlnY3BsaHNPd3lVQklybC83R1Vu?=
 =?utf-8?B?VE5tSU4xazZTT1NnbkFpMExIN04vMUhPRTlPZWRqa2VzMnVIdU9uS0htWjBU?=
 =?utf-8?B?a2N2ek5nQXl5RUdyb0JBa2hFUHdnUkNKYVI4Z3ZOL1dKL2F6emRiZTY3bW9N?=
 =?utf-8?B?eUhQV1MwWXRjTFlvYU8vYnJJZzVhUDJZQWFjRlpoeFpwd0pQQnlaQ3AxV0tp?=
 =?utf-8?Q?OcEW7L/gSBUkJ3iHQ1dLWjooQahiZH1vZxIxOp8?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa44c12b-65b2-48b2-60ad-08d9831abb60
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 07:28:28.9527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hd1EzYtFh7472YvRbJeUMaojYn1G/CppMPSZe0RrxRy9kxGjVXt2YrM4doVC4qMMFx4Vu7sumNfEUwX2yuRzQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4607
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 29.09.2021 07:45, Juergen Gross wrote:
> On 23.09.21 17:31, Jan Beulich wrote:
>> On 23.09.2021 17:25, Juergen Gross wrote:
>>> On 23.09.21 17:19, Jan Beulich wrote:
>>>> On 23.09.2021 17:15, Juergen Gross wrote:
>>>>> On 23.09.21 17:10, Jan Beulich wrote:
>>>>>> On 23.09.2021 16:59, Juergen Gross wrote:
>>>>>>> On 07.09.21 12:11, Jan Beulich wrote:
>>>>>>>> This was effectively lost while dropping PVHv1 code. Move the function
>>>>>>>> and arrange for it to be called the same way as done in PV mode. Clearly
>>>>>>>> this then needs re-introducing the XENFEAT_mmu_pt_update_preserve_ad
>>>>>>>> check that was recently removed, as that's a PV-only feature.
>>>>>>>>
>>>>>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>>>>>>
>>>>>>>> --- a/arch/x86/xen/enlighten.c
>>>>>>>> +++ b/arch/x86/xen/enlighten.c
>>>>>>>> @@ -261,6 +261,18 @@ int xen_vcpu_setup(int cpu)
>>>>>>>>      	return ((per_cpu(xen_vcpu, cpu) == NULL) ? -ENODEV : 0);
>>>>>>>>      }
>>>>>>>>      
>>>>>>>> +void __init xen_banner(void)
>>>>>>>> +{
>>>>>>>> +	unsigned version = HYPERVISOR_xen_version(XENVER_version, NULL);
>>>>>>>> +	struct xen_extraversion extra;
>>>>>>>
>>>>>>> Please add a blank line here.
>>>>>>
>>>>>> Oops.
>>>>>>
>>>>>>>> +	HYPERVISOR_xen_version(XENVER_extraversion, &extra);
>>>>>>>> +
>>>>>>>> +	pr_info("Booting paravirtualized kernel on %s\n", pv_info.name);
>>>>>>>
>>>>>>> Is this correct? I don't think the kernel needs to be paravirtualized
>>>>>>> with PVH (at least not to the same extend as for PV).
>>>>>>
>>>>>> What else do you suggest the message to say? Simply drop
>>>>>> "paravirtualized"? To some extent it is applicable imo, further
>>>>>> qualified by pv_info.name. And that's how it apparently was with
>>>>>> PVHv1.
>>>>>
>>>>> The string could be selected depending on CONFIG_XEN_PV.
>>>>
>>>> Hmm, now I'm confused: Doesn't this setting control whether the kernel
>>>> can run in PV mode? If so, that functionality being present should have
>>>> no effect on the functionality of the kernel when running in PVH mode.
>>>> So what you suggest would end up in misleading information imo.
>>>
>>> Hmm, yes, I mixed "paravirtualized" with "capable to run
>>> paravirtualized".
>>>
>>> So the string should depend on xen_pv_domain().
>>
>> But that's already expressed by pv_info.name then being "Xen PV".
> 
> True. Okay, I'm fine with just dropping "paravirtualized".

Done. Do you want me to also make pr_info() vs printk(KERN_INFO ...)
consistent in the function at this occasion? If so - which of the two?

Jan