Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp366957pxb; Wed, 29 Sep 2021 00:44:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykZXqLho6OFnmlJe/aAIr9DY15dt5gbeqfNCBZihCNqxnO6w/C8PDT4BZgKrYWUS1g5tS7 X-Received: by 2002:a50:8405:: with SMTP id 5mr12997764edp.111.1632901448973; Wed, 29 Sep 2021 00:44:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632901448; cv=none; d=google.com; s=arc-20160816; b=F50vH9/WcV9WHZOhYOE5F1nRYlvIR298QpUDeUF3ILCJFYlal3sxD4EsHSH8QX0OUR jPqatjsPgmSvMjJJ8RAigdifPqFFttvFLMznEaN5d0zpnRkwZSCpp3DYk4/yIcQRxPMi jR78oYNPUejNbKFSyWCdPPUkIF1msaAnYdVihAHQlt4SVkv7tyuc674AAccKxv2Jm6xw UDEEADj38nZoDcYFdQG7MwBc81DVPnVTB1fdRJ8tdPpVNsHAYsm4DhE+sH7FrZGaccmY mwK9agtMwrSZaRgl+JFAPgBy/SquqBAeYzQQ0EHnmG4Z6lP29hfvYvPwBcCbv+2zOxuM eDtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dJs5liWCVnFcXOZVkmO+BXniGV1L8G1qTdIGQrZdEvQ=; b=N9xx6WmRKH+QOfNxhGiiHon+y0/L0yB0JK5MDoj2DcHmwtLRHO7+Fax5ci0Axlj1pJ hNbChf4o04apgOwYlFH+Wi3wPpjR7dYhAUueb+vxsY9hn3R7VA7pJE9RenWryFlb8xZB jefLHxOFN3OvOcvg03ah5FAQ/YINvxJQ+WvTAm0kMVPS50N7R07Tsdkmk6Gy/PXuK20v IPNWkM3z5MygFHxuPnKxaVnpXBDGsZiLWDOa3eu49Vg76TS0FAqtkNL6OrSqukPkQ0tl dQYm4HPYde7s3Mb98kdJF+YuRsFH2ORCfZvF7KcZvR7dBKoDMB2xqVges3/iq9kzEEuR 27PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="qAn/WpIu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kl17si1877861ejc.507.2021.09.29.00.43.40; Wed, 29 Sep 2021 00:44:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="qAn/WpIu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244661AbhI2HlZ (ORCPT + 99 others); Wed, 29 Sep 2021 03:41:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:42666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244657AbhI2HlY (ORCPT ); Wed, 29 Sep 2021 03:41:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 78191613C8; Wed, 29 Sep 2021 07:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632901184; bh=7dRu7YsEfukSf7PESkloedYqIhpiZA3O3u/vv59OaqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qAn/WpIuAheoyfGlkGJPpvqEn7y9MTH4TFBANF6G+HnbR/dxV1x5h9POi+A87v6Om SgNfoSLeE10FtJA8pOI+yKkLujnLvteRn654YfBoVD5qk14oMLPSwhr/5g6zU4NTKl fCSGLVwF2oTmiGYNm2xsSr+jOQXEmgfqhsNbrmXA= Date: Wed, 29 Sep 2021 09:39:41 +0200 From: Greg Kroah-Hartman To: Avri Altman Cc: Mauro Carvalho Chehab , Linux Doc Mailing List , Jonathan Corbet , "Martin K. Petersen" , Adrian Hunter , Bean Huo , Can Guo , Daejun Park , Lukas Bulwahn , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 16/17] ABI: sysfs-driver-ufs: Add another What for platform drivers Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 29, 2021 at 07:23:32AM +0000, Avri Altman wrote: > > On Wed, Sep 29, 2021 at 06:32:40AM +0000, Avri Altman wrote: > > > > The current what expressions: > > > > What: /sys/bus/platform/drivers/ufshcd/*/... > > > > > > > > Doesn't actually match what (some?) platform drivers actually > > > > export. For instance, drivers/scsi/ufs/ufs-hisi.c actually creates > > > > the sysfs struct for ufshcd inside this directory: > > > > > > > > /sys/devices/platform/soc/ff3c0000.ufs > > > > > > > > Which has those aliases: > > > > > > > > /sys/devices/virtual/devlink/platform:fff35000.crg_ctrl-- > > > > platform:ff3c0000.ufs/consumer/ > > > > /sys/bus/platform/drivers/ufshcd-hisi/ff3c0000.ufs/ > > > > /sys/bus/platform/devices/soc/ff3c0000.ufs/ > > > > /sys/bus/platform/devices/ff3c0000.ufs/ > > > > > > > > So, add another What: for such files that will match the device ufs > > > > entries, e. g.: > > > > > > > > What: /sys/bus/platform/devices/*.ufs/ > > > On some platforms the suffix is .ufshc So Maybe use: > > > /sys/bus/platform/devices/*.ufs*/ > > > > That's confusing. How about describing why "ufshc" is used in another > > entry? You all must have picked the new name for some reason to > > differentiate, right? > It's a platform thing. Better let the platform guys answer that. What plaform people?