Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bean Huo <beanhuo@micron.com>, Can Guo <cang@codeaurora.org>,
        Daejun Park <daejun7.park@samsung.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 16/17] ABI: sysfs-driver-ufs: Add another What for
 platform drivers
Thread-Topic: [PATCH 16/17] ABI: sysfs-driver-ufs: Add another What for
 platform drivers
Thread-Index: AQHXs6f5Yuh6nmqV7E6a9UXcE4axwKu6iE1ggAAQsYCAAAUzgA==
Date:   Wed, 29 Sep 2021 07:23:32 +0000
Message-ID: <DM6PR04MB6575B12DCA2D78A387E61852FCA99@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <cover.1632750608.git.mchehab+huawei@kernel.org>
 <bc61469964bbcabe38d12aa88f2734d38a8741e5.1632750608.git.mchehab+huawei@kernel.org>
 <DM6PR04MB6575E3C9D13E8B41627240FDFCA99@DM6PR04MB6575.namprd04.prod.outlook.com>
 <YVQP1btICr0TJusK@kroah.com>
In-Reply-To: <YVQP1btICr0TJusK@kroah.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m38JLqwP0cWIu48Zfp7WikgDrs1bbvLr0fiE43Tspn6SJitWLkXKtTUNVVml?=
 =?us-ascii?Q?hAuCC8LfnVmbMsilAOwKKmGWoKFjG7f/8N1xYyUSMxPHPzAYESsq59CuGMMG?=
 =?us-ascii?Q?cE/4nsPJRBTErHMRPpr77HZMS+cFlFXiQpFOl30tLVlxRGbEi3NOSwnHXOXn?=
 =?us-ascii?Q?mrI0FroZT2DB35wFlxR0jdPDjDSHR/G88aIk28KCx/ofjU9nPzRZ6WSRItYS?=
 =?us-ascii?Q?NkKO8YXL4iY63XshNkBzoeKenIDt25giT+N+Y6Cymn5TFnszpDZdurIIKnTj?=
 =?us-ascii?Q?1AMJ6dFA6euX1FHbYWhZcWDlbgA1rRz9QZVzefZc4HMiHuJaZ5fOzMgko6Ge?=
 =?us-ascii?Q?wUPughckX+llhKhRpTfY9hvVaZuGRMUAUmZK1v2Ta1SjLpfVSaeyJcK9mXuY?=
 =?us-ascii?Q?xg9TsX0TLaagNzzQnKNfLkUcZcj/IB2Qves+acuUUH1LAq5W82uQ85nrd3DD?=
 =?us-ascii?Q?nXyrAwBqH295IId/P/1iiAIkCUo3SnWSz5EJSXbZJdpymSltLWaV9RMDL/NI?=
 =?us-ascii?Q?reqnwksd7vmjFgeDa48GeWWHzhJkR+VhOfOBeY3J10s0SYIBwmJ1DjfO15hS?=
 =?us-ascii?Q?A8twQh/efivALPJbTASTUq/l1570R2XuQG2Xta69WnZGaxaXA6M9VppQ90z6?=
 =?us-ascii?Q?u90k6Y1gys1Zi8aCS4apctVh5L8krthmfNM5lIfJBQaNSdfYIPMCPPEyCLA3?=
 =?us-ascii?Q?1J36r3o+A0P/DlK0vVl7d2icRHW3EhH70SArGDlXvNP+dmwQAWo9S913YMy0?=
 =?us-ascii?Q?s6T56mTb4zbC5TrxTT/EzcOkOgkkHxt5h9bJDaMQ5w1/DHvp/hsbSBEWMwrJ?=
 =?us-ascii?Q?Qct42m2/BdQSYuM8gT/yWlQHslFSAj7WX7JSw2kyolsFiFIBbB/Vh0exGJL8?=
 =?us-ascii?Q?lTt2JTnPec01iX6Ag7HRilAa6qn/CQkh7usgvOCnv0Bgn9j9zSfwqjWclg6n?=
 =?us-ascii?Q?NA3wKdeTVB5sViWrLKPr6MetMZwAb0+G+YpPpmjRxTBn7yH25YIPo0QMiPBm?=
 =?us-ascii?Q?cOLrT/Zi6iN3BWHcn+4jcKil+rPCS8Y7SYMeRESYrEbICOix0jksNCHoHQOm?=
 =?us-ascii?Q?8CkxAXMCTP8AE0y613oD+jt7op3BhYtGa0i4W1wteTLlEaveagm3tND7Jxmm?=
 =?us-ascii?Q?6ehoSfCFz3qcP7cbmkzYQet/EIBVpbFG9tQqTcEqhCAsLE/McR6dVvE6LmqL?=
 =?us-ascii?Q?4bXx6oodD5AnQjp2cq9x1xJRgjjNFB7Je/BSAJEABpg2ozoIHeNBA/P3qc/I?=
 =?us-ascii?Q?XyXeaW3i0bL9QuWETJ6C6ox06kr0Gfmnm+K9XOD41FWZX2TcYyGJID0/5/T5?=
 =?us-ascii?Q?zX5brHN7oh1stmklgUykytVM?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e050f407-7a21-40bb-e2da-08d9831a0ad4
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2021 07:23:32.2991
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: T2DDpsi1FFwZu6FP4WCEB+JlVvgwP3MIpvFVOm9XWcE1/ojwgg6idactsUqQUY1uww7T58vaHdazwX36CaS4gQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6795
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Wed, Sep 29, 2021 at 06:32:40AM +0000, Avri Altman wrote:
> > > The current what expressions:
> > >         What:          /sys/bus/platform/drivers/ufshcd/*/...
> > >
> > > Doesn't actually match what (some?) platform drivers actually
> > > export. For instance, drivers/scsi/ufs/ufs-hisi.c actually creates
> > > the sysfs struct for ufshcd inside this directory:
> > >
> > >         /sys/devices/platform/soc/ff3c0000.ufs
> > >
> > > Which has those aliases:
> > >
> > >         /sys/devices/virtual/devlink/platform:fff35000.crg_ctrl--
> > > platform:ff3c0000.ufs/consumer/
> > >         /sys/bus/platform/drivers/ufshcd-hisi/ff3c0000.ufs/
> > >         /sys/bus/platform/devices/soc/ff3c0000.ufs/
> > >         /sys/bus/platform/devices/ff3c0000.ufs/
> > >
> > > So, add another What: for such files that will match the device ufs
> > > entries, e. g.:
> > >
> > >         What:          /sys/bus/platform/devices/*.ufs/
> > On some platforms the suffix is .ufshc So Maybe use:
> > /sys/bus/platform/devices/*.ufs*/
>=20
> That's confusing.  How about describing why "ufshc" is used in another
> entry?  You all must have picked the new name for some reason to
> differentiate, right?
It's a platform thing. Better let the platform guys answer that.

Thanks,
Avri

>=20
> thanks,
>=20
> greg k-h