Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp486356pxb; Wed, 29 Sep 2021 03:44:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpMcO+fmneZLbrC+mg9aOuSm5Y9Fyb70Kb/Y6HisViWUcpw1QY7kSWreo6qjXfxfsPh61I X-Received: by 2002:a17:90a:4b4d:: with SMTP id o13mr5583629pjl.236.1632912258601; Wed, 29 Sep 2021 03:44:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632912258; cv=none; d=google.com; s=arc-20160816; b=w5kYAU0vAKjcGPGw325YlMczo1+6k61grMcT64q6hzha/oogszKRhrAX0DqUAAxdp8 5kesf7SYL8o/bTad+CEsc1/84qQu4TjKEeyjWcm3unXMABT8uuzCEn5slW1qcSnxBksA 8SlP4Zl8z971jZpZAAtnqvqHoF2gX4+r+T028DqwHvVQRvaWwdpoQdSA4lYx5akyzZgH 0RbvFmS5IE+v9DGGaaOwR/iTRe1ntLzWhYCPvlAXgo08NXTJEIK3G1Gh60KzwTHDJnGp RvRUbRQcFlveXIY8uP+Bi/oWeAgSoTQ/BhFBL041nFimP0bgHn3fqD++7cJyFHjJQew9 XccQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=tqnkDoby5Lb2fJVa5WubVleoJJrhFZixK6YbjgxnFxU=; b=ll0RUDA7p3bub7r/Vcq8hISfBdVE2hjRrl5LpWfpMBfMCV05M8Z3Y+PyjCjZi6nlmK cEr07sR64LLthV/vBUmgHE2AjsyPQ80ct8bXxF5UlWTNGQ20bBlw0vsYAFaf1dneDoep KiLD+rU6x+HDldGbjYSTC+aJXrt645hm8AiZg1S3wkJVX9QUQgjo/IjCo8M0DATXJknS btwFBR3fLMzcvP+pgvnArKGtYwOgeG102JK+wdyL9Z+z725cyh/qjIRyfmS/wGNWGklK 78fqz9Zay7z8K65QzXxMBDG73KrDOCwBjlHDGl1/ZOwXv7stYbido5dUEVWOrt3CNUKA fMBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d8si1932342pgq.172.2021.09.29.03.44.06; Wed, 29 Sep 2021 03:44:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245063AbhI2JZq (ORCPT + 99 others); Wed, 29 Sep 2021 05:25:46 -0400 Received: from foss.arm.com ([217.140.110.172]:53442 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230347AbhI2JZp (ORCPT ); Wed, 29 Sep 2021 05:25:45 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A63E8D6E; Wed, 29 Sep 2021 02:24:04 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.21.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F328C3F793; Wed, 29 Sep 2021 02:24:01 -0700 (PDT) Date: Wed, 29 Sep 2021 10:23:58 +0100 From: Mark Rutland To: Pingfan Liu Cc: Marc Zyngier , Pingfan Liu , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Joey Gouly , Sami Tolvanen , Julien Thierry , Thomas Gleixner , Yuichi Ito , linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 4/5] irqchip/GICv3: let gic_handle_irq() utilize irqentry on arm64 Message-ID: <20210929092358.GB33284@C02TD0UTHF1T.local> References: <20210924132837.45994-1-kernelfans@gmail.com> <20210924132837.45994-5-kernelfans@gmail.com> <20210928091053.GD1924@C02TD0UTHF1T.local> <87mtnvu9to.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 29, 2021 at 04:27:11PM +0800, Pingfan Liu wrote: > On Wed, Sep 29, 2021 at 08:20:35AM +0100, Marc Zyngier wrote: > > On Wed, 29 Sep 2021 04:10:11 +0100, > > Pingfan Liu wrote: > > > > > > On Tue, Sep 28, 2021 at 10:10:53AM +0100, Mark Rutland wrote: > > > > On Fri, Sep 24, 2021 at 09:28:36PM +0800, Pingfan Liu wrote: > > > > > The call to rcu_irq_enter() originated from gic_handle_irq() is > > > > > redundant now, since arm64 has enter_from_kernel_mode() akin to > > > > > irqenter_entry(), which has already called rcu_irq_enter(). > > > > > > > > Here I think you're referring to the call in handle_domain_irq(), but > > > > that isn't clear from the commit message. > > > > > > > Yes, and I will make it clear in V2. > > > > > > > > Based on code analysis, the redundant can raise some mistake, e.g. > > > > > rcu_data->dynticks_nmi_nesting inc 2, which causes > > > > > rcu_is_cpu_rrupt_from_idle() unexpected. > > > > > > > > > > So eliminate the call to irq_enter() in handle_domain_irq(). And > > > > > accordingly supplementing irq_enter_rcu(). > > > > > > > > We support many more irqchips on arm64, and GICv3 can be used on regular > > > > 32-bit arm, so this isn't right. Moving the irq_enter_rcu() call > > > > into the GICv3 driver specifically breaks other drivers on arm64 by > > > > removing the call, and breaks the GICv3 driver on arm by adding a > > > > duplicate call. > > > > > > > Oops. I forgot to protect the code in GICv3 with CONFIG_HAVE_ARCH_IRQENTRY > > > > > > > It looks like this should live in do_interrupt_handler() in > > > > arch/arm64/kernel/entry-common.c, e.g. > > > > > > > > | static void do_interrupt_handler(struct pt_regs *regs, > > > > | void (*handler)(struct pt_regs *)) > > > > | { > > > > | irq_enter_rcu(); > > > > | if (on_thread_stack()) > > > > | call_on_irq_stack(regs, handler); > > > > | else > > > > | handler(regs); > > > > | irq_exit_rcu(); > > > > | } > > > > > > > > ... unless there's some problem with that? > > > > > > > Yeah, do_interrupt_handler() is a more suitable place. But to resolve > > > the performance regression of rescheduling IPI [1], it is badly demanded to > > > distinguish irqnr before calling irq_enter_rcu() (please see 5/5 and [2] > > > for the context). So it is a compromise to host the code in GICv3. > > > > > > Any good idea? > > > > There is no way we are going to single out a particular interrupt > > controller. As for the "regression", we'll have to look at the numbers > > once we have fixed the whole infrastructure. > > > But I just realize that at present, gic_handle_nmi() sits behind > gic_handle_irq(). So it will make an mistaken for accounting of normal > interrupt if calling irq_enter_rcu() in do_interrupt_handler(). We can restructure entry-common.c to avoid that if necessary. TBH, the more I see problems in this area the more I want to rip out the pNMI bits... > And going through drivers/irqchip/irq-chip-gic*, I think there are only > two files should be handled: irq-gic.c and irq-gic-v3.c. That are irqchips other than GICv2 and GICv3 that are used as the root irqchip on arm64. For example, Raspberry Pi 3 uses drivers/irqchip/irq-bcm2836.c as its root irqchip. Thanks, Mark.