Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 29 Sep 2021 13:38:23 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Leon Romanovsky <leonro@nvidia.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Andrew Lunn <andrew@lunn.ch>, Ariel Elior <aelior@marvell.com>,
        Bin Luo <luobin9@huawei.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Coiby Xu <coiby.xu@gmail.com>,
        Derek Chickles <dchickles@marvell.com>, drivers@pensando.io,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Felix Manlunas <fmanlunas@marvell.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Geetha sowjanya <gakula@marvell.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com,
        hariprasad <hkelam@marvell.com>,
        Ido Schimmel <idosch@nvidia.com>,
        intel-wired-lan@lists.osuosl.org,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Jerin Jacob <jerinj@marvell.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Jiri Pirko <jiri@nvidia.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        Linu Cherian <lcherian@marvell.com>,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev,
        Manish Chopra <manishc@marvell.com>,
        Michael Chan <michael.chan@broadcom.com>,
        Moshe Shemesh <moshe@nvidia.com>, netdev@vger.kernel.org,
        oss-drivers@corigine.com,
        Richard Cochran <richardcochran@gmail.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Satanand Burla <sburla@marvell.com>,
        Shannon Nelson <snelson@pensando.io>,
        Shay Drory <shayd@nvidia.com>,
        Simon Horman <simon.horman@corigine.com>,
        Subbaraya Sundeep <sbhatta@marvell.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        Tariq Toukan <tariqt@nvidia.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        UNGLinuxDriver@microchip.com, Vadym Kochan <vkochan@marvell.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>
Subject: Re: [PATCH net-next 3/5] devlink: Allow set specific ops callbacks
 dynamically
Message-ID: <20210929103823.GK2048@kadam>
References: <cover.1632909221.git.leonro@nvidia.com>
 <4e99e3996118ce0e2da5367b8fc2a427095dfffd.1632909221.git.leonro@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4e99e3996118ce0e2da5367b8fc2a427095dfffd.1632909221.git.leonro@nvidia.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uIfQ8Fehrm9tEZlVWjjz0zq5pNIXQ4hRUGgEzu+q66Pf41uFOuVxkThLUyHu?=
 =?us-ascii?Q?XSwQ/l3dTRavDtCmn7d6lkr7FnleWvo0NfzCdNpDtc6kS5cn17g4uasN8BW/?=
 =?us-ascii?Q?VefZUdyIPL1lrPhi/oDWWu2m3jdaVPWU1143tRPZS9K2x3tM1hV7VwyIMSgT?=
 =?us-ascii?Q?MggcCaxaMNzX41dRMld6NApDWJMMbzRIyanL+0nAP9cAgagasebJetEiZT8z?=
 =?us-ascii?Q?REdoyqCfJN7wPKekE+cpTQwkJANT1jxdntGlhMsDChE88m9S6cl3tnv6Jq41?=
 =?us-ascii?Q?ln6YziYaaC+DKwmtHxD/ZofzzbNCOQ/RZOT4TW/M2iwsk0Bqv37P1rZHaIgf?=
 =?us-ascii?Q?xRnFQku/S/tMmIVNBtTzxUnVwGnAvUfDpguMsf2S8OBIRa5PB3ty0I8Vk1G/?=
 =?us-ascii?Q?yD2ZRcMkiqtFIaJFOtg9evXb3zMQH0yhDGVosIOjsIQrWylbe5BCs+4geNrn?=
 =?us-ascii?Q?cMvrZ91iPH/AYQna75K/Dxt18YNOP01SgebDFkdm1UZQ/9YSZSEal7s+v5xH?=
 =?us-ascii?Q?/5unjC8r/Sm6tA6EqR6k3BbqSIlWgQuiNaOxnV9mgH7J0FMds1pvXiFcf0Jk?=
 =?us-ascii?Q?zRpnkZUAF3/FwOFMGALI7EEYLgl+bekknC3+mwAvPnkRzRdBTbUlXyzI2VzF?=
 =?us-ascii?Q?re5iml2WyIZ9v5f0sCZcHA5ihQccffx0bpNtoHFiJ0782Ap7WJOgxfzuwGo6?=
 =?us-ascii?Q?xNN72f5LIihJ1gXeDQn/tks5q9DPeBfMZD+pm+iRBAJtXns7pU8TSXSjFtTc?=
 =?us-ascii?Q?n/cB2gCqlGZUDH034nxjX3zi0donyUlqDfxn/J1xh0w3NqEmywSpmE4xYKDq?=
 =?us-ascii?Q?4PQxijFReZhMXzPv66uo/eD5ZqEVLghzvZRF6iGffUHSF6EUngCY5aX/5RJQ?=
 =?us-ascii?Q?eH1HMb9gimILdSvrmgDPabRYFPAu2hUj/s/y5hHNY8ztLKpWvB0Oz6ZXE4Gn?=
 =?us-ascii?Q?NuUaQ1a3og8tfLI4OpHTdgU0v6Z7Zt0gglZ1RsftjLj/NGCU6hvMUu4YX8xt?=
 =?us-ascii?Q?nRBWl0UwUMn0HedGdKQ2NRsfYhHhtucIM+D0tTHqAO85ajsL1RGQgNNY74rC?=
 =?us-ascii?Q?SMVX27pdBNNGFzav4HI755W/hGGJGtTiLHbbQbxEed300FdnYpERbqwmfwS5?=
 =?us-ascii?Q?aq1g77AI0ON9JuzrhPTiXyv7bEkUh5kK+aaxqDyN5xf9zMBtYViilJlGQ+EB?=
 =?us-ascii?Q?pOVCEU7oXaL8HZI2n3yhYTI62Rr+7NdirUMq/RR77U67bR18kEsksCPsoMBy?=
 =?us-ascii?Q?X12X8GDZj+P5dyHb5sHSijkTndGfSNgC4DfpyEATM+Vd16+t0XQGVPG43HsK?=
 =?us-ascii?Q?wOIKK88h83vX/EKOyojKJMni?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8bf1bc9f-648d-4bcf-548d-08d9833557e5
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 10:38:58.7684
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /rlCtdwjpVkNY+6F+61rRo1x/kgCUSY30oFwGX00k+yKfXt7yK46bFwHO58/JIhpBe7r2GXBK4lzSFpBTsviumFuxCPvGub2pE4Rj7Q0Jx0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1357
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10121 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 spamscore=0
 adultscore=0 bulkscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2109290064
X-Proofpoint-GUID: HOEwaQlaaYXXR0KcftdVlVUNiW5OhuKo
X-Proofpoint-ORIG-GUID: HOEwaQlaaYXXR0KcftdVlVUNiW5OhuKo
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 29, 2021 at 01:16:37PM +0300, Leon Romanovsky wrote:
> +void devlink_set_ops(struct devlink *devlink, struct devlink_ops *ops)
> +{
> +	struct devlink_ops *dev_ops = devlink->ops;
> +
> +	WARN_ON(!devlink_reload_actions_valid(ops));
> +
> +#define SET_DEVICE_OP(ptr, name)                                               \
> +	do {                                                                   \
> +		if (ops->name)                                                 \

Could you make "ops" a parameter of the macro instead of hard coding it?

regards,
dan carpenter

> +			if (!((ptr)->name))				       \
> +				(ptr)->name = ops->name;                       \
> +	} while (0)
> +
> +	/* Keep sorted */
> +	SET_DEVICE_OP(dev_ops, reload_actions);
> +	SET_DEVICE_OP(dev_ops, reload_down);
> +	SET_DEVICE_OP(dev_ops, reload_limits);
> +	SET_DEVICE_OP(dev_ops, reload_up);
> +
> +#undef SET_DEVICE_OP
> +}
> +EXPORT_SYMBOL_GPL(devlink_set_ops);