Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp576997pxb; Wed, 29 Sep 2021 05:33:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7J7RyhL+FQkBWEF0U4kmb4isRQ0iBGK6vp9lZ44oOtJPadT93RUb0L63acMt5IHf+T3ni X-Received: by 2002:a17:90a:f0d8:: with SMTP id fa24mr6095834pjb.228.1632918802298; Wed, 29 Sep 2021 05:33:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632918802; cv=none; d=google.com; s=arc-20160816; b=pQlR83UvjuFKtAfT2Wn3kCCCcB56KqNVITayTk3v8jrgUaxGwGne+jSsOcchQUjt+E Zc13EYQZETh4Z8H/5MhvUDcxKYWhaRFP8sv4gNJ7ItzeNNAqm9eLciAe5TZbbL/ociDs NW+I5QpkdtQJcs257YakxoJmY/DDMDsg0rQ6c8jNTDCd6mjpJqs97uJXakpGO/x6Vbaz M4dwtFYA2QgifY1/+Q7RGahgJpyu0HL386dQC0nrIA4HCwb0cfcKxPIPZK9GDVlnuPV2 UmF2zMvwHAMn/EorOHCFIPJ/abSuAJ9wDM+rWCGMPDU8a0B9dCtsSQjWSbHCT+PWgUpN Jfgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=FTNDmUlvMT5ZqQ/Z2KvcauJAJmdd+/ztjAw1kxwI6z4=; b=I2eQSntzdSvzVO7hljEbcK6r4XzP8gOv4qLlIFc6bUrATGNgqaNzODFvuIPaVc8OSA vOT/FnGQnxIaDbEI6K3q6/I1OQCYuUUxKQEnwTL/7RsuccoQUCrGwCnDwJEHlg6lHpdr qUMGUhH9SdiD7BMP7Zd4yCbC0M0rRDOaxgdaYTHaEU7KNtT0IEBMzwaP8lpZlA2JI45y z4UIw411ze2d8WlZ2cS4ZUdMvD8GvVV20f/W5orjIT7T1Zt7ZH2LrpTqyVvsfOCCWEqu JcVtROZb7Ag1QWJ40TkV/SMas+dxPbYOcdBKoqZIAdmejj0LHqIFFmYZw7Q1tmwbi2S2 m8FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eyrq5jvo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q145si2636717pgq.371.2021.09.29.05.32.49; Wed, 29 Sep 2021 05:33:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eyrq5jvo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343768AbhI2Mbq (ORCPT + 99 others); Wed, 29 Sep 2021 08:31:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:41594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343531AbhI2Mbn (ORCPT ); Wed, 29 Sep 2021 08:31:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9A483613A0; Wed, 29 Sep 2021 12:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632918602; bh=FTNDmUlvMT5ZqQ/Z2KvcauJAJmdd+/ztjAw1kxwI6z4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eyrq5jvoebysBxaZXASykBblpjG3GOfzan58gaYSwlbbRA+OZrfHEXoSYjonTQmB3 z11Sotsg9T8gxq94qfQ5lVG2GtpJtlVefQicADpdfGkaiVPqP62z8l5LTjzYhXs7FE KQKmbXXnbD+ox36a487aQM5Lt5gFrkZiTCYX9rguNcdBojv7tA2ptiWw7hgkTSmyUe Tonh5pB3opo3Y247zLkoPrruf4lvd6Avw18+igb/g8LPOFPN54BqeDaBFd8xgjYJxU KNX1sz5pQOoq44GXfM3t8gOcoLqw97ElFHzbVvUUOQJRgU4DK7GLwKXMQJ5gKa6QNN AldWqEGZ7o6ZA== Date: Wed, 29 Sep 2021 13:29:12 +0100 From: Mark Brown To: Chunyan Zhang Cc: Liam Girdwood , Rob Herring , DTML , Baolin Wang , Orson Zhai , Chunyan Zhang , LKML Subject: Re: [PATCH 1/2] regulator: Add Unisoc's SC2730 regulator driver Message-ID: <20210929122912.GO4199@sirena.org.uk> References: <20210928073609.198975-1-zhang.lyra@gmail.com> <20210928113057.GJ4199@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hOh8F6DNH/RZBSFD" Content-Disposition: inline In-Reply-To: X-Cookie: 98% lean. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hOh8F6DNH/RZBSFD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 29, 2021 at 04:20:37PM +0800, Chunyan Zhang wrote: > On Tue, 28 Sept 2021 at 19:31, Mark Brown wrote: > > Since this is a part of a MFD I'd not expect it to have a compatible > > string? > Since we switched to use devm_of_platform_populate() [1] to register > MFD subdevices, compatible is required, IIUC. I'm not sure that's a good fit for these regulators, we don't gain any extra information from the compatible here. --hOh8F6DNH/RZBSFD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFUXBcACgkQJNaLcl1U h9AS7gf/Y9ZY1fjRz+eP/5LZIskshRKmSZlQJ4lfJeCRxczaRp3TycTxCFvMVcZg Q88ZKfEJ7vR3JoO00LFqXal38XAlx7X5GPh1SYa7cF8UGmWmU2lwELfTMSnU8dRD jL7PJZGas/d2vXXwyuvZ2YxzrUN6BHMA0YwU2EdK85z+4hNeSCQ84UKAVX4DPRMV S4RwAo6RWQTC+gyYS+oDR2Mv3S47A724sX7sAYJbEMdLvZMpMplNqG0f/xVEfMqx rf6iP2EQ7o1krLR6SAdH5ZshmvNovy/1OcYc5WzOydIvHjjcnVTnIDQFTCYGn5tm Abs5ShUfbg352yF0fiUuQKAouXRk4g== =pmbW -----END PGP SIGNATURE----- --hOh8F6DNH/RZBSFD--