Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e19a07aa-e0a5-3be7-602c-a17963a7e307@redhat.com>
Date:   Wed, 29 Sep 2021 14:56:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH -next] KVM: use vma_pages() helper
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1632900526-119643-1-git-send-email-yang.lee@linux.alibaba.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <1632900526-119643-1-git-send-email-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 29/09/21 09:28, Yang Li wrote:
> Use vma_pages function on vma object instead of explicit computation.
> 
> Fix the following coccicheck warning:
> ./virt/kvm/kvm_main.c:3526:29-35: WARNING: Consider using vma_pages
> helper on vma
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   virt/kvm/kvm_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 7851f3a..8f0e9ea 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -3523,7 +3523,7 @@ static vm_fault_t kvm_vcpu_fault(struct vm_fault *vmf)
>   static int kvm_vcpu_mmap(struct file *file, struct vm_area_struct *vma)
>   {
>   	struct kvm_vcpu *vcpu = file->private_data;
> -	unsigned long pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> +	unsigned long pages = vma_pages(vma);
>   
>   	if ((kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff) ||
>   	     kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff + pages - 1)) &&
> 

Queued, thanks.

Paolo