Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp661595pxb; Wed, 29 Sep 2021 07:13:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvJEgplrUe5vBrWvyN3DTZy3E4bAF4UcJr1hEI2uJx8RxAsaBrTLdcHXKfsq9fYHLNm3in X-Received: by 2002:a17:90b:707:: with SMTP id s7mr6747074pjz.239.1632924781917; Wed, 29 Sep 2021 07:13:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632924781; cv=none; d=google.com; s=arc-20160816; b=IL9Quh5YwRpwD5f2oXaK1BK85zmeZRG681bsB0uycDjO2Zw0xbwLVZv33h2OUnj84P SmHS/Zy19m8+SrS22BFs+NGQTUK/LhqYj0YCWA99C+ZOtnwYp87SwCBeVUbC1R6M9QaH V1jsIGJJ2HJlwvSLgx3MKGRyOoGrNtaWfOwg3dfsJo7+JC3geDYtpArGtxJF2/2cjbBX 1cX/VIubYDlWHe6G1BlsNncHWkH8CbeXHNVwVGh82xCIkNFKwu0eJvvr/QXt6HTMhlrV 76VCdjUkiD0WKrkssHyyTLLatfUeIftOCZQQ4h5BxCoQzNWabf5uQRSepRDyagu3lwaS 5agw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=33ZIMHpnvTQJ0HhYYK+BdNXEaLlBkQcN/kesFZkiWTA=; b=AF/QprHhd7/vGQsHpwtd8xJt+mA3jiV7X2VOKhDWjwbV21HqGmeBYsSgot2JV8isGA fFi8/wj2QvbxmBk4dbYklXiXy5Gw+AEdEiX9D9Jk9gBWbgYUNcNxl6praqfmJ6iFPXl6 Owv3b1sWIBSr55GCH5P98nkTpX8MQZFApHiPk1BmihXJWZY8LNUHhcIh4Di1zU85cknN 3+R2+25bhuXH4Ipl/6uRH/t44pEBdYwtHT4vLkSN3WIEnuUO1FmO+VjL/RQKKy5+NMGl z6llPaagc10GpLNF/CdgMwNCLIZ3mWuQcQg8Lf3vB8we5GQRbN0mIkPRKdJlcYjReeZ7 HNHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h129si3355589pfb.56.2021.09.29.07.12.49; Wed, 29 Sep 2021 07:13:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344009AbhI2NC1 (ORCPT + 99 others); Wed, 29 Sep 2021 09:02:27 -0400 Received: from outbound-smtp56.blacknight.com ([46.22.136.240]:46273 "EHLO outbound-smtp56.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343889AbhI2NCZ (ORCPT ); Wed, 29 Sep 2021 09:02:25 -0400 Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp56.blacknight.com (Postfix) with ESMTPS id 0342AFB57E for ; Wed, 29 Sep 2021 14:00:43 +0100 (IST) Received: (qmail 13619 invoked from network); 29 Sep 2021 13:00:42 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Sep 2021 13:00:42 -0000 Date: Wed, 29 Sep 2021 14:00:41 +0100 From: Mel Gorman To: Linux-MM Cc: NeilBrown , Theodore Ts'o , Andreas Dilger , "Darrick J . Wong" , Matthew Wilcox , Michal Hocko , Dave Chinner , Rik van Riel , Vlastimil Babka , Johannes Weiner , Jonathan Corbet , Linux-fsdevel , LKML Subject: Re: [PATCH 0/5] Remove dependency on congestion_wait in mm/ v2 Message-ID: <20210929130040.GJ3959@techsingularity.net> References: <20210929100914.14704-1-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210929100914.14704-1-mgorman@techsingularity.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 29, 2021 at 11:09:09AM +0100, Mel Gorman wrote: > This is a series that removes all calls to congestion_wait > in mm/ and deletes wait_iff_congested. It's not a clever > implementation but congestion_wait has been broken for a long time > (https://lore.kernel.org/linux-mm/45d8b7a6-8548-65f5-cccf-9f451d4ae3d4@kernel.dk/). > Even if it worked, it was never a great idea. While excessive > dirty/writeback pages at the tail of the LRU is one possibility that > reclaim may be slow, there is also the problem of too many pages being > isolated and reclaim failing for other reasons (elevated references, > too many pages isolated, excessive LRU contention etc). > Don't send series after taking time off. This is the completely wrong set of patches, it's v1 again, sorry. I'll fix up a v3. -- Mel Gorman SUSE Labs