Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 10/13] x86/uintr: Introduce user IPI sender syscalls
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <x86@kernel.org>, Tony Luck <tony.luck@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Jens Axboe <axboe@kernel.dk>,
        Christian Brauner <christian@brauner.io>,
        Peter Zijlstra <peterz@infradead.org>,
        Shuah Khan <shuah@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Jonathan Corbet <corbet@lwn.net>,
        Ashok Raj <ashok.raj@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "Gayatri Kammela" <gayatri.kammela@intel.com>,
        Zeng Guang <guang.zeng@intel.com>,
        "Dan Williams" <dan.j.williams@intel.com>,
        Randy E Witt <randy.e.witt@intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Ramesh Thomas <ramesh.thomas@intel.com>,
        <linux-api@vger.kernel.org>, <linux-arch@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20210913200132.3396598-1-sohil.mehta@intel.com>
 <20210913200132.3396598-11-sohil.mehta@intel.com>
 <YUxy6XqMB1+DYJtP@kroah.com> <4704e81d-a3d2-aedf-1c79-e45cc86826a5@intel.com>
 <YVQQFs4HC3tn2GiG@kroah.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
Message-ID: <40eb2b51-b928-0bf4-aac7-abd7032af640@intel.com>
Date:   Wed, 29 Sep 2021 07:27:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
In-Reply-To: <YVQQFs4HC3tn2GiG@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0lnN3l6bnczZFpia3FXSmJxR0E2aFJIQ20vbU5tekhtb2R6SHM1cnBlQmlt?=
 =?utf-8?B?ZHBDZzlzL2tZMVA4QUVyblp4ZG9TSVk0cTRQL3VaZ2RRdDlva21vWW8zTi9n?=
 =?utf-8?B?SzFYM3d6NDNxVGxGcmlERlNvRUJoODlvUHY1M01OTklxYUM2T0g0QzRzYlVR?=
 =?utf-8?B?TEUrSDFYZCtEVUM4R05zTEZWSmx6UnpxUEx2WDZYeDFxM3dNZUJGNCtzbmJ1?=
 =?utf-8?B?U0pvMUVqeTMxZjlpV29COFVMREs3Tng1cjZKY0s4NkdNZmFzZUp2dTFUN2VN?=
 =?utf-8?B?cDRUQXk4bjVCM3VLT1N6YU9TL0FBVjRHZjVaZkoxNno1VEV1RGhUSnRQT1Br?=
 =?utf-8?B?M0RCWHVJNU9MSWJhelAwVWF4WGtBZXIwSm1vZjBBdjEzdVcwUFB5Ukc5RUx4?=
 =?utf-8?B?M3Vod1ZvTVhBM05WTnI4ZWlVeEQ0UjI0YktsMXN6Vk5ZYmJ3SXVLOGhnZW0x?=
 =?utf-8?B?SnRGWVFTTFVZV0E4ZWsxWmp2MEpXMDBuTDlwM1BlYzRpRHBDMmQ2Ny9aS2Rh?=
 =?utf-8?B?T29hSnp2eHlDUFFSaFN4UlJYNmJoMzBEMHpjYmNqdDJ3VWg2M2FTWWpGMVUx?=
 =?utf-8?B?enRtY2I0RzVseCtxTE1EVjMxTVNER05YTm5kNml3clFxeit6QnFaa1I4Zmx2?=
 =?utf-8?B?REhOODhjazlHbTZPc3lRajVLc0x6a05QVW5vVTRlbVN2dHdGb24wa1paRlk3?=
 =?utf-8?B?UEorQVRCQVNETmVWQ28vb25LYVE2ZXE2Q0tvTjArc2p3OEVQenJNSURGVVJT?=
 =?utf-8?B?U2Yzb1JHM256SXhIV0xLbkJTdXdkeU9BRFhZSVVQbVFvaWVHSG03aGM3ek15?=
 =?utf-8?B?ZU83M2EwK1pmcHdKVFZUN3poa1hYcG9tOEJ6RUMwV0luS0tFUm1PTURFVTN6?=
 =?utf-8?B?dUZ2S3VXZnFSZ1RDcUFPazBhS2JKc0ZWOXJubnF0cS9GSGo3ZDRQamNsMXl2?=
 =?utf-8?B?Q1loNVp0QmxUSTZPL1dSNzV4SXB3UmJ1RDdGQ1RTektWSzQ2anFGay9tYitF?=
 =?utf-8?B?ZERLUGJHUGp3M1JJQzZ3QkJwWlJyZ2ZhLy9Sdk1qWmFzeHNvTnMxamlGT3p0?=
 =?utf-8?B?eVdMb3RYdEt4QWl2RU9pTldqbStHZ2RHNnFkOW1QTGhBRjQ4eHZseHdVTnJ4?=
 =?utf-8?B?N2huQXNCZVlxTjhtc1Bzdm9XcjJFbzVNTkp4b0lZb0RNYnZpdy9vUlRleFEz?=
 =?utf-8?B?dEl1UmVydDlkU1UxTUZwVzBFS1lWRmczUEdzWHNLbytlUC9OQ0s5N1JhT0Jq?=
 =?utf-8?B?M0dzWldHOXZyMnJoTjNnOXNzWGVseXZmRGtzTnB0UE9uSTg2eGc0SWJiTXlz?=
 =?utf-8?B?SkRZOU15SFVCblpmMU1UU1k3R1UvZ1k4c3ZVamNDWld4UnpacW00ellEWWpS?=
 =?utf-8?B?SFRoNCtpZUpJVXp2UElIalRYcFlmR0ZITG1hRHlLNXpKOGdqQkJqOG9JYmVK?=
 =?utf-8?B?NjNjZ2NSQnNjWVF5RXhmYm9EWXhuM1FiaUxMQ05pLy9lamxHZmJ6K05vOEJx?=
 =?utf-8?B?anhSRS9PaTlTM0RvdU1senlXdHlKV01acUNQMFMwUEZzcWg5ZlZIV3lTdVQx?=
 =?utf-8?B?R2tCSGNrMHBYUThZbHQ1UElNcExETklWalpRM2t6ZTdiUnlZUGhoVVBTWFRM?=
 =?utf-8?B?VkJaZjhNampQUG5aWWRCSmNCUDhzelFhcWZRSnhUZFNiTFBnNXlSOTJ4N2t4?=
 =?utf-8?B?K0JrMFpWUllBY2J4MExUeG1XWVlhdDA5OUx6Ujk4M0F0Rk5INit1dXJRRzVs?=
 =?utf-8?Q?XDp4n4o/2PTBnGmzdccVghYGauKmENrf7ISJSma?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e4f6cca-e1f4-4e90-388f-08d983553c68
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 14:27:16.1696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tt7eIc5AYVFLJ24AuOzCfFwHJR9rYCO6zL588oBtUUSk5tYIvEJZKgV6XeoeXMEZtoLdmcUx8NUflCEHueld3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3237
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/29/2021 12:04 AM, Greg KH wrote:
> On Tue, Sep 28, 2021 at 11:01:54AM -0700, Sohil Mehta wrote:
>>
>> Is this reasonable or would you still prefer a pointer?
> Ok, just document it really well that this is NOT a real address used by
> the kernel.  As it is, that's not obvious at all.


Thanks. I'll do that.

>
> And if this crosses the user/kernel boundry, it needs to be __u64 right?


This one doesn't cross the user/kernel boundary. The kernel programs a 
value in this struct for the hardware to consume.

But there might be other places where I have missed that. I'll fix those.

Thanks,
Sohil