Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Envelope-to: git@xilinx.com,
 linux-kernel@vger.kernel.org,
 viresh.kumar@linaro.org,
 krzk@kernel.org,
 robh+dt@kernel.org,
 michael@walle.cc,
 linux-arm-kernel@lists.infradead.org,
 geert+renesas@glider.be,
 devicetree@vger.kernel.org,
 monstr@monstr.eu,
 robh@kernel.org
Subject: Re: [PATCH v5] arm64: zynqmp: Add support for Xilinx Kria SOM board
To:     Rob Herring <robh@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>
CC:     <monstr@monstr.eu>, <devicetree@vger.kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        <linux-arm-kernel@lists.infradead.org>,
        "Michael Walle" <michael@walle.cc>,
        Rob Herring <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzk@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>, <git@xilinx.com>,
        <linux-kernel@vger.kernel.org>
References: <1ba32590670434b650bacf6410a65579dd30b38b.1632294439.git.michal.simek@xilinx.com>
 <YVIPAGckmsYmrVv1@robh.at.kernel.org>
From:   Michal Simek <michal.simek@xilinx.com>
Message-ID: <72a2f8e1-eb6e-4642-a88e-36028b7bdae4@xilinx.com>
Date:   Wed, 29 Sep 2021 13:48:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YVIPAGckmsYmrVv1@robh.at.kernel.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 11:48:57.5728
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a1683f3-6465-4261-fe8c-08d9833f1f13
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT032.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB7576
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/27/21 8:35 PM, Rob Herring wrote:
> On Wed, 22 Sep 2021 09:07:32 +0200, Michal Simek wrote:
>> There are couple of revisions of SOMs (k26) and associated carrier cards
>> (kv260).
>> SOM itself has two major versions:
>> sm-k26 - SOM with EMMC
>> smk-k26 - SOM without EMMC used on starter kit with preprogrammed firmware
>> in QSPI.
>>
>> SOMs are describing only devices available on the SOM or connections which
>> are described in specification (for example UART, fwuen).
>>
>> When SOM boots out of QSPI it uses limited number of peripherals defined by
>> the specification and present in sm(k)-k26 dtses.
>> Then a carrier card (CC) detection is happening and DT overlay is applied
>> to brings new functionality. That's why DT overlays are used. The name is
>> composed together with SOM name and CC name that's why DT overlays with
>> these names are generated to make sure they can be used together.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Changes in v5:
>> - Extend commit message.
>>
>> Changes in v4:
>> - Remove ina260 and usb5744 nodes
>> - Remove compatible string from overlays
>>
>> Changes in v3:
>> - Fix led node name
>> - Fix compatible string for xlnx,zynqmp-sk-kv260-revA/Y/Z
>> - Fix headers alignment
>> - Move USB3 PHY properties from DWC3 node to USB node - reported by Manish
>>   Narani
>> - Change dtb names generated with dtbo
>> - Fix emmc comment style
>>
>> Changes in v2:
>> - Use sugar syntax - reported by Geert
>> - Update copyright years
>> - Fix SD3.0 comment alignment
>> - Remove one newline from Makefile
>>
>> https://www.xilinx.com/products/som/kria.html
>> Based on
>> https://lore.kernel.org/r/cover.1628244703.git.michal.simek@xilinx.com
>>
>> ---
>>  .../devicetree/bindings/arm/xilinx.yaml       |  16 +
>>  arch/arm64/boot/dts/xilinx/Makefile           |  13 +
>>  .../boot/dts/xilinx/zynqmp-sck-kv-g-revA.dts  | 315 ++++++++++++++++++
>>  .../boot/dts/xilinx/zynqmp-sck-kv-g-revB.dts  | 298 +++++++++++++++++
>>  .../boot/dts/xilinx/zynqmp-sm-k26-revA.dts    | 289 ++++++++++++++++
>>  .../boot/dts/xilinx/zynqmp-smk-k26-revA.dts   |  21 ++
>>  6 files changed, 952 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-sck-kv-g-revA.dts
>>  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-sck-kv-g-revB.dts
>>  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts
>>  create mode 100644 arch/arm64/boot/dts/xilinx/zynqmp-smk-k26-revA.dts
>>
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 

Applied.
M