Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1800633.tdWV9SEqCh@kreacher> <20210928232823.GA748352@bhelgaas>
In-Reply-To: <20210928232823.GA748352@bhelgaas>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 29 Sep 2021 14:00:59 +0200
Message-ID: <CAJZ5v0gr+o_AO7-EGRofU2UN_8aXivh5c-VQ9VKz7o4ZNq=VQw@mail.gmail.com>
Subject: Re: [PATCH v2 0/7] PCI: ACPI: Get rid of struct pci_platform_pm_ops
 and clean up code
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>,
        Linux PCI <linux-pci@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Ferry Toth <fntoth@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Sep 29, 2021 at 1:28 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> [+cc Ferry]
>
> On Mon, Sep 20, 2021 at 08:52:19PM +0200, Rafael J. Wysocki wrote:
> > Hi All,
> >
> > As explained in the changelog of patch [2/7], using struct pci_platform_pm_ops
> > for ACPI is not particularly beneficial, so it is better to get rid of it and
> > call the functions pointed to by it directly from the PCI core.
> >
> > However, struct pci_platform_pm_ops is also used by the Intel MID support code,
> > but it is actually better to call the MID PM function directly from the PCI
> > core either, which is done in patch [1/7].
> >
> > After these changes, patch [3/7] removes struct pci_platform_pm_ops and the
> > rest is just cleanups and some code consolidation on top of that.
>
> I like these a lot.  Not sure exactly where everything is after the
> conversation with Ferry.

It's mostly OK, the problem was in one of the "tail" patches that was
not rebased properly.

There will be a follow-up series to test for Ferry (later today).

>  Let me know if I should be doing anything.

I'm going to take this lot if that's not a problem.  If I need
anything from you, I'll let you know.