Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210929070807.4488-1-jason-jh.lin@mediatek.com>
In-Reply-To: <20210929070807.4488-1-jason-jh.lin@mediatek.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Wed, 29 Sep 2021 22:57:05 +0800
Message-ID: <CAAOTY_-EEz0tAU_XoL789uOXx_hKGCz53vaaZrA4DSNM4NZ=8g@mail.gmail.com>
Subject: Re: [PATCH] mailbox: Remove WARN_ON for async_cb.cb in cmdq_exec_done
To:     "jason-jh.lin" <jason-jh.lin@mediatek.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Yongqiang Niu <yongqiang.niu@mediatek.com>,
        Hsin-Yi Wang <hsinyi@google.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Nancy Lin <nancy.lin@mediatek.com>, singo.chang@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Jason:

jason-jh.lin <jason-jh.lin@mediatek.com> =E6=96=BC 2021=E5=B9=B49=E6=9C=882=
9=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=883:08=E5=AF=AB=E9=81=93=EF=
=BC=9A
>
> Because mtk_drm_crtc_update_config is not using cmdq_pkt_flush_async,
> it won't have pkt->async_cb.cb anymore.
>
> So remove the WARN_ON check of pkt->async_cb.cb at cmdq_exec_done.

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

>
> Fixes: 1b6b0ce2240e ("mailbox: mtk-cmdq: Use mailbox rx_callback")
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmd=
q-mailbox.c
> index 64175a893312..c591dab9d5a4 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -195,7 +195,6 @@ static void cmdq_task_exec_done(struct cmdq_task *tas=
k, int sta)
>         struct cmdq_task_cb *cb =3D &task->pkt->async_cb;
>         struct cmdq_cb_data data;
>
> -       WARN_ON(cb->cb =3D=3D (cmdq_async_flush_cb)NULL);
>         data.sta =3D sta;
>         data.data =3D cb->data;
>         data.pkt =3D task->pkt;
> --
> 2.18.0
>