Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp818041pxb; Wed, 29 Sep 2021 10:15:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzqWy5eoGF73Y979jrELD5S8/fNXARxZDyji5CaQ+ZB6nFpvXIyelpINhdxh/VizxReK5IC X-Received: by 2002:a17:90a:ce02:: with SMTP id f2mr1076665pju.231.1632935742281; Wed, 29 Sep 2021 10:15:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632935742; cv=none; d=google.com; s=arc-20160816; b=DIDdINZv/Cm65bI1YGdgu53Ux4cAZEuubrWexDTNYWTQmpuPG6gJfogKGZzyRIgFkV z6iGyjEtFQal8b62Sfjui9VO+LgEmxji6gPpu4komm6kv7sDNQkzWAQwwnQrXPbRO4Oa tYfItUNAXJgHMbQj1FZX+UGz9f3y+wH1oqtqEH5Fg2CNAvGaYSAEC4ryaUgx2k+hxRf8 u5/VJYNO9lXsTAWb8AbGzYhS1v0eeTJYTv9mHQeJIIstV40hKfPKoK1UjD2TBbIYiKD4 ZecsD1a3rDLKhcGcCXFSn01WNUoGxZtpFGJMbwbypNKbLQHEm+C/LgcCM2bMjuj5//jh HNZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=T/3gWWaTFkeLAbvfTxWFAO1wwDFgBNDSr8q8r87+huA=; b=fPc/qRJ4MjaLMe45g9TjHwBh1VTewxV3U8Oqj0WupTP+NtwZT3aslXIXtD+45Un/1Y K5CSwWtV2LLgpSbhYZ1W49IpyJKC6kPBgn3xWQhBOXneoLQKhhbvoSXHlSkJt97+6J4g VQ6J+qPFMRd3wNe6vmSMF/OxOsqnkdHoqMCtD9FtXWN983zGs8zFyTvqCfkOPi7zVf28 0vYDxWuvH5/ckmwx5QDhzK3tb6gvI7xz+Gulc0psFAwZBQK0xgaSRlutuyGyHy7D1HJN SlzgWgoqbTZEMGbd584fsDUYWisGQoZRFED33Y2LAqKMK3GkJKzwI3BeryHBlTAoSkn1 fKhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codesynthesis.com header.s=mail1 header.b=diMRE4c+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w2si579191plk.154.2021.09.29.10.15.27; Wed, 29 Sep 2021 10:15:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@codesynthesis.com header.s=mail1 header.b=diMRE4c+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245142AbhI2ODf (ORCPT + 99 others); Wed, 29 Sep 2021 10:03:35 -0400 Received: from codesynthesis.com ([188.40.148.39]:60556 "EHLO codesynthesis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235324AbhI2ODe (ORCPT ); Wed, 29 Sep 2021 10:03:34 -0400 Received: from brak.codesynthesis.com (197-255-152-207.static.adept.co.za [197.255.152.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by codesynthesis.com (Postfix) with ESMTPSA id 59B006034F; Wed, 29 Sep 2021 14:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codesynthesis.com; s=mail1; t=1632924112; bh=Z+OEKtbxovOrH0YtiK7ebFEQZ9u9CA6/TnGWji7eu1s=; h=Date:From:To:Subject:Message-ID:MIME-Version:From; b=diMRE4c+HrA0+ROMwPMetBbloH2B0zIi7vfKoVeSVt7sNiuxE4A3ul4QzOmcJ0Pge 3PbjJKKxxf+mHkIbAhhuQF7cx/kmuSkjxB5jhSx6MWI5HA4j75F7afy5fa4R1r1NTW lqIDVnC9QxPKEaEBQHBcCRUZzwGMeqyFnkSN05xus5MvstF7cxD/6cr4up9wtKwK1B geRtJpEfJGippfq+VUq9+tZgn4D2rkqCNa+QpmYhA9Ql9gqBgACZcfdQYMqDj5hWbg DObm70VmK5cXE5EYhQTiNnzjnreKdpRPUUPZfz2gLq8ITgtOLPwouPNJeRcAJ4ZE9i xz+Iq8CWRHsFQ== Received: by brak.codesynthesis.com (Postfix, from userid 1000) id 2DB661A800C4; Wed, 29 Sep 2021 16:01:48 +0200 (SAST) Date: Wed, 29 Sep 2021 16:01:48 +0200 From: Boris Kolpackov To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] kconfig: rename a variable in the lexer to a clearer name Message-ID: References: <20210927125437.818092-1-masahiroy@kernel.org> <20210927125437.818092-2-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210927125437.818092-2-masahiroy@kernel.org> Organization: Code Synthesis User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masahiro Yamada writes: > In Kconfig, like Python, you can enclose a string by double-quotes or > single-quotes. So, both "foo" and 'foo' are allowed. > > The variable, "str", is used to remember whether the string started with > a double-quote or a single-quote. > > Rename it to a clearer name. The type should be 'char'. LGTM. Reviewed-by: Boris Kolpackov